Commit Graph

103 Commits

Author SHA1 Message Date
Heinrich Lee Yu 2de0bcf800 Remove redirecting to last visited board
Move this to EE-only. It isn't useful here since there's only one board
2019-03-13 20:33:35 +08:00
Heinrich Lee Yu 7d5ee4181a Refactor groups and projects boards actions
Move common functionality to BoardsActions concern
2019-03-13 20:33:35 +08:00
Mayra Cabrera 7e9348f359 Enable/disable Auto DevOps at Group level
- Includes instance methods on Group model to detect when a group has
AutoDevOps explicitly/implicitly enabled/disabled.
- Includes migration to add a new column to namespaces table
- Add UI necessary modifications
- Add service and controller to update auto devops
related instances
- Updates project and groups auto devops badges

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52447
2019-03-12 10:15:33 +00:00
Grzegorz Bizon 5cea1e8b80 Merge branch '56937-edit-knative-domain' into 'master'
Edit Knative domain after it has been deployed

Closes #56937

See merge request gitlab-org/gitlab-ce!25386
2019-03-07 12:43:34 +00:00
João Cunha 3bdff7aadf Rename ClusterUpdateAppWorker to ClusterPatchAppWorker
- This is to avoid colision with EE ClusterUpdateAppWorker
2019-03-05 15:21:29 +00:00
João Cunha f8234d9a08 Creates Clusterss::ApplciationsController update endpoint
- Creates new route
- Creates new controller action
- Creates call stack:
  Clusterss::ApplciationsController calls -->
  Clusters::Applications::UpdateService calls -->
  Clusters::Applications::ScheduleUpdateService calls -->
  ClusterUpdateAppWorker calls -->
  Clusters::Applications::PatchService -->
  ClusterWaitForAppInstallationWorker

DRY req params

Adds gcp_cluster:cluster_update_app queue

Schedule_update_service is uneeded

Extract common logic to a parent class (UpdateService will need it)

Introduce new UpdateService

Fix rescue class namespace

Fix RuboCop offenses

Adds BaseService for create and update services

Remove request_handler code duplication

Fixes update command

Move update_command to ApplicationCore so all apps can use it

Adds tests for Knative update_command

Adds specs for PatchService

Raise error if update receives an unistalled app

Adds update_service spec

Fix RuboCop offense

Use subject in favor of go

Adds update endpoint specs for project namespace

Adds update endpoint specs for group namespace
2019-03-05 08:32:51 +02:00
Małgorzata Ksionek 211c4e5985 Change policy regarding group visibility 2019-02-20 11:08:13 +01:00
Dylan Griffith 3016a2a360 Remove TLD validation from Cluster#domain 2019-02-14 16:25:41 -06:00
Mayra Cabrera 087af654bb Addresses backend/db review comments
- Fixes multiple typos on AutoDevops script
- Add an alias to Clusters::Cluster#domain as base_domain, so it's more
descriptive
- Removes unnecessary memoization on qa specs
- Changes migration to a post migration to deal better with traffic on
big instances (like gitlab.com)
2019-02-04 12:08:09 -06:00
Mayra Cabrera 8ff73614a1 Moves domain setting to Cluster setting
Changes domain field to be on the Cluster page show, removing it from
Auto DevOps setting. Also injects the new environment variable
KUBE_INGRESS_BASE_DOMAIN into kubernetes#predefined_variables.

Migration to move the information from ProjectAutoDevops#domain
to Clusters::Cluster#domain. As well as necessary modifications to qa
selectors

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52363
2019-02-04 11:43:34 -06:00
James Lopez c653921b6f
Add subresources removal to member destroy service 2019-01-31 16:52:50 +01:00
Sean McGivern dfa31d5f2f Merge branch '54905-milestone-search' into 'master'
Resolve "Milestone search"

Closes #54905

See merge request gitlab-org/gitlab-ce!24265
2019-01-25 13:22:34 +00:00
Jacopo 22eb2e4c22 Adds milestone search
Adds to search ILIKE search for milestones title in:
  - Milestones dashboard
  - Group milestones page
  - Project milestones page
2019-01-24 18:44:09 +01:00
Rémy Coutable 3a2abc1d50
Enable the Layout/ExtraSpacing cop
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-01-24 13:05:45 +01:00
Mike Greiling a4833f6fe0 Merge branch 'ccr/49289_milestone_link' into 'master'
Add project milestone link

Closes #49289

See merge request gitlab-org/gitlab-ce!22552
2019-01-02 21:17:16 +00:00
John Jarvis 082a656702 Merge branch 'security-master-group-cicd-settings-accessible-to-maintainer' into 'master'
[master] Group Ex-Maintainer Could maintain Access to Project's Source Code/Jobs/Pipelines/Artifacts if it had Shared Group Runner Configured

See merge request gitlab/gitlabhq!2721
2019-01-01 20:38:07 +00:00
Fatih Acet e9ef02096b
Add project milestone link to dashboard milestones
One of the steps to deprecate dashboard milestones.
Links do dashboard milestone are replaced with links for each
project milestone
2018-12-20 13:33:09 +01:00
Matija Čupić 178270a0f3
Check for group admin permissions 2018-12-20 12:21:49 +01:00
Jasper Maes bebc526e3e Remove deprecated xhr from specs 2018-12-19 23:29:51 +01:00
blackst0ne b44a2c801a Update specs to rails5 format
Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`
2018-12-19 10:04:31 +11:00
Mike Greiling 603c748ca3 Remove trailing commas to satisfy rubocop 2018-11-08 23:28:30 +13:00
Thong Kuah 5a042ef2fb Only project clusters has Project Namespace field
Group clusters should not allow Project Namespace so don't show that
field input too
2018-11-08 23:28:30 +13:00
Thong Kuah 5303718402 Minor updates to spec for readability
Based on BE reviewer feedback
2018-11-08 23:26:04 +13:00
Mayra Cabrera 675bfd50a9 Adds feature flag for Group Clusters
As the frontend is still in progress and other related backend is still
in prgress we need a feature flag to turn off Group Clusters.
2018-11-08 23:26:04 +13:00
Thong Kuah 54e8ff0f21 Extend clusters_controller for group type clusters
- Add pages javascripts to intialize clusters for group pages

- Move specs asserting gcp specific validations from controller into
UpdateService spec

- Also teach Clusters::ApplicationController about groups
2018-11-08 23:14:06 +13:00
Brett Walker 13dbfa90d2 Fix transient error with boards_controller_spec 2018-11-03 10:33:19 -05:00
George Tsiolis 733ae94921 Fix typos in comments and specs 2018-11-01 08:59:20 +02:00
Brett Walker c11cb0b38f Fix problem with spec that showed up in EE merge 2018-10-29 20:39:24 -05:00
Brett Walker 7aeab58f48 Automatically navigate to last board visited 2018-10-26 12:49:16 +00:00
Tomasz Maczukin 42af229510
Simplify runner registration token resetting
This icommit adds several changes related to the same topic
- resetting a Runner registration token:

1. On Project settings page it adds a button for resetting the
   registration token and it removes the Runner token field
   that was confusing all GitLab users.

2. On Group settings page it adds the same button for resetting
   the registration token.

3. On Admin Runners settings page it moves the button to the same
   place as in Project and Group settings and it changes slightly
   the page layout to make it more similar to Group and Project
   setting pages.

4. It refactorizes a little the partial that prints runner
   registration description. Thanks to this Project, Group
   and Admin settings of the Runner are re-using the same
   code to generate the button.

5. Updates the translations of changed text.
2018-10-04 08:37:01 +02:00
Felipe Artur abb50ff471 Allow to delete group milestones 2018-08-06 17:31:47 -03:00
Mark Chao a63bce1a4b Resolve "Rename the `Master` role to `Maintainer`" Backend 2018-07-11 14:36:08 +00:00
Jan Provaznik 656d4ebf67 Add workhorse authorize method for project/group uploads
This method can be used by workhorse to get presigned
URLs used for direct upload of files.
2018-06-18 09:11:02 +02:00
Robert Speicher 6d165c740c Make all uses of `fixture_file_upload` use relative paths 2018-06-07 09:54:41 -05:00
Bob Van Landuyt 2f50b206f2 Hide archived projects from `shared_projects`
Since we don't show the archived projects, we shouldnot  load them and
pass them to the fronted to be filtered out again.
2018-06-04 17:43:13 +02:00
Kamil Trzciński 051f385e7e Refactor validations and make runner factory by default to be instance-wide runner 2018-05-31 10:56:07 +02:00
Dylan Griffith ab489d293d Improve runner_type validations for Ci::Runner 2018-05-31 10:46:19 +02:00
Toon Claes 1298fbe18d Fix small typos 2018-05-29 11:45:17 +02:00
Bob Van Landuyt 6072259230 Add `shared_projects` endpoint
This endpoint lists projects shared with a group visible to the
current user.

The `filter` and `sort` params are supported like on the `children` endpoint.
2018-05-29 11:45:17 +02:00
Dylan Griffith 91f358942e Allow to pause,resume,show,edit,destroy group runners (#10244) 2018-05-07 08:54:07 +02:00
Felipe Artur dd071c4b6e Bring one group board to CE 2018-03-03 12:56:17 -03:00
Jan Provaznik 1f4ee653fa Allow to include also descendant group labels
Because epic index page includes also epics from subgroups
it's necessary to also get descendant group labels for filtering.
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/4773#note_61236542
2018-03-02 11:44:18 +01:00
Jan Provaznik 911fd7c252 Support additional LabelsFinder parameters for group labels
In some situations (listing labels for epics) we want to
list only group ancestor labels, this is already supported
in LabelsFinder we just need to enable additional parameters.

Also `set_issuables_index` method now loads project labels only if
@project is set (which is not used for epic group labels).
2018-03-02 08:50:00 +01:00
Matija Čupić f7ed096455
Extract Variables controllers specs to shared_examples 2018-02-05 18:58:21 +01:00
Matija Čupić 45a14b4f58
Refactor Variable controllers specs 2018-02-05 18:58:21 +01:00
Matija Čupić 18232d7efb
Extract Variable into separate JSON Schema 2018-02-05 18:58:21 +01:00
Matija Čupić 558057010f
Extract variable parameters in VariablesController specs 2018-02-05 18:58:20 +01:00
Matija Čupić 04263b9f3b
Add GroupVariableSerializer for Ci::GroupVariable 2018-02-05 18:58:20 +01:00
Matija Čupić b48d8c8ad0
Return all variables after UPDATE 2018-02-05 18:58:19 +01:00
Matija Čupić 9eb3bb5cff
Change POST to PATCH requests in the controller specs 2018-02-05 18:58:19 +01:00