Commit Graph

71 Commits

Author SHA1 Message Date
Luke "Jared" Bennett bef42d9a36 Fallback localstorage cases 2017-05-05 17:59:41 +00:00
Kushal Pandya 645593e5af Add instant comments support 2017-05-05 10:57:29 +00:00
Phil Hughes a7a3c48bcc Double quotes around gl emoji title 2017-05-03 10:54:30 +01:00
Phil Hughes 81a37ca1ee Moved the title onto the emoji tag
This adds the description in all places emojis are used
2017-04-24 17:08:12 +01:00
Jacopo de62d3b48c Expand/collapse button -> Change to make it look like a toggle
Changed the expand/collapse button to look different when is
opened/closed
2017-04-16 11:51:21 +02:00
Mike Greiling 77dcb1f8c7 consolidate all behavior imports into an index.js file 2017-04-04 02:54:47 -05:00
Mike Greiling 5bff1af5cb refactor and fix eslint violations in behaviors directory 2017-04-04 02:53:58 -05:00
Jacob Schatz 01b5d885d9 Merge branch '29414-fix-toggle-discussion-link-jump' into 'master'
Fix link togglers jumping to top

Closes #29414

See merge request !9918
2017-03-28 18:15:22 +00:00
Eric Eastwood cf3c43980d Fix link togglers jumping to top
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/29414
2017-03-28 11:09:12 -05:00
Eric Eastwood 5e24ac8efa Remove spreadString in favor of polyfilled Array.from
Fix https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10120

We use this to split up astral symbols

```js
// ["🖐", "🏿"]
Array.from('🖐🏿');
```
2017-03-24 02:20:47 -05:00
Eric Eastwood d4c8e84787 Fix "N changed files" link toggler jumping to top
Thanks for the spot @DouweM
https://gitlab.slack.com/archives/C0GQHHPGW/p1490132124022958

See previous MR
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9943

See subsequent MR
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9918

Togglers to check:

 - "Create a Mattermost team for this group" Checkbox,
   http://localhost:3000/groups/new (enable `mattermost` in
`config/gitlab.yml`)
 - "Repo by Url" button, http://localhost:3000/projects/new
 - In MR widget "Modify commit message",
   http://localhost:3000/gitlab-org/gitlab-ce/merge_requests/9
 - Discussion "Toggle discussion",
   http://localhost:3000/gitlab-org/gitlab-ce/merge_requests/3
 - "Showing **1 changed file** with 4 additions and 7 deletions" ,
   http://localhost:3000/gitlab-org/gitlab-ce/merge_requests/3/diffs
 - Commit description toggle "...",
   http://localhost:3000/gitlab-org/gitlab-ce/commits/master
2017-03-21 16:57:12 -05:00
Eric Eastwood a8a52a587d Protect against unknown emojis in frequently used list
See https://gitlab.slack.com/archives/frontend/p1489690607738864
2017-03-16 17:22:21 -05:00
Eric Eastwood f97c1d1001 Fix link togglers jumping to top
Fix #29414
2017-03-14 11:53:22 -05:00
Mike Greiling 29e0cb4b91 Organize our polyfills and standardize on core-js 2017-03-13 21:48:32 +00:00
Eric Eastwood ee9930145f Update emojis to use harmony modules (import/export) 2017-03-08 11:27:14 -06:00
Filipa Lacerda 0ec62b6c5d Merge branch '26371-native-emojis-v3' into 'master'
Add emoji images - Base Native Unicode Emojis

Closes #26371

See merge request !9569
2017-03-07 02:34:48 +00:00
Eric Eastwood f602efea65 Fix wrong image src with cached gl-emoji and relative root 2017-03-06 12:54:46 -06:00
Eric Eastwood c4801e2a16 Fix up off index when reading canvas and something failed 2017-03-06 12:54:46 -06:00
Eric Eastwood a8140d5c01 Fix up `watch` alias lookup in Firefox
It was pulling
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/watch
2017-03-06 12:54:46 -06:00
Eric Eastwood e6fc0207cb Use native unicode emojis
- gl_emoji for falling back to image/css-sprite when the browser
   doesn't support an emoji
 - Markdown rendering (Banzai filter)
 - Autocomplete
 - Award emoji menu
    - Perceived perf
    - Immediate response because we now build client-side
 - Update `digests.json` generation in gemojione rake task to be more
   useful and  include `unicodeVersion`

MR: !9437

See issues

 - #26371
 - #27250
 - #22474
2017-03-06 12:54:46 -06:00
Z.J. van de Weg 2199906dca Fix JS linting error 2017-03-06 19:51:08 +01:00
Z.J. van de Weg 394678381b Fix no out element case 2017-03-06 16:15:01 +01:00
Z.J. van de Weg 597639c096 Fix eslint 2017-03-06 14:58:53 +01:00
Luke "Jared" Bennett 1fbc488668
Corrected JS for new master js build updates [ci skip] 2017-03-02 15:07:58 +00:00
Z.J. van de Weg 9f0e23d609 Fix tests 2017-02-24 13:25:42 +01:00
Luke "Jared" Bennett 173e27d62a
Finished up mattermost team creation 2017-02-22 10:19:42 +00:00
Mike Greiling 0f31c5a92b replace implicit this == window with explicit binding 2017-02-17 16:58:32 -06:00
Mike Greiling 7ca57c59c8 Merge branch 'master' into webpack
* master: (63 commits)
  Use `add_$role` helper in snippets specs
  removes old css class from everywhere
  Fixes broken build: Use jquery to get the element position in the page
  Check public snippets for spam
  Keep snippet visibility on error
  Update pipeline and commit URL and text on CI status change
  Support non-ASCII characters in GFM autocomplete
  Active tense test coverage
  Fix filtered search manager spec teaspoon error
  Reduce the number of loops that Cycle Analytics specs use
  Remove unnecessary returns / unset variables from the CoffeeScript -> JS conversion.
  update spec
  Change the reply shortcut to focus the field even without a selection.
  use destroy_all
  Remove settings cog from within admin scroll tabs; keep links centered
  add changelog
  remove old project members from project
  add spec replicating validation error
  Improve styling of the new issue message
  Don't capitalize environment name in show page
  ...
2017-02-02 11:45:58 -06:00
Filipa Lacerda 4f5a77a440 Merge branch '27089-26860-27151-fix-discussion-note-permalink-collapsed' into 'master'
Fix permalink discussion note being collapsed

Closes #26860, #27089, and #27151

See merge request !8773
2017-02-01 22:31:38 +00:00
Mike Greiling 5fcbe12730 Merge branch 'master' into go-go-gadget-webpack
* master: (83 commits)
  Fix small typo on new branch button spec
  Abillity to promote project labels to group labels
  Update and pin the `jwt` gem to ~> 1.5.6
  refactor merge request build service
  Update index.md
  Clarify that Auto Deploy requires a public project.
  cop for gem fetched from a git source
  Add CHANGELOG entry
  Remove new branch button for confidential issues
  Remove flash warning from login page
  add complete changelog
  Add project ID index to `project_authorizations` table to optimize queries
  Fix disable storing of sensitive information when importing a new repo
  Fix notification when global=disabled, group=watch
  Ensure rake is called within the correct bundle context
  Fix 8.16.0 release date.
  Improve search within group logic
  Add changelog item about new attributes in group api
  Update group api doc with full_name and full_path attributes
  Add tests for nested groups in search service and search helper
  ...
2017-01-31 14:38:45 -06:00
Mike Greiling 69e4072f89 Merge branch 'master' into go-go-gadget-webpack
* master: (389 commits)
  Document "No gems fetched from git repositories" policy [ci skip]
  Typos
  Small gramatical tweaks
  Typos
  Added PHP & NPM doc
  Use `:empty_project` where possible in request specs
  Add caching of droplab ajax requests
  Use `:empty_project` where possible in model specs
  Revert 3f17f29a
  Remove unused js response from refs controller
  Add MR id to changelog entry
  fixed small mini pipeline graph line glitch
  Prevent form to be submitted twice
  Fix Error 500 when repositories contain annotated tags pointing to blobs
  Fix /explore sorting (trending)
  Simplify wording in "adding an image" docs
  Remove "official merge window" from CONTRIBUTING.md [ci skip]
  Update repository check documentation
  Fixed flexbox and wrap issues
  Update two_factor_authentication.md
  ...
2017-01-27 19:33:58 -06:00
Eric Eastwood 34a1e3dcdb Fix permalink discussion note being collapsed 2017-01-26 19:54:34 -06:00
Luke "Jared" Bennett fed94dceaf
remove ba-resize
refactor js-autosize code now that ba-resize is gone

Added specs
2017-01-20 20:42:49 +00:00
Mike Greiling ccada28f30 resolve all padded-blocks eslint violations 2017-01-18 17:16:41 -06:00
Mike Greiling fe964cc235 migrate all javascript asset bundles and require syntax 2017-01-10 12:30:38 -06:00
Mike Greiling 8e0e902b13 resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00
Luke "Jared" Bennett 7cefaea876
explicitly disable eslint inline 2016-11-15 16:30:34 +00:00
Annabel Dunstone Gray 002670ec73 Finish styling commits view 2016-10-28 09:00:30 -05:00
winniehell 02f94cf038 disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
Jared Deckard 7f6474b269 Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
zzjin 3a575d1479 Update toggler_behavior.js to toggle ajax loaded contents like `diffs` page. 2016-08-31 07:57:56 +00:00
Mike Greiling 9605154967 Automatically expand hidden discussions when accessed via a permalink hash (closes #19304) 2016-08-24 22:11:58 -05:00
Fatih Acet aaa9509d12 ES6ify all the things! 2016-07-24 23:45:11 +03:00
Jacob Schatz eebd7533ea Merge branch 'fix-bug-causing-comment-to-submit-twice' into 'master'
Fix bug causing comment form in issue to submit twice when CTRL+Enter is pressed twice



See merge request !3655
2016-04-13 15:04:09 +00:00
Arinde Eniola 050110c9c9 hide help block when user is creating a new project inside a group 2016-04-12 14:41:34 +01:00
Arinde Eniola de4d98fd12 fix bug causing comment form in issue to submit twice when CTRL+Enter is pressed twice 2016-04-11 15:19:11 +01:00
Phil Hughes 692773c5a0 ctrl+enter on mac correctly submits forms
Closes #4177
2016-03-04 10:11:15 +00:00
Robert Speicher 97c909bd01 Contextually teach the user about the quick submit hotkey
When a user tabs to the submit button (i.e., the "wrong" way), we
display a tooltip with the quick submit hotkey so they can learn the
"right" way.
2016-03-02 15:11:44 -05:00
Robert Speicher 76ed2afcfc Change `js-quick-submit` behavior to expect the class on the form
Now it will work on any field inside that form, and it's easier to scope
new behavior, which is what we're adding next!
2016-03-02 15:11:15 -05:00
Robert Speicher 933834c4a6 Allow manual resize of js-autosize textareas
First, the autosize library was being too controlling and removed the
`resize` property from any elements to which it was attached, removing
the drag handle.

Second, we detect when the user manually resizes an autosize textarea,
and then remove the autosize behavior from it and increase its
max-height.

This should allow for the best of both worlds.

Closes #12832
2016-02-01 17:00:03 -05:00