Commit Graph

201 Commits

Author SHA1 Message Date
Jose Ivan Vargas 4014bc321a Corrected alignment for the remember-me checkbox in the login view 2017-03-22 16:42:32 -06:00
tauriedavis ceeb43e92b Change label for name on sign up form 2017-03-09 15:36:07 -08:00
Mike Greiling 85e0bbc4f8 move u2f library to webpack 2017-03-07 02:59:12 -06:00
Douwe Maan ad640bc5f9 Use Namespace#full_path instead of #path where appropriate 2017-02-23 17:55:01 -06:00
Semyon Pupkov 0dfccd995a Add active_when helper
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/24036
2017-02-15 14:29:48 +05:00
Jarka Kadlecova 3d2954e457 Use reCaptcha when an issue identified as spam 2017-02-07 12:56:20 +01:00
Bryce Johnson fbd09871ca Remove turbolinks. 2017-02-02 14:03:12 -05:00
Robert Speicher b846b9df59 Fix ImplicitDiv Haml lint failure 2017-01-04 11:32:39 -05:00
Douwe Maan ce4258e991 Merge branch 'add_email_password_confirmation' into 'master'
Add email confirmation field to registration form

Closes #3053

See merge request !7432
2017-01-04 14:44:10 +00:00
Drew Blessing 33b41bc8a8 Add email and password confirmation fields to registration form
It's too easy to mistype an email or password when signing up.
The support team is receiving an increasing number of requests
because users mistype their email. We can eliminate this problem
by requiring users to confirm the email before registering. The
same issue can occur for the password field so we should add
this, too. We should note that password confirmation is part
of the default Devise forms. I don't know why/when GitLab
removed it.
2017-01-03 00:16:37 -06:00
Kushal Pandya fb3e365412 HAMLLint: Fix `SpaceInsideHashAttributes` offences 2016-12-31 11:58:36 +05:30
Kushal Pandya dd5ffd9ca6 HAMLLint: Fix `ImplicitDiv` offences 2016-12-31 11:43:08 +05:30
Kushal Pandya 7b1944f96c HAMLLint: Fix `ClassAttributeWithStaticValue` offences 2016-12-31 11:43:08 +05:30
Luke "Jared" Bennett b285abeccc
Improved the u2f flow
Added tests
2016-12-27 00:18:17 +00:00
Fatih Acet 1413c94a8e Merge branch '15081-wrong-login-tab-ldap-frontend' into 'master'
Fixed Wrong Tab Selected When Loggin Fails And Multiple Login Tabs Exists

## What does this MR do?
Fixes issue: 15081 Wrong Tab Selected When Loggin Fails And Multiple Login Tabs Exists
This is done by saving into a cookie when the active tab changes and by always selecting that tab when the page is loaded.
## Are there points in the code the reviewer needs to double check?
No
## Why was this MR needed?
In order to fix the issue: 15081
## Screenshots (if relevant)

## Does this MR meet the acceptance criteria?

- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?


Closes #15081

See merge request !7314
2016-12-09 09:17:41 +00:00
Annabel Dunstone Gray bdd1193f57 Remove confirmation.scss 2016-12-06 09:18:17 -06:00
Jacopo 8235f83015 Fixed Wrong Tab Selected When Loggin Fails And Multiple Login Tabs Exists
When ldap is enabled and use "Standard" authentication method, if authentication fails
the correct tab remain selected.
This is done by saving into localStorage when the active tab changes and by always selecting that tab when
the page is loaded.
2016-12-02 10:19:31 +01:00
Bryce Johnson 0bd5370911 Un-un-revert signin tab order fix. 2016-11-18 21:40:18 +01:00
Timothy Andrew 78b6d6624b Allow registering users where the username contains dots (.).
Javascript does not support the negative lookbehind assertion (?<!) used
in the Ruby regex (to disallow usernames ending in `.git` or `.atom`.

Getting the client side code to fully support this format is
non-trivial, since we'd either have to heavily complicate the
regex used, or modify the frontend code to support more complex
validation schemes (it currently uses HTML5 validations).

The pragmatic choice is to create a
`Gitlab::Regex::NAMESPACE_REGEX_STR_SIMPLE` regex to serve as a
Javascript-compatible version of `NAMESPACE_REGEX_STR`.

The client-side code will not display an error for usernames ending in
`.git` and `.atom`, but these will be caught by the server-side
validation.
2016-11-18 11:47:37 +05:30
Luc Didry 45c9d1e7bb Fix no "Register" tab if ldap auth is enabled (#24038)
This commit is dedicated to GuilhemB, thanks for supporting me on Tipeee
:-)
2016-11-10 17:24:42 +01:00
Bryce Johnson d939fbed09 Change show-gl-field-errors to gl-show-field-errors 2016-11-02 11:35:21 +01:00
Bryce Johnson 93bd3dd8a8 Upgrade gl_field_errors to support more use cases. 2016-11-01 16:48:37 +01:00
Jacob Schatz 132e3f5471 Merge branch 'register-tab' into 'master'
Only show register tab if signup enabled.

## What does this MR do?

Fixes a regression where the register tab is activated, even if sign-up enabled is not activated in application_settings.

## Screenshots (if relevant)

When signup is disabled: 

![Screen_Shot_2016-10-22_at_8.56.23_PM](/uploads/bd0fa5f27114779c0d290a8151c1c253/Screen_Shot_2016-10-22_at_8.56.23_PM.png)

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/23654

See merge request !7058
2016-10-25 02:47:27 +00:00
Bryce Johnson 413c012db8 Only show register tab if signup enabled. 2016-10-24 17:50:19 +02:00
Bernardo Anderson 85062dfd25 Merge branch 'master' into sign_in_forgot_password 2016-10-22 14:51:59 -05:00
Bernardo Anderson 3b7ca69e53 Fix sign in page Forgot your password link overlap 2016-10-22 14:20:13 -05:00
Bryce Johnson 57046eb0ab Ensure custom provider tab labels don't break layout.
(Also fix some issues for session views on small screens.)
2016-10-20 21:57:34 +02:00
Clement Ho 8815748feb Change input order on Sign In form for better tabbing.
This *unreverts* 8751491b, which was mistakenly
reverted in !6328. It also changes the implementation of the
original commit to work with the new login styling and
markup.

cc: @ClemMakesApps
2016-10-20 13:55:06 +02:00
Bryce Johnson 348236ed93 Fix aesthetic issues on CROWD login. 2016-10-18 12:46:37 +02:00
Bryce Johnson 357ff6700d Contain normal signin in loginbox. 2016-10-18 11:12:41 +02:00
Bryce Johnson 3bc25264a1 Fix superfluous margin on new_ldap submit. 2016-10-18 11:12:41 +02:00
Bryce Johnson b4f84ff728 Use correct verbiage for username in login form. 2016-10-18 11:12:41 +02:00
Bryce Johnson 8a62d0cec5 Fix href to server pane. 2016-10-18 11:12:41 +02:00
Bryce Johnson a185c32bef Fix tab refs in ldap tabs. 2016-10-18 11:12:41 +02:00
Bryce Johnson 4477d68bfb Split login box into different panes, for ldap enabled screens. 2016-10-18 11:12:41 +02:00
Bryce Johnson d3e64a951c Fix aesthetic issues on LDAP login. 2016-10-18 11:12:41 +02:00
Stan Hu fa25f61d47 Fix Hash syntax to work for both Ruby 2.1 and 2.3 2016-10-15 20:31:40 -07:00
Bryce Johnson 23fd1f1630 Use Ruby 1.9 syntax in tab_single def and usage. 2016-10-15 08:28:54 +02:00
Bryce Johnson c2766614dd Fix syntax error -- missing comma in _new_crowd. 2016-10-15 08:28:53 +02:00
Bryce Johnson 445711675c Fix nesting on sessions/new. 2016-10-15 08:28:53 +02:00
Bryce Johnson 673c23dd7e Unbreak all the tests relying on one login-box. 2016-10-15 08:28:52 +02:00
Bryce Johnson 80cbc9838e Fix omniauth box styling. 2016-10-15 08:28:52 +02:00
Bryce Johnson 2c7a1af66f Add submit button contain with custom margin. 2016-10-15 08:28:51 +02:00
Bryce Johnson bd0bf40763 Make style fixes, make all submit buttons full-width btn-block. 2016-10-15 08:28:49 +02:00
Bryce Johnson 74bfba7226 Include correct validation error with username invalid. 2016-10-15 08:27:24 +02:00
Bryce Johnson 00bfb645e1 Fix errors, get validation running for signup box and sign in. 2016-10-15 08:27:24 +02:00
Bryce Johnson 1dd826d4aa Make UX upgrades to SignIn/Register views.
- Tab between register and sign in forms
- Add individual input validation error messages
- Validate username
- Update many styles for all login-box forms
2016-10-15 08:27:21 +02:00
Clement Ho 8751491b8d Improve tabbing usability for sign in page 2016-10-13 13:58:31 -05:00
Nick Thomas 9920551536 Enable CacheMarkdownField for the remaining models
This commit alters views for the following models to use the markdown cache if
present:

* AbuseReport
* Appearance
* ApplicationSetting
* BroadcastMessage
* Group
* Issue
* Label
* MergeRequest
* Milestone
* Project

At the same time, calls to `escape_once` have been moved into the `single_line`
Banzai pipeline, so they can't be missed out by accident and the work is done
at save, rather than render, time.
2016-10-07 02:54:26 +01:00
Dmitry Smirnov 0d74154abc fix LDAP omniauth regression (Closes: #22357)
~~~~
ActionView::Template::Error (undefined method `user_omniauth_callback_path'
~~~~

Signed-off-by: Dmitry Smirnov <onlyjob@member.fsf.org>
2016-09-21 14:10:21 +10:00