Valery Sizov
387c4b2c21
Backport of multiple_assignees_feature [ci skip]
2017-05-04 17:11:53 +03:00
Alfredo Sumaran
b64a37c4ed
Allow to create new branch and empty WIP merge request from issue page
2017-05-04 08:09:21 +00:00
Luke "Jared" Bennett
9cee280d70
Merge branch 'update-droplab-to-webpack-version' into new-resolvable-discussion
2017-04-06 13:47:52 +01:00
Sean McGivern
b80653bb6a
Merge branch 'open-redirect-host-fix' into 'security'
...
Fix for three open redirect vulns using redirect_to url_for(params.merge)))
See merge request !2082
2017-04-05 21:06:58 -07:00
Douwe Maan
08bbb9fce6
Add option to start a new discussion on an MR
2017-04-05 17:44:14 +01:00
Sam Rose
97941d2cf5
Display flash message to unauthenticated user when creating new issue
2017-03-25 09:32:26 -04:00
Oswaldo Ferreira
86ef67eee5
Present ajax call errors when failing to update an Issue
2017-03-21 14:20:15 -03:00
DJ Mountney
4ea85da9fb
Merge remote-tracking branch 'dev/master'
2017-03-20 18:55:40 -07:00
DJ Mountney
7be39a894b
Merge branch 'render-json-leak' into 'security'
...
fix for render json include leaks
See merge request !2074
2017-03-20 18:54:17 -07:00
Sean McGivern
85759f2c79
Merge branch '20204-new-issue-button-redirects-you-to-create-a-new-issue-after-logging-in' into 'master'
...
Redirect to signin when New Issue for not logged in
Closes #20204
See merge request !9743
2017-03-20 18:51:44 +00:00
Sam Rose
aea78ded34
Redirect to signin when New Issue for not logged in
2017-03-20 10:43:54 -04:00
Bob Van Landuyt
ea70a0d674
Rename variable
...
merge_request_for_resolving_discussions ->
merge_request_to_resolve_discussions_of
2017-03-13 08:27:52 +01:00
Bob Van Landuyt
f8b5fef9f7
Separate flash messages for resolving one or multiple discussions
2017-03-13 08:27:52 +01:00
Bob Van Landuyt
6f9304e030
Add a flash messages when an issue resolving discussions is created
2017-03-13 08:27:51 +01:00
Bob Van Landuyt
f86928953d
Always require MR-iid for resolving discussions
...
And deduplicate the finding of MR's & discussions. Now the searching
is done in the service, istead of the controller & the API.
2017-03-13 08:27:51 +01:00
Bob Van Landuyt
0267b83898
Delegate a single discussion to a new issue
...
Delegate a discussion in a merge request into a new issue.
The discussion wil be marked as resolved and a system note will be
added linking to the newly created issue.
2017-03-13 08:27:51 +01:00
Sean McGivern
dfd15596a4
Merge branch 'issue_24815' into 'master'
...
fix ERR_CONTENT_LENGTH_MISMATCH on task checkboxes
See merge request !8567
2017-02-27 14:14:20 +00:00
Felipe Artur
0d000d351c
Fix issuable stale object error handler for js when updating tasklists
2017-02-24 15:13:42 -03:00
Douwe Maan
ad640bc5f9
Use Namespace#full_path instead of #path where appropriate
2017-02-23 17:55:01 -06:00
Oswaldo Ferreira
2ace39f242
Spam check and reCAPTCHA improvements
2017-02-21 13:32:49 -03:00
Felipe Artur
0b14b654b6
Gather issuable metadata to avoid n+ queries on index view
2017-02-09 17:40:37 -02:00
Jarka Kadlecova
3d2954e457
Use reCaptcha when an issue identified as spam
2017-02-07 12:56:20 +01:00
Robert Speicher
4642ca6686
Use `empty_project` where possible in controller specs
2017-01-25 17:14:38 -05:00
Ruben Davila
17196a2ff3
Backport backend work for time tracking.
2017-01-15 11:10:04 -05:00
Tiago Botelho
d7a2e92ca0
applies url_for so that we dont lose filters when redirecting
2016-12-23 15:09:34 +00:00
Tiago Botelho
805bbe8893
adds specs for respective behaviour
2016-12-21 23:53:24 +00:00
Bob Van Landuyt
1123057ab7
Feature: delegate all open discussions to Issue
...
When a merge request can only be merged when all discussions are
resolved. This feature allows to easily delegate those discussions to a
new issue, while marking them as resolved in the merge request.
The user is presented with a new issue, prepared with mentions of all
unresolved discussions, including the first unresolved note of the
discussion, time and link to the note.
When the issue is created, the discussions in the merge request will get
a system note directing the user to the newly created issue.
2016-12-05 20:55:45 +01:00
Douglas Barbosa Alexandre
d86c666662
Refresh todos count cache when an Issue/MR is deleted
2016-09-08 15:50:07 -03:00
Stan Hu
ace38e8397
Fix external issue tracker "Issues" link leading to 404s
...
a70431f874 modified the behavior to link to the external issue tracker
issues URL instead of the project path URL. This restores the
previous behavior.
Closes #21252 , #21402
2016-08-25 14:53:17 -07:00
Patricio Cano
5994c11910
Further refactor and syntax fixes.
2016-08-15 17:20:57 -05:00
Patricio Cano
43e756d4ea
Refactored AkismetHelper into AkismetService and cleaned up `Spammable`
...
- Refactored SpamCheckService into SpamService
2016-08-15 13:18:15 -05:00
Patricio Cano
96399a81cb
Allow `Issue` to be submitted as spam
...
- Added controller actions as reusable concerns
- Added controller tests
2016-08-15 13:18:15 -05:00
Patricio Cano
64ab2b3d9f
Refactored spam related code even further
...
- Removed unnecessary column from `SpamLog`
- Moved creation of SpamLogs out of its own service and into SpamCheckService
- Simplified code in SpamCheckService.
- Moved move spam related code into Spammable concern
2016-08-15 13:18:15 -05:00
Patricio Cano
95419679f2
Lay the ground works to submit information to Akismet
...
- New concern `AkismetSubmittable` to allow issues and other `Spammable` models to be submitted to Akismet.
- New model `UserAgentDetail` to store information needed for Akismet.
- Services needed for their creation and tests.
2016-08-15 13:17:58 -05:00
tiagonbotelho
519275c110
fixes part1 of files to start using active tense
2016-08-09 15:06:23 +01:00
Robert Speicher
901d4d2ca5
Remove `url_for_new_issue` helper
...
Now we link to the standard `IssuesController#new` action, and let it
redirect if we're using an external tracker.
2016-08-01 18:23:12 -07:00
Robert Speicher
a70431f874
Redirect to external issue tracker from `/issues`
...
Prior, in order to display the correct link to "Issues" in the project
navigation, we were performing a check against the project to see if it
used an external issue tracker, and if so, we used that URL. This was
inefficient.
Now, we simply _always_ link to `namespace_project_issues_path`, and
then in the controller we redirect to the external tracker if it's
present.
This also removes the need for the url_for_issue helper. Bonus! 🎉
2016-08-01 16:59:44 -07:00
Patricio Cano
9c34fafb8b
Submit new issues created via the WebUI by non project members to Akismet for spam check.
2016-07-26 15:17:41 -05:00
Z.J. van de Weg
abca19da8b
Use HTTP matchers if possible
2016-06-27 20:10:42 +02:00
Douglas Barbosa Alexandre
b56c456750
Project members with guest role can't access confidential issues
2016-06-13 19:32:00 -03:00
Z.J. van de Weg
91a7b9333b
Incorportate feedback
2016-06-01 12:10:08 +02:00
ZJ van de Weg
cbd7801b3d
Merge branch 'master' into awardables
2016-05-30 18:54:08 +02:00
Robert Speicher
75739e54be
Enable RSpec/NotToNot cop and auto-correct offenses
...
Also removes the note from the development/testing.md guide
2016-05-24 15:40:29 -04:00
Zeger-Jan van de Weg
7a4e7ad04e
Fix tests and wrong choices during merge
2016-05-12 09:23:21 +02:00
Zeger-Jan van de Weg
4558b5b9fe
Incorporate feedback
2016-05-11 22:43:58 +02:00
Zeger-Jan van de Weg
7e6dcf9cd0
Merge branch 'master' into awardables
2016-05-11 08:47:04 +02:00
Zeger-Jan van de Weg
dccf8a9fc8
Add tests on Awardables and Award Emoji
2016-05-10 12:03:13 +02:00
Grzegorz Bizon
c9577711ce
Handle issue move access instead of raising error
...
Closes #15533
2016-04-30 21:28:40 +02:00
Zeger-Jan van de Weg
6e5461c6ee
Merge branch 'master' into 2489-soft-delete-issues
2016-03-21 19:32:37 +01:00
Zeger-Jan van de Weg
d28a587e82
Fix typos and denting
2016-03-21 19:30:45 +01:00