Commit Graph

143 Commits

Author SHA1 Message Date
Dmitriy Zaporozhets aaf37ead92 Merge branch '19364-webhook-edit' into 'master'
Implement ability to update hooks

Closes #19364

See merge request !10816
2017-05-02 11:44:58 +00:00
Ahmad Sherif 13de8aeec8 Add specs for Gitlab::RequestProfiler
Closes #31513
2017-05-01 17:32:45 +02:00
Alexander Randa c504b88f07 Implement ability to update hooks 2017-04-28 11:49:57 +00:00
Dmitriy Zaporozhets 1c408df2e1
Increase code coverage for admin/cohorts page
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2017-04-27 16:51:36 +03:00
Jacopo ff76adb547 Unnecessary "include WaitForAjax" and "include ApiHelpers"
Removed all the unnecessary include of `WaitForAjax` and `ApiHelpers` in the specs.
Removed unnecessary usage of `api:true`
2017-04-21 22:32:02 +02:00
Dimitrie Hoekstra 3b2adb5bd7 Added profile name to user dropdown 2017-04-19 16:43:57 +00:00
Robert Speicher 5e1a802b15 Merge branch 'remove_is_admin' into 'master'
Remove the `User#is_admin?` method

Closes #30584

See merge request !10520
2017-04-09 17:37:26 +00:00
Douglas Lovell d0beb755f9 Add a name field to the group edit form
Enables user specification of group name vs. name inferred from group path.

Cause new group form to copy name from path

Adds some new page-specific javascript that copies entry from the
group path field to the group name field when the group name field
is initially empty.

Remove duplicate group name entry field on group edit form

This corrects the duplicated name entry field and tests that the
JavaScript does not update the group name field if the user
edits the group path.  (Editing the group path is not recommended
in any case, but it is possible.)

Address eslint errors in group.js

Enable group name copy with dispatch and explore group creation

The dispatch and explore group creation forms require the group.js
asset, and their tests now require testing against poltergeist

Update workflow new group instruction

Update the gitlab basics group creation document

Add a change log entry

Remove unused variable for eslint
2017-04-09 08:43:49 -05:00
blackst0ne 11aff97d88 Remove the User#is_admin? method 2017-04-09 13:20:57 +11:00
Jose Ivan Vargas 7592137f21 Fix rspec and spinach tests 2017-04-06 14:58:57 -05:00
Jose Ivan Vargas Lopez c2a987fb9c Admin section capitalization fix 2017-04-06 14:58:57 -05:00
Rémy Coutable 44a5c6b2a3
Fix a transient spec failure in "Admin Health Check" feature spec
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-04-04 20:31:38 +02:00
Rémy Coutable 169dc4cec1 Fix brittle specs
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-04-03 18:54:48 +02:00
Rémy Coutable 4e3516788f Don't use FFaker in factories, use sequences instead
FFaker can generate data that randomly break our test suite. This
simplifies our factories and use sequences which are more predictive.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-04-03 18:54:48 +02:00
Eric Eastwood f7d69a74a8 Fix up emoji tests that should have failed :/
Some discussion,
https://gitlab.slack.com/archives/C0GQHHPGW/p1490398531185144
 -> MR to fix failing emoji test:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10230
2017-03-24 21:19:34 -05:00
Z.J. van de Weg 091c260812 Improve readability and add test 2017-03-23 13:35:20 +01:00
Robert Speicher f592cae129 Merge branch 'sh-fix-admin-application-settings' into 'master'
Fix Error 500 when application settings are saved

Closes #29674 and #29115

See merge request !10070
2017-03-21 07:21:01 +00:00
Toon Claes dd3d62b626 Make feature spec more robust
Ensure the correct "Public" radio is selected by choosing it on ID.
2017-03-20 22:05:02 +01:00
Stan Hu 681af5bc4f Fix Error 500 when application settings are saved
Due to a Rails bug, fetching the application settings from Redis
may prevent the attribute methods from being loaded for the `ApplicationSetting`
model. More details here: https://github.com/rails/rails/issues/27348

There was also a secondary problem introduced by overriding these
association methods which caused all default visibility levels to be
set to `nil`. Before, the previous implementation allowed the string
"20" to be saved as an integer, while now a table lookup happens
before that. We fix this by enforcing the integer value in the
controller and default to PRIVATE.

Closes #29674
2017-03-18 15:39:48 -07:00
Kamil Trzciński 12dd5ac221 All CI offline migrations 2017-03-17 23:06:11 +00:00
Tiago Botelho 005749a616 apply codestyle and implementation changes to the respective feature code 2017-03-06 19:18:26 +00:00
Tiago Botelho 2b474dc2b2 refactors finder and correlated code 2017-03-01 13:11:11 +00:00
Tiago Botelho 9f2e4742e3 applies relevant changes to the code and code structure 2017-02-28 22:15:40 +00:00
Tiago Botelho f0ea7130f7 refactors documentation and personal access tokens form to not allow admins to generate non impersionation tokens 2017-02-28 22:15:40 +00:00
Simon Vocella c2b1cdef7e add admin panel for personal access tokens 2017-02-28 22:15:39 +00:00
Jan Christophersen 150c363752 Add the username of the current user to the HTTP(S) clone URL 2017-02-24 16:35:34 +01:00
Clement Ho 59010d8f82 Fix grammer issue in admin/runners 2017-02-17 14:36:49 -06:00
Eric Eastwood ae69e8764c Restore pagination to admin abuse reports 2017-02-16 17:02:58 -06:00
Felipe Artur d1ecbd6ce8 Fix admin_labels_spec.rb transient failure 2017-02-10 11:44:00 -02:00
Jose Ivan Vargas 426680def4 Backport of the frontend view, including tests 2017-02-06 16:17:46 -06:00
Filipa Lacerda c5f5ce8807 Fix broken tests
Rename Build to Job

Replace "Builds" by "Jobs" and fix broken specs

Replace "Builds" by "Jobs"

Fix broken spinach test

Fix broken test

Remove `˙` at the beginning of the file

Fix broken spinach test

Fix broken tests

Changes after review
2017-02-03 09:43:04 +00:00
Grzegorz Bizon 632c2939bb Revert "Merge branch 'revert-9cac0317' into 'master' "
This reverts commit c20934869f, reversing
changes made to 4b7ec44b91.
2017-01-23 16:35:24 +01:00
Semyon Pupkov a92c0f9c11 Use archived trait for project in specs instead model column 2017-01-22 19:19:45 +05:00
Grzegorz Bizon baeaa97ef4 Revert "Merge branch 'dont-persist-application-settings-in-test-env' into 'master'"
This reverts merge request !8573
2017-01-21 22:55:35 +00:00
Robert Speicher 9cac031769 Merge branch 'dont-persist-application-settings-in-test-env' into 'master'
Don't persist application settings in test env

See merge request !8573
2017-01-20 15:42:54 +00:00
Rémy Coutable 3608a1e875 Merge branch 'move-admin-groups-spinach-test-to-rspec' into 'master'
Move admin groups spinach tests to rspec

See merge request !8313
2017-01-15 23:07:16 +00:00
Rémy Coutable f6cc29ed83 Don't persist ApplicationSetting in test env
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-01-15 01:07:29 -05:00
Rémy Coutable 2c58d5101c Merge branch 'move-admin-users-spinach-tests-to-rspec' into 'master'
Move admin users spinach tests to rspec

See merge request !8395
2017-01-13 04:50:48 +00:00
Semyon Pupkov 4141e30505 Move admin deploy keys spinach to rspec 2017-01-03 13:53:42 +05:00
Semyon Pupkov 74c817c7cb Tiny refactoring example in admin users feature spec 2017-01-02 16:20:22 +05:00
Semyon Pupkov 1591c90f7b Move admin users spinach tests to rspec
https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
2017-01-02 16:07:11 +05:00
James Gregory b21024684b Merged the 'groups' and 'projects' tabs when viewing user profiles 2016-12-29 22:42:16 +00:00
Valery Sizov 684536321c Fix: Admin group show page does not work 2016-12-28 15:34:12 +02:00
Semyon Pupkov cec230bdf5 Move admin groups spinach tests to rspec
https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
2016-12-27 00:36:33 +05:00
Rémy Coutable ad1a1d976c Merge branch 'move-admin-projects-spinach-tests-to-rspec' into 'master'
Move admin projects spinach tests to RSpec

Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/23036

See merge request !8174
2016-12-20 12:20:50 +00:00
Grzegorz Bizon 52278412c7 Merge branch 'zj-kamil-slack-slash-commands' into 'master'
Slack slash commands

## What does this MR do?

Implement Slack Slash Commands by utilizing generalized Mattermost presenter to fulfill Slack requirements.

## Why was this MR needed?

We want to expose Slack Slash Commands as a first-class service.

## What are the relevant issue numbers?

Supersedes !8007  
Closes #22182

See merge request !8126
2016-12-20 09:41:37 +00:00
Rémy Coutable 4298209a7a Merge branch 'move-admin-appearance-feature-to-rspec' into 'master'
Move Admin Appearance spinach feature to RSpec

Part of #23036

See merge request !8063
2016-12-19 20:44:58 +00:00
jurre bf6b107852 Move admin broadcast messages spinach feature to rspec 2016-12-19 17:43:24 +01:00
jurre a0c48ec62b Move Admin Appearance spinach feature to rspec 2016-12-19 17:41:54 +01:00
Rémy Coutable 60f61096e1 Merge branch 'move-admin-label-spinach-test-to-rspec' into 'master'
Move admin labels spinach test to RSpec

Part of #23036

See merge request !8166
2016-12-19 15:31:28 +00:00