Commit Graph

47 Commits

Author SHA1 Message Date
Douwe Maan a6536a84e7 Fix some specs 2017-04-27 12:23:26 -05:00
Zeger-Jan van de Weg df85a7c004 Submodule Dockerfile templates 2017-04-26 15:57:44 +00:00
Clement Ho 2bde344217 Merge branch '22826-ui-inconsistency-different-files-views-find-file-button-missing' into 'master'
[#22826] Ensure find_file_link and download button is part of file tree header

Closes #22826

See merge request !9847
2017-04-26 13:13:02 +00:00
TM Lee d2765b453f [#22826] Add newline before expect in accordance to four phase thoughtbot style 2017-04-25 08:45:30 +08:00
TM Lee 7940a5d49c [#22826] Ensure find_file_link and download button is part of file tree header
- Move the find_file_link and download partial into the project tree_header partial
- Added Changelog
2017-04-23 18:44:42 +08:00
Jacopo ff76adb547 Unnecessary "include WaitForAjax" and "include ApiHelpers"
Removed all the unnecessary include of `WaitForAjax` and `ApiHelpers` in the specs.
Removed unnecessary usage of `api:true`
2017-04-21 22:32:02 +02:00
Douwe Maan d170133bde Refactor changing files in web UI 2017-04-20 00:37:44 +00:00
Jose Ivan Vargas Lopez c380d7669c Fixed button capitalisation for Projects in views 2017-04-06 14:58:57 -05:00
Jose Ivan Vargas 7592137f21 Fix rspec and spinach tests 2017-04-06 14:58:57 -05:00
Jose Ivan Vargas eb2d6a6ed5 Fixed rspec tests 2017-04-06 14:58:57 -05:00
Bryce Johnson f564cbb21a Make file templates easy to use and discover 2017-04-03 17:54:40 +00:00
Christopher Bartz 7849683766 Do not show LFS object when LFS is disabled
Do not display a 404, when a user tries to retrieve the raw content of
an LFS file (pointer) if the config option "lfs_enabled" is set to
false. Instead, display the LFS pointer file directly.
2017-03-13 18:15:19 +01:00
Douwe Maan faa2e2df8f Rename commit_file, commit_dir and remove_file and update specs 2017-02-24 09:55:01 -06:00
Connor Shea fcb15c5677 Update Licensee from 8.0.0 to 8.7.0.
Changelog: https://github.com/benbalter/licensee/releases
2017-02-22 14:00:56 -07:00
Filipa Lacerda b57027f2a5 Use a new class to keep old behavior 2017-02-08 20:52:08 -06:00
Lin Jen-Shin a639454032 Fix renaming 2017-01-07 00:31:11 +08:00
Lin Jen-Shin 104bac3d21 Merge branch 'master' into fix-git-hooks-when-creating-file
* master: (1031 commits)
  Add changelog entry for renaming API param [ci skip]
  Add missing milestone parameter
  Refactor issues filter in API
  Fix project hooks params
  Gitlab::LDAP::Person uses LDAP attributes configuration
  Don't delete files from spec/fixtures
  Copy, don't move uploaded avatar files
  Minor improvements to changelog docs
  Rename logo, apply for Slack too
  Fix Gemfile.lock for the octokit update
  Fix cross-project references copy to include the project reference
  Add logo in public files
  Use stable icon for Mattermost integration
  rewrite the item.respond_to?(:x?) && item.x? to item.try(:x?)
  API: extern_uid is a string
  Increases pipeline graph drowdown width in order to prevent strange position on chrome on ubuntu
  Removed bottom padding from merge manually from CLI because of repositioning award emoji's
  Make haml_lint happy
  Improve spec
  Add feature tests for Cycle Analytics
  ...
2017-01-04 22:25:55 +08:00
Kamil Trzcinski 14d47884df
Merge remote-tracking branch 'origin/master' into dockerfile-templates 2016-12-18 23:39:51 +01:00
winniehell c16b24af04 Add failing test for #20190 2016-12-13 09:13:06 +01:00
Lin Jen-Shin 07b9b80a88 Fix tests to use the new API 2016-12-08 19:11:52 +08:00
Luke "Jared" Bennett dcd20236ec
Refactored JS
Added spec
2016-11-08 13:54:58 +00:00
Lisanne Fellinger e6e4147880 Rewritten spinach git_blame tests to rspec feature tests
Fixing rubocop violations

Relocated git_blame spec and fixed styling issue

Rewritten spinach git_blame tests to rspec feature tests

Fixing rubocop violations

Relocated git_blame spec and fixed styling issue

Rewritten spinach git_blame tests to rspec feature tests

Fixing rubocop violations

Rewritten spinach git_blame tests to rspec feature tests

Fixing rubocop violations

Rewritten spinach git_blame tests to rspec feature tests

Fixing rubocop violations

Relocated git_blame spec and fixed styling issue
2016-11-07 15:17:52 +01:00
Phil Hughes f91df171c5 Fixed find file keyboard navigation
Closes #23423
2016-10-17 16:55:34 +01:00
Luke Bennett 70f7d2446a Review changes
Updated tests
2016-10-01 00:01:47 +03:00
Luke Bennett 61afa65d4e Added soft wrap logic and button to editor
Added tests

Added awesomeeeeee icons
2016-10-01 00:01:47 +03:00
Jacob Schatz d754b2ce76 Revert "Merge branch '18297-i-would-like-text-to-wrap-when-in-edit-mode-on-web-app' into 'master'"
This reverts merge request !6188
2016-09-29 00:56:30 +00:00
Luke Bennett ee02856d59 Added soft wrap logic and button to editor
Added tests

Added awesomeeeeee icons
2016-09-28 19:11:11 +03:00
Lin Jen-Shin 31e592647a Fix download artifacts button link:
Rails ignored unused arguments and ref_name_and_path is the last
path argument, therefore we need to concatenate that parts ourselves.

Otherwise, 'download' won't be shown at all.
2016-09-19 13:12:45 +08:00
Lin Jen-Shin f673f1e3bd Merge remote-tracking branch 'upstream/master' into artifacts-from-ref-and-build-name
* upstream/master: (109 commits)
  Update CHANGELOG for 8.10.6, 8.9.7, and 8.8.8
  Updated Akismet documentation
  Add hover state to todos (!5361)
  Load issues and merge requests templates from repository
  Backport EE assertions in protected branch related specs.
  Revert "Merge branch '19957-write-tests-for-adding-comments-for-different-line-types-in-diff' into 'master'"
  Fix a missed `before_action` for `AutocompleteController`.
  Backport `AutocompleteController#load_project` from EE!581.
  Fix API::BranchesSpec.
  Fix failing tests relating to backporting ee!581.
  Revert unrelevant changes
  Fix the protected branches factory.
  Improve EE compatibility with protected branch access levels.
  Move the "update" portion of the protected branch view into a partial.
  Don't select an access level if already selected.
  Backport changes from gitlab-org/gitlab-ee!581 to CE.
  Further refactor and syntax fixes.
  Upgrade httpclient gem from 2.7.0.1 to 2.8.2.
  Make rubocop happy
  Make rubocop happy
  ...
2016-08-17 13:40:18 +08:00
Jacob Schatz 86a8409eaf Merge branch 'file-content-highlight-line' into 'master'
Highlight empty lines

## What does this MR do?

Rather than just highlight the text, file line highlighting now highlights the full line including empty lines

## What are the relevant issue numbers?

Closes #19484 

## Screenshots (if relevant)

![Screen_Shot_2016-07-05_at_13.52.31](/uploads/d3bddc918d731681465381e96c0aa2b0/Screen_Shot_2016-07-05_at_13.52.31.png)

See merge request !5092
2016-08-16 20:36:31 +00:00
Douwe Maan a669bdb8e6 Merge branch 'frank-west-iii/gitlab-ce-fwiii-5857-web-editor-overwrites-commits' 2016-08-15 16:54:49 -05:00
Lin Jen-Shin 567ef6c175 Merge remote-tracking branch 'upstream/master' into artifacts-from-ref-and-build-name
* upstream/master: (123 commits)
  Limit the size of SVGs when viewing them as blobs
  Add a spec for ProjectsFinder project_ids_relation option
  Fix ProjectsFinder spec
  Pass project IDs relation to ProjectsFinder instead of using a block
  Speed up todos queries by limiting the projects set we join with
  Used phantomjs variable
  Ability to specify branches for pivotal tracker integration
  Fix a memory leak caused by Banzai::Filter::SanitizationFilter
  Update phantomjs link
  Remove sleeping and replace escaped text.
  Filters test fix
  Fixed filtering tests
  Removed screenshot command 💩
  Updated failing tests
  Used mirrored version on GitLab
  Updated tests
  Fix `U2fSpec` for PhantomJS versions > 2.
  Fix file downloading
  Install latest stable phantomjs
  Use new PhantomJS version
  ...
2016-08-16 00:14:26 +08:00
Frank West ade0c2c892 Prevents accidental overwrites of commits from UI
Currently when a user performs an update of a file through the UI  and there
has already been a change committed to the file the previous commits will be
overwritten without a check to see if the file has been changed.

This commit uses the last commit sha at the time the user starts editing the
file and compares it with the current sha of the file being edited to ensure
they are the same before committing the file. If the shas do not match we
throw an exception preventing the commit from the commit from occurring.

Fixes #5857
2016-08-15 02:34:55 +00:00
Phil Hughes f668da11cb Updated tests 2016-08-13 00:57:40 -05:00
Lin Jen-Shin cc3dbf83f4 Empty lines around blocks 2016-08-10 18:57:51 +08:00
Lin Jen-Shin 6234b32785 Merge remote-tracking branch 'upstream/master' into artifacts-from-ref-and-build-name
* upstream/master: (516 commits)
  Rename `run` task helper method to prevent conflict with StateMachine
  Add a method in Project to return a cached value of total count of projects
  Add Changelog entry for Grape upgrade [ci skip]
  Fix Grape tests.
  Retain old behavior
  Update Grape from 0.13.0 to 0.15.0.
  adds second batch of tests changed to active tense
  fixes part1 of files to start using active tense
  Clarify the features for generating default label sets
  Update tree view to sort folders with submodules
  Memoize CI config node validator to prevent leaks
  fix MR source project assignment
  remove offending empty line
  Rails prefers require_dependency so that it won't require twice:
  use Unix line endings for API documentation
  use long options for curl examples in API documentation (!5703)
  Prefixes removed branches name with PR number when importing PR from GH
  Update CHANGELOG
  Remove SHA suffix for removed branches name when importing PR from GH
  add linting script for documentation
  ...
2016-08-10 17:48:46 +08:00
Adam Buckland 8abc757539 Update tree view to sort folders with submodules
Currently trees are sorted in the fashion:
- folders
- files
- submodules
with each section sorted alphabetically

This changes to this system:
- folders and submodules (sorted together)
- files
2016-08-09 14:08:47 +01:00
Lin Jen-Shin 80c22e4c09 Add four features tests for download buttons in different places 2016-07-25 20:52:18 +08:00
Phil Hughes 26055b16b5 Highlight empty lines
Closes #19484
2016-07-20 08:42:59 +01:00
Rémy Coutable bb3801268b
Fix specs
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-07-06 17:52:59 +02:00
Alfredo Sumaran 73fdc9b6d3 Update tests to check if label is set after picking a template 2016-06-23 12:48:59 -05:00
Alfredo Sumaran a18df1d15a Add feature test for gitab CI dropdown 2016-06-20 14:48:28 -05:00
Alfredo Sumaran e8a467e094 Implements TemplateDropdown class to create custom template dropdowns
Also License dropdown has been ported to use our GL dropdown instead of Select2.
Fixes tests to make it work with current implementation
2016-06-16 00:28:45 -05:00
Connor Shea 2bf818c4d0
Fix some specs which would have broken in 2017 to not break anymore by using a dynamic year value. 2016-05-22 19:50:49 -06:00
Alfredo Sumaran 1f5fcb638d Dropdown implementation 2016-05-20 15:58:36 -05:00
Rémy Coutable b2370fefad Fix specs
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-04-18 14:47:50 +02:00
Rémy Coutable 13804aba86 Continue implementation of the license template selector and /licenses API endpoint
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-04-18 14:47:50 +02:00