Commit Graph

25 Commits

Author SHA1 Message Date
gfyoung 93a44e135b Add some frozen string to spec/**/*.rb
Adds frozen string to the following:

* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb

xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
2019-04-15 10:17:05 +00:00
Imre Farkas 9bc5ed14fe Move Contribution Analytics related spec in spec/features/groups/group_page_with_external_authorization_service_spec to EE 2019-04-09 15:38:58 +00:00
Andreas Brandl 46b1b9c1d6 Revert "Merge branch 'if-57131-external_auth_to_ce' into 'master'"
This reverts merge request !26823
2019-04-05 13:02:56 +00:00
Imre Farkas d9d7237d2e Move Contribution Analytics related spec in spec/features/groups/group_page_with_external_authorization_service_spec to EE 2019-04-05 11:45:47 +00:00
Rémy Coutable 3a2abc1d50
Enable the Layout/ExtraSpacing cop
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-01-24 13:05:45 +01:00
Mario de la Ossa 54994762ff
Backport of 54385-board-policy 2019-01-18 12:43:46 -06:00
blackst0ne b44a2c801a Update specs to rails5 format
Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`
2018-12-19 10:04:31 +11:00
Jasper Maes 56296f1eda Remove rails4 specific code 2018-12-16 10:48:41 +01:00
Brett Walker 2674830e4d Extract code into IssueBoardEntity 2018-12-04 08:44:21 -06:00
Thong Kuah 03dba01273 Revert "Extract code into IssueBoardEntity"
This reverts commit 8c126525fa.
2018-11-09 13:19:48 +13:00
Brett Walker 8c126525fa Extract code into IssueBoardEntity 2018-11-06 10:33:55 -06:00
Heinrich Lee Yu 2ba71571de Simplify query and add tests for authorization change 2018-10-26 10:27:25 +08:00
Chantal Rollison c871faa3e4 Add preload in issues controller 2018-10-18 18:43:50 -07:00
Felipe Artur 5815c5b48a [Backport] View summed weights of issues in board column 2018-07-30 13:44:41 +00:00
Mark Chao a63bce1a4b Resolve "Rename the `Master` role to `Maintainer`" Backend 2018-07-11 14:36:08 +00:00
Rémy Coutable 1c28b624d6 Merge branch 'jprovazn-rails5-boards' into 'master'
[Rails5] Fix conversion of integer into string in board spec

Closes #47653

See merge request gitlab-org/gitlab-ce!19616
2018-06-11 15:55:29 +00:00
Jan Provaznik 7fcfe7ccab Fix conversion of integer into string in board spec
In rails 5 controller specs, integers are converted to strings unless
conte-type is set with `as: :json`:
https://github.com/rails/rails/issues/26069
2018-06-09 22:58:28 +02:00
Robert Speicher 6d165c740c Make all uses of `fixture_file_upload` use relative paths 2018-06-07 09:54:41 -05:00
Rémy Coutable 3486286702
Reduce CE/EE diff in spec/controllers/boards/issues_controller_spec.rb
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-05-24 19:29:28 +02:00
Bob Van Landuyt 148816cd67 Port `read_cross_project` ability from EE 2018-02-22 17:11:36 +01:00
blackst0ne 27c95364b5 Replace '.team << [user, role]' with 'add_role(user)' in specs 2017-12-22 19:18:28 +11:00
Jacopo 2f40dac352 Refactor `have_http_status` into `have_gitlab_http_status` in the specs 2017-10-20 10:13:18 +02:00
micael.bergeron b376e5c80e fix another N+1 query for label priorities
added a QueryRecorder for IssuesController#index.json
2017-09-12 15:49:01 -04:00
Felipe Artur 02fed9a905 Backport specs 2017-08-31 15:18:35 -03:00
Felipe Artur 8077b728bc Continue BE backport 2017-08-31 14:48:57 -03:00