30b4ce940d
Remove Git circuit breaker
...
Was introduced in the time that GitLab still used NFS, which is not
required anymore in most cases. By removing this, the API it calls will
return empty responses. This interface has to be removed in the next
major release, expected to be 12.0.
2018-10-10 09:08:18 +02:00
9f9cac67ab
Fix CE to EE merge (backport)
2018-10-05 17:39:42 +02:00
84c4e920cd
Merge branch 'master' into 'feature/gb/pipeline-only-except-with-modified-paths'
...
# Conflicts:
# app/models/ci/pipeline.rb
2018-10-04 16:52:48 +00:00
a5cfacc281
Merge branch 'remove-rugged' into 'master'
...
Remove Gitlab::Git::Repository#rugged
See merge request gitlab-org/gitlab-ce!22039
2018-10-03 09:06:32 +00:00
a99bf447a2
Remove Gitlab::Git::Repository#rugged and Gollum code
...
Cleanup code, and refactor tests that still use Rugged. After this, there should
be no Rugged code that access the instance's repositories on non-test
environments. There is still some rugged code for other tasks like the
repository import task, but since it doesn't access any repository storage path
it can stay.
2018-10-02 16:34:28 -03:00
57dc233325
Merge branch 'osw-configurable-single-diff-file-limit' into 'master'
...
Make single diff patch limit configurable
Closes #48027
See merge request gitlab-org/gitlab-ce!21886
2018-10-02 13:53:32 +00:00
1c4187e38e
Treat nil git push revisons as a blank Git SHA value
2018-10-02 13:01:55 +02:00
4fbca2a346
Make single diff patch limit configurable
...
- Creates a new column to hold the single patch limit value on
application_settings
- Allows updating this value through the application_settings API
- Calculates single diff patch collapsing limit based on
diff_max_patch_bytes column
- Updates diff limit documentation
- Adds documentation (with warning) as of how one can update this limit
2018-10-01 11:58:21 -03:00
a583f137dd
Removes N+1 gitaly rpc call to fetch the last commit for path
...
Implements list_last_commits_for_tree to communicate with the
ListLastCommitsForTree Gitaly RPC
Bumps the Gitaly server version
Bumps the Gitaly-Proto gem version
2018-10-01 13:29:47 +01:00
419d8cc7a2
Calculate modified paths of a git push operation
2018-09-28 15:13:04 +02:00
4abba28944
Add specs for extracted git push class
2018-09-28 14:46:22 +02:00
76d9e29a65
Extract git push from merge request refresh service
2018-09-28 12:20:51 +02:00
3c2d6b4870
Add a class that represents a git push operation
2018-09-28 11:09:55 +02:00
a54a5d9f39
Use `Gitlab::SafeRequestStore` in more places
...
Even if it doesn’t save lines of code, since people will tend to use
code they’ve seen. And `SafeRequestStore` is safer since you
don’t have to remember to check `RequestStore.active?`.
2018-09-24 12:11:27 -07:00
f107bc69e3
Simplify by using Gitlab::SafeRequestStore
...
These are clear wins.
2018-09-24 12:11:26 -07:00
5dce096cf8
Use standalone diff stats RPC on every comparison view
2018-09-19 12:26:28 +00:00
a2a00a5e6d
Merge branch '51564-fix-commit-email-usage' into 'master'
...
Respect the user commit email in more places
Closes #51564
See merge request gitlab-org/gitlab-ce!21773
2018-09-18 12:07:52 +00:00
bff85a4b1c
Merge branch 'osw-gitaly-diff-stats-client' into 'master'
...
Add Gitaly diff stats RPC client
See merge request gitlab-org/gitlab-ce!21732
2018-09-17 16:29:42 +00:00
c9d6c02f15
Add Gitaly diff stats RPC client
...
This adds a basic interface to fetch diff statistics given two SHAs.
It's a requirement for #49399 #20282 and #19232 .
2018-09-17 12:27:01 -03:00
f54cada7b7
Remove Gitlab::Git::Repository#user_to_committer
2018-09-17 14:44:24 +01:00
fc0194b589
Resolve "Add functionality to change what email address online actions commit using"
2018-09-14 09:52:09 +00:00
c7d1eef671
Merge branch 'rubocop-code-reuse' into 'master'
...
Add RuboCop cops to enforce code reusing rules
See merge request gitlab-org/gitlab-ce!21391
2018-09-13 14:53:05 +00:00
d3c5b07962
Remove Rugged and shell code from Gitlab::Git
2018-09-12 12:32:32 -03:00
2039c8280d
Disable existing offenses for the CodeReuse cops
...
This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.
2018-09-11 17:32:00 +02:00
7f2b287f66
Merge branch 'osw-send-max-patch-bytes-to-gitaly' into 'master'
...
Send max_patch_bytes to Gitaly via Gitaly::CommitDiffRequest
Closes #50635
See merge request gitlab-org/gitlab-ce!21575
2018-09-07 14:02:17 +00:00
965ff14b6f
Send max_patch_bytes to Gitaly via Gitaly::CommitDiffRequest
...
We used to apply this limitation on GitLab when using Rugged. Now that
we've shifted to Gitaly, this parameter needs to be sent via a RPC
request. Currently this value is hardcoded on Gitaly.
2018-09-06 19:18:27 -03:00
460badd8cc
Add Gitlab::Git::Repository#find_remote_root_ref
2018-09-06 16:01:48 -03:00
4b87d80499
Fix merge requests not showing any diff files for big patches
2018-08-17 13:22:38 -03:00
5bf9f5b67b
Merge branch 'zj-user-update-branch' into 'master'
...
Remove feature flags for UserUpdateBranch
Closes gitaly#1246 and gitaly#1310
See merge request gitlab-org/gitlab-ce!21238
2018-08-17 09:00:43 +00:00
295e582142
Remove feature flags for UserUpdateBranch
...
This has been tested on .com. So far no errors have been seen.
Closes https://gitlab.com/gitlab-org/gitaly/issues/1310
Closes https://gitlab.com/gitlab-org/gitaly/issues/1246
2018-08-16 10:24:26 +02:00
31749779da
Remove feature flag for FindAllRemoteBranches
...
Acceptance testing done through:
https://gitlab.com/gitlab-org/gitaly/issues/1312
Relatively short AT period, but given its not a hard RPC, nor anything
funky is going on, I felt that this was decent enough to remove the
feature flag.
Closes https://gitlab.com/gitlab-org/gitaly/issues/1243
2018-08-16 09:42:31 +02:00
bbbcb9142e
Merge branch 'zj-remove-feature-gate-list-commits' into 'master'
...
Remove feature gate for ListNewCommits
Closes gitaly#1286 and gitaly#1233
See merge request gitlab-org/gitlab-ce!21184
2018-08-14 09:14:23 +00:00
5ddc9ad0b9
Remove feature gate for ListNewCommits
...
Introduced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20087 ,
this has been tested on .com now, and is stable.
Closes https://gitlab.com/gitlab-org/gitaly/issues/1286
Closes https://gitlab.com/gitlab-org/gitaly/issues/1233
2018-08-14 10:34:15 +02:00
7466df872c
Get the `merge-base` of 2 refs trough the API
...
This adds an endpoint to get the common ancestor of 2 refs from the API.
2018-08-13 11:58:54 +02:00
6688a719c4
Backport of gitlab-org/gitlab-ee!6848
2018-08-08 16:18:37 -05:00
5c748a0bd9
Backport some changes from gitlab-org/gitlab-ee!6767
2018-08-07 06:13:48 -05:00
01de2b5df8
Refactor gitlab:import:repos task to remove direct disk access
2018-07-31 16:28:44 -04:00
3f0e6d9205
More Gitaly cleanup: fetch_ref, allow disk access blocks
2018-07-27 08:43:19 +00:00
c8ff6b7c73
Use limit parameter to retrieve Wikis from Gitaly
...
Without this parameter, every load of a Wiki page will load all the Wiki pages
in the repository for the sidebar. This is a significant performance penalty
that can significant slow the display of all Wiki pages.
Relates to #40101
2018-07-24 15:36:31 -07:00
ad73953772
Make repository cleanup mandatory
2018-07-24 13:25:27 +02:00
4147a2dbbd
Annotate Gitlab::Git::Repository#fetch_ref
2018-07-24 06:33:55 +00:00
d4c3a9ab41
Remove unused rugged code that is currently on Gitaly
2018-07-20 14:47:50 -04:00
256e7a6396
Merge branch 'zj-gitaly-migrate-old-migrations' into 'master'
...
Gitaly migrate old DB migrations
Closes gitaly#1106
See merge request gitlab-org/gitlab-ce!20708
2018-07-20 10:21:05 +00:00
fa1ea656f7
Migrate add_remote, remove_remote, fetch_internal_remote to gitaly
2018-07-19 15:07:37 -04:00
805de7fb8d
Add missing Gitaly branch_update nil checks
2018-07-19 17:48:58 +00:00
cfbb256b8b
MigrateProcessCommitWorkerJobs to use Gitaly
...
This old migration used Rugged to find a commit, while Gitaly is the
prefered way now. By migrating this to Gitaly, Gitaly is now a required
running component for this migration.
Part of https://gitlab.com/gitlab-org/gitaly/issues/1106
2018-07-19 13:34:10 +02:00
68b1e5a97c
Incorporate Gitaly's RefService.FindAllRemoteBranches RPC
2018-07-18 16:48:47 -04:00
9348efc6ba
Client implementation for Repository#new_commits
...
After trying to remove the whole method in
8f69014af2902d8d53fe931268bec60f6858f160, this is a more gentle
approach to the method. :)
Prior to this change, new commit detection wasn't implemented in Gitaly,
this was done through: https://gitlab.com/gitlab-org/gitaly/merge_requests/779
As the new implemented got moved around a bit, the whole RevList class
got removed.
Part of https://gitlab.com/gitlab-org/gitaly/issues/1233
2018-07-18 14:46:27 +02:00
5c651daa97
Remove unreachable Git code
2018-07-18 11:12:57 +00:00
830940f422
Migrate merge base, merged branches, write ref
2018-07-17 09:00:32 +00:00
Zeger-Jan van de Weg
Kamil Trzciński
Douwe Maan
Alejandro Rodríguez
Grzegorz Bizon
Oswaldo Ferreira
Tiago Botelho
Michael Kozono
Nick Thomas
Robert Speicher
Yorick Peterse
Douglas Barbosa Alexandre
Bob Van Landuyt
Rubén Dávila
Jacob Vosmaer (GitLab)
Stan Hu
Sean McGivern