Commit Graph

48 Commits

Author SHA1 Message Date
Kamil Trzciński d4c7214799
[master] Pipelines section is available to unauthorized users 2019-01-31 16:52:50 +01:00
blackst0ne b44a2c801a Update specs to rails5 format
Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`
2018-12-19 10:04:31 +11:00
Jasper Maes 56296f1eda Remove rails4 specific code 2018-12-16 10:48:41 +01:00
Mark Chao a63bce1a4b Resolve "Rename the `Master` role to `Maintainer`" Backend 2018-07-11 14:36:08 +00:00
blackst0ne 2b1153f71a [Rails5] Fix pipeline_schedules_controller_spec
In Rails 5.0 there's a bug [1] in controller tests that doesn't parse
nested parameters correctly.

This commit brings a workaround to make specs work again both in rails4
and rails5.

[1]: https://github.com/rails/rails/issues/23997
2018-06-16 15:26:15 +11:00
Matija Čupić 05103f080c
Make Variable key not secret 2018-03-22 12:08:16 +01:00
Matija Čupić 68c6e410bd
Use secret_key and secret_value in Pipeline Schedule variables 2018-03-17 18:29:42 +01:00
Stan Hu 4b0465f20d Address review comments with playing pipeline scheduler 2017-12-12 17:12:45 -08:00
Stan Hu ef78f67f4a Add a spec for rate limiting pipeline schedules 2017-12-12 15:07:25 -08:00
Stan Hu 54f13b1ec8 Add rate limiting to guard against excessive scheduling of pipelines 2017-12-12 15:07:25 -08:00
Stan Hu f8c3a58a54 Avoid Gitaly N+1 calls by caching tag_names 2017-12-12 15:07:24 -08:00
Stan Hu 0ea70802e1 Fix Sidekiq worker and make flash message return a link to the pipelines page 2017-12-12 15:07:24 -08:00
Stan Hu bc2d32aca0 Create a play_pipeline_schedule policy and use it 2017-12-12 15:07:24 -08:00
Stan Hu f6966cfa63 Address some comments with running a pipeline schedule 2017-12-12 15:07:23 -08:00
Stan Hu 8e7f19c60b Add button to run scheduled pipeline immediately
Closes #38741
2017-12-12 15:07:23 -08:00
Jacopo 2f40dac352 Refactor `have_http_status` into `have_gitlab_http_status` in the specs 2017-10-20 10:13:18 +02:00
Robert Speicher 72a7b30c9f Change all `:empty_project` to `:project` 2017-08-02 17:47:31 -04:00
Shinya Maeda f8391bd782 Remove validates :key, uniqueness due to new validator covers the case 2017-07-07 02:49:24 +09:00
Shinya Maeda 60425c2309 Reduce less meaningful test suits from pipeline_schedules_controller_spec.rb 2017-07-06 01:00:54 +09:00
Shinya Maeda 1acaf75d9f Implement ayufan validator 2017-07-06 00:45:26 +09:00
Shinya Maeda 0c9795a7b6 Improve spec: use go instead of put :update 2017-07-06 00:26:09 +09:00
Shinya Maeda dafc341794 Revert "Implement Ci::NestedUniquenessValidator"
This reverts commit 8f0a2b6d78.
2017-07-06 00:23:28 +09:00
Shinya Maeda 8f0a2b6d78 Implement Ci::NestedUniquenessValidator 2017-07-05 18:38:37 +09:00
Shinya Maeda 1bfa818a1f zj nice catchies 3 2017-07-05 18:38:35 +09:00
Shinya Maeda 2f70f3fa35 Improve spec 2017-07-05 18:38:35 +09:00
Shinya Maeda 621f9307ff Implement uniqueness_of_in_memory_validator 2017-07-05 18:38:35 +09:00
Shinya Maeda 124170093a Improved AccessMatchers and tests 2017-07-05 18:38:34 +09:00
Shinya Maeda 8a9d08af07 Fix policy by new guild line 2017-07-05 18:38:34 +09:00
Shinya Maeda 4fb645a678 Fix StaticAnlysys 2017-07-05 18:38:28 +09:00
Shinya Maeda f433fee057 Revert extra validation for duplication between same keys on a submit 2017-07-05 18:38:27 +09:00
Shinya Maeda 6e8ea52be6 Add functionality and security. 2017-07-05 18:38:25 +09:00
Shinya Maeda e364c118a0 Implement variables_attributes create/update cases 2017-07-05 18:38:10 +09:00
Shinya Maeda bbbd5521d2 Improve spec 2017-07-05 18:36:19 +09:00
Shinya Maeda c99f8e8884 Implement uniqueness_of_in_memory_validator 2017-07-05 18:36:19 +09:00
Shinya Maeda 9fe7f0c706 Improved AccessMatchers and tests 2017-07-05 18:36:19 +09:00
Shinya Maeda c023bbbb50 Fix policy by new guild line 2017-07-05 18:36:19 +09:00
Shinya Maeda 749f05ae34 Fix StaticAnlysys 2017-07-05 18:36:19 +09:00
Shinya Maeda a91f581e6d Revert extra validation for duplication between same keys on a submit 2017-07-05 18:36:19 +09:00
Shinya Maeda 1247ae0de9 Add functionality and security. 2017-07-05 18:36:18 +09:00
Shinya Maeda 3ea04616c3 Implement variables_attributes create/update cases 2017-07-05 18:36:18 +09:00
Shinya Maeda af129038e0 Fix sa 2017-06-28 21:58:31 +09:00
Shinya Maeda a513ae4ae5 use go instead of let proc 2017-06-28 21:58:31 +09:00
Shinya Maeda 07b0615e2b Fixed typo and hash alighment 2017-06-28 21:58:31 +09:00
Shinya Maeda c215b10426 Fix static analysis 2017-06-28 21:58:31 +09:00
Shinya Maeda ac7ad42281 IMprove access_matchers 2017-06-28 21:58:31 +09:00
Shinya Maeda 359d72ba3e Fix static analysys 2017-06-28 21:58:31 +09:00
Shinya Maeda 8026f47d67 Add changelog. Add AccessMatchersForController 2017-06-28 21:58:31 +09:00
Zeger-Jan van de Weg 8df3997a92 Add Pipeline Schedules that supersedes experimental Trigger Schedule 2017-05-07 22:35:56 +00:00