Commit Graph

31 Commits

Author SHA1 Message Date
Rémy Coutable 3a2abc1d50
Enable the Layout/ExtraSpacing cop
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-01-24 13:05:45 +01:00
blackst0ne 3d3b46f344 [Rails5] Rename `sort` methods to `sort_by_attribute` 2018-04-04 09:19:47 +00:00
Tiago Botelho 522f4b2c6a Adapt cycle analytics spec helper and cycle analytics usage data spec 2018-03-01 16:43:26 +00:00
blackst0ne 27c95364b5 Replace '.team << [user, role]' with 'add_role(user)' in specs 2017-12-22 19:18:28 +11:00
Jacopo 2f40dac352 Refactor `have_http_status` into `have_gitlab_http_status` in the specs 2017-10-20 10:13:18 +02:00
Tiago Botelho cfd475a45e Removes default scope from sortable 2017-09-07 13:01:59 +01:00
Rémy Coutable ddccd24c13 Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:53 +02:00
Douwe Maan fe13f11041 Create and use project path helpers that only need a project, no namespace 2017-07-05 11:11:59 -05:00
Felipe Artur 921c2be44a Add transient head_pipeline_of to pipeline factories 2017-05-22 17:06:45 -03:00
Felipe Artur 24824cbb4c Fix Specs 2017-05-08 11:26:04 -03:00
Dmitriy Zaporozhets 11ff9fc6a9 Merge branch '28359-skip-process-commit-worker-unless-issues-referenced' into 'master'
Use regex to skip unnecessary reference processing in ProcessCommitWorker

Closes #28359

See merge request !10867
2017-05-08 12:54:23 +00:00
James Edwards-Jones 29519edb55 Cycle analytics specs needed Commit to reference issue
The plan stage both measures time taken and lists related commits. We test for commits being listed, so needed to actually mention the issue in them. An alternative would have been adding “allow_any_instance_of(Commit).to receive(:matches_cross_reference_regex?).and_return(true)” but this felt too coupled to implementation.
2017-05-04 20:03:47 +01:00
Jacopo ff76adb547 Unnecessary "include WaitForAjax" and "include ApiHelpers"
Removed all the unnecessary include of `WaitForAjax` and `ApiHelpers` in the specs.
Removed unnecessary usage of `api:true`
2017-04-21 22:32:02 +02:00
Robert Speicher 9a31ecbef2 Use `:empty_project` where possible in request specs 2017-01-26 18:52:10 -05:00
James Lopez 3263fd9a73 Fix spec failure due to timestamp ordering issue in mySQL 2017-01-25 11:55:11 +01:00
Rémy Coutable db0f9ef4a8
Make cycle_analytics_events_spec.rb side-effect free
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-01-16 14:39:38 -05:00
Z.J. van de Weg 1096040024 Update effected tests 2016-12-04 17:32:33 +01:00
Yorick Peterse 6b4d33566f
Pass commit data to ProcessCommitWorker
By passing commit data to this worker we remove the need for querying
the Git repository for every job. This in turn reduces the time spent
processing each job.

The migration included migrates jobs from the old format to the new
format. For this to work properly it requires downtime as otherwise
workers may start producing errors until they're using a newer version
of the worker code.
2016-12-01 13:36:06 +01:00
Rémy Coutable 46859cb984
Fix a transient spec failure
Sorting by created_at can lead to uncertainties if two records are
created at the same time.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-11-29 16:27:57 +01:00
James Lopez cbd7d00039 added custom date helper and spec and fixed some unrelated spec failures 2016-11-17 08:22:59 +01:00
James Lopez cf2dcf043c Refactor all query config stuff into separate classes and added specs 2016-11-17 08:22:59 +01:00
James Lopez cbc9f0cd1a fix issue with commits and also updated routes 2016-11-17 08:22:59 +01:00
James Lopez 633ddc9ed9 fix authorization of builds and added relevant spec 2016-11-17 08:22:59 +01:00
James Lopez 3d00503368 fixed and added missing scenario to events integration spec 2016-11-17 08:22:58 +01:00
James Lopez 192918cde9 refactored duplicated code in controller, updated JSON array naming and fixed specs 2016-11-17 08:22:57 +01:00
James Lopez 449a9fb1f1 fixed integration spec after big refactoring of fields per stage 2016-11-17 08:22:57 +01:00
James Lopez 8f7266cd4b added missing fields to issue. Also, added a light url builder to add URLs easily from arel. Updated specs. 2016-11-17 08:22:56 +01:00
James Lopez 8bb4750eb3 added pipelines to integration spec 2016-11-17 08:22:56 +01:00
James Lopez 9ead268cfa some more integration scenarios testing order. Also, fixed bug in the staging and test stages. 2016-11-17 08:22:56 +01:00
James Lopez 3267923263 added the rest of the stages to the controller and relevant specs 2016-11-17 08:22:55 +01:00
James Lopez d472611265 added cycle analytics events controller and started integration spec 2016-11-17 08:22:55 +01:00