260c8da060
Whitelist or fix additional `Gitlab/PublicSend` cop violations
...
An upcoming update to rubocop-gitlab-security added additional
violations.
2017-08-14 12:14:11 -04:00
c946ee1282
Enable the Layout/SpaceBeforeBlockBraces cop
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-08-09 11:52:22 +02:00
144e37c667
Remove Gitlab::Git::Repository#find_all
2017-06-27 12:30:51 +02:00
a7e67604b3
Fix ordering of commits in the network graph.
...
- We upgraded `rugged` to 0.25.1.1 in !10286 for %9.1
- Prior to this upgrade, the default sort order for commits returned by
`Gitlab::Git::Repository#find_commits` was `Rugged::SORT_DATE`, which the
graph relied on.
- While upgrading `rugged`, the MR also changed this default to
`Rugged::SORT_NONE`, which broke commit ordering in the graph.
- This commit adds an option to `Gitlab::Git::Repository#find_commits` to sort
by date, and changes the graph builder `Network::Graph` so it explictly
requests the `:date` sort order
2017-04-27 13:09:54 +00:00
56de781a2c
Revert "Enable Style/DotPosition"
...
This reverts commit e00fb2bdc2090e9cabeb1eb35a2672a882cc96e9.
# Conflicts:
# .rubocop.yml
# .rubocop_todo.yml
# lib/gitlab/ci/config/entry/global.rb
# lib/gitlab/ci/config/entry/jobs.rb
# spec/lib/gitlab/ci/config/entry/factory_spec.rb
# spec/lib/gitlab/ci/config/entry/global_spec.rb
# spec/lib/gitlab/ci/config/entry/job_spec.rb
# spec/lib/gitlab/ci/status/build/factory_spec.rb
# spec/lib/gitlab/incoming_email_spec.rb
2017-02-23 09:33:19 -06:00
1fe7501b49
Revert "Prefer leading style for Style/DotPosition"
...
This reverts commit cb10b725c8929b8b4460f89c9d96c773af39ba6b.
2017-02-23 09:33:05 -06:00
206953a430
Prefer leading style for Style/DotPosition
2017-02-23 09:32:22 -06:00
5c7f9d69e3
Fix code for cops
2017-02-23 09:31:57 -06:00
8a4d68c53e
Enable Style/ConditionalAssignment
2017-02-23 09:31:57 -06:00
3dadf306dd
Enable Style/DotPosition
2017-02-23 09:31:56 -06:00
170efaaba2
Enable Style/MultilineOperationIndentation in Rubocop, fixes #25741
2016-12-16 21:37:22 +03:00
28bafd5354
Enable Style/SpaceAfterComma Rubocop cop
2016-06-29 15:23:44 +02:00
3d3c9c75aa
Merge branch 'style/enable-semicolon-rubocop-cop' into 'master'
...
Enable Style/Semicolon rubocop style cop
Don't use semicolons to terminate expressions.
See #17478 .
See merge request !4351
2016-06-01 17:41:19 +00:00
0319d5b632
Enable Style/For rubocop cop
...
Do not use for, unless you know exactly why.
See #17478
2016-06-01 11:18:11 +02:00
face87b7bb
Enable Style/Semicolon rubocop style cop
...
See #17478
2016-06-01 08:45:14 +02:00
de20bd5b31
Merge branch 'rubocop/enable-space-before-comma-cop' into 'master'
...
Enable Style/SpaceBeforeComma rubocop cop
No spaces before commas.
See #17478
See merge request !4360
2016-05-30 18:22:48 +00:00
7a6d069f41
Merge branch 'style/enable-multiline-if-then-rubocop-cop' into 'master'
...
Enable Style/MultilineIfThen rubocop cop
Do not use then for multi-line if.
See #7478 .
See merge request !4353
2016-05-30 17:47:59 +00:00
fdcb7e3685
Enable Style/SpaceBeforeComma rubocop cop
...
No spaces before commas.
See #17478
2016-05-30 14:51:42 +02:00
7ee9b8e758
Enable Style/MultilineIfThen rubocop cop
...
Do not use then for multi-line if.
See #7478 .
2016-05-30 12:18:27 +02:00
0ea017d997
Enable Style/WhileUntilDo rubocop style cop
...
See #17478
2016-05-30 11:37:14 +02:00
17eaecd6c7
Enable Style/InfiniteLoop Rubocop cop
2016-05-23 19:50:31 +02:00
2b10520b30
Merge pull request #7999 from cirosantilli/append-inplace
...
Append in place for strings and arrays [failure unrelated]
2015-01-21 23:07:15 -08:00
5c80160218
Fix various typos
...
signe-in -> signed-in
go_to_gihub_for_permissions -> go_to_github_for_permissions
descendand -> descendant
behavour -> behaviour
recepient_email -> recipient_email
generate_fingerpint -> generate_fingerprint
dependes -> depends
Cant't -> Can't
wisit -> visit
notifcation -> notification
sufficent_scope -> sufficient_scope?
levet -> level
2015-01-18 10:29:37 -05:00
33c9f05c6b
Append in place for strings and arrays
2015-01-01 21:12:00 +01:00
2e9f5de868
Add parenthesis to function def with arguments.
2014-10-03 09:18:46 +02:00
1f355279d2
Remove parent spacing. Fixes #7505
2014-09-06 19:51:28 +10:00
278250821c
Remove grit require
2013-09-30 13:59:16 +03:00
fd0afcc996
Remove the dependancy of grit from class Network::Graph
2013-08-20 12:05:23 +09:00
cd19f82e51
Fix typos
2013-07-29 12:47:06 +02:00
aefdcdd431
Fix postgres error when displaying network graph.
...
fix #4149
2013-06-02 07:15:37 +00:00
3a4c1c5c63
Enable to filter graph by ref
2013-05-13 18:44:50 +09:00
b36b40ca40
Fix minor bug about line overlap.
2013-04-25 20:53:40 +00:00
63b58b9491
Reducing database access.
2013-04-24 15:06:31 +00:00
d9ab7ba6eb
Fixed wrong order of arguments in network graph caused by refactoring
2013-04-03 22:37:07 +03:00
3011ac4150
Refactoring and cleanup. Removed unused commit finders
2013-04-03 21:05:10 +03:00
154e54b46e
Remove grit logic from app/
2013-03-31 18:49:58 +03:00
1f6b6b6c62
Rotating graph orientation.
2013-03-20 12:28:22 +00:00
e00e54b69c
Fix timeout error while showing the very large repo like git repo.
2013-03-19 10:36:40 +09:00
46fa92187d
Refactor: removing duplicate code.
2013-03-19 10:00:29 +09:00
b7e5f4556b
Refactor: Removing the duplicated code.
2013-03-07 21:10:27 +09:00
79cd1ca304
Refactor: change the map hash from a local variable to private variable.
2013-03-07 19:52:46 +09:00
ccc712b198
Refacor: removing the times array, because that is same with @commits array.
2013-03-07 19:16:51 +09:00
8c5003cf75
Refactor: clean up models.
...
* Network::Commit
** Removing unnecessary accessors.
** Removing add_refs methods.
* Network::Graph
** Removing unnecessary accessors.
** The 3 times loop of commits don't need.
2013-03-07 17:56:01 +09:00
e03a018d28
Refactor: rename module and class names.
...
* Module: Graph -> Network
* Class: JsonBuilder -> Graph
2013-03-07 15:42:30 +09:00
Robert Speicher
Rémy Coutable
Jacob Vosmaer
Timothy Andrew
Douwe Maan
Rydkin Maxim
Grzegorz Bizon
Robert Speicher
Dmitriy Zaporozhets
Steven Burgart
Ciro Santilli
Yvo van Beek
Hiroyuki Sato
Johannes Schleifenbaum