21066e827a
Pending delete projects no longer return 500 error in Admins projects view
2017-08-11 11:45:09 +01:00
c946ee1282
Enable the Layout/SpaceBeforeBlockBraces cop
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-08-09 11:52:22 +02:00
3598e60bf2
Add a Circuitbreaker for storage paths
2017-08-04 15:38:48 +02:00
72a7b30c9f
Change all `:empty_project` to `:project`
2017-08-02 17:47:31 -04:00
9513bd18c4
Ensure all project factories use `:repository` trait or `:empty_project`
2017-08-01 14:51:52 -04:00
e561b142fa
Backport gitlab-ee!2456
2017-07-27 12:09:46 -04:00
22d53f0607
Fixes 500 error caused by pending delete projects in admin dashboard
2017-07-25 17:59:47 +01:00
0430b76441
Enable Style/DotPosition Rubocop 👮
2017-06-21 13:48:12 +00:00
a6ec5121f0
Correct RSpec/SingleLineHook cop offenses
2017-06-14 13:18:56 -05:00
5c602e306c
Limit non-administrators to adding 100 members at a time to groups and projects
2017-06-06 16:04:26 +01:00
f09b7f5607
Support hard deletion in Admin::UsersController#destroy
2017-06-05 17:48:57 +01:00
44129aceaf
Codestyle
2017-05-13 02:18:57 +01:00
2e97db051c
Make the new repository_update_events configurable in System Hooks UI
2017-05-12 23:26:48 +01:00
6ecf16b8f7
refactor code based on feedback
2017-05-05 18:01:33 +02:00
cf002738e7
refactor a few things based on feedback
2017-05-04 18:11:28 +02:00
bae1644015
Refactor Admin::GroupsController#members_update method and add some specs
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2017-04-20 19:25:02 +03:00
0483019e98
Port 'Add more usage data to EE ping' to CE
...
CE port of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/735
2017-04-14 15:20:55 +02:00
5058fc67ac
Remove redundant code to convert restricted_levels to integers
...
The ApplicationSetting#restricted_visibility_levels= now takes care of
converting string formatted levels to integers.
2017-03-23 15:25:42 +01:00
7bfa523485
Resolve future conflicts with CE -> EE merge
...
EE already includes specs for the ApplicationSettingsController, so
ensure future changes will be easier to merge to EE.
2017-03-23 11:13:11 +01:00
4e1cebabc7
Undo explicit conversion to Integer
...
With the changes in Gitlab::VisibilityLevel it is no longer needed to
explicit conversion to Integer in the controller itself.
2017-03-20 22:57:45 +01:00
789db2cc19
Make sure scopes are loaded in admin OAuth application form
2017-03-07 14:54:36 +01:00
60288d6c62
Use expect { }.to change { }
...
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8664#note_23427575
2017-02-15 20:21:51 +08:00
3856a3daa1
Add some tests for admin/project runners page
2017-02-15 19:16:12 +08:00
4642ca6686
Use `empty_project` where possible in controller specs
2017-01-25 17:14:38 -05:00
df99883d44
Add tests for admin service templates
2017-01-06 13:21:49 +01:00
8dd9a8b6e0
Allow admins to stop impersonating users without e-mail addresses
...
Resolves #24576
Modify the guard clause of the `ApplicationController#require_email`
before action to skip requests where an admin is impersonating the
current user.
2016-11-17 23:28:39 -05:00
36ec5eaf85
Only show one error message for an invalid email
...
If notification_email is blank, it's set from email. If an admin
attempted to create a user with an invalid email, an error would be
displayed for both fields. Only validate the notification_email if it's
different from email.
2016-10-27 15:46:28 -04:00
e665444724
Fix incorrect "stopped impersonation" log message
...
Closes #21015
2016-08-23 01:09:16 -07:00
7fef2f7b75
Merge branch 'akismet-submittable' into 'master'
...
Submit to Akismet Part 1 (Issues)
Related to #5932 #5573 gitlab-com/infrastructure#14
See merge request !5538
2016-08-15 22:59:47 +00:00
5994c11910
Further refactor and syntax fixes.
2016-08-15 17:20:57 -05:00
e8aab1cd15
This fixes a long running tests due to changed Sidekiq state
2016-08-15 23:26:40 +02:00
43e756d4ea
Refactored AkismetHelper into AkismetService and cleaned up `Spammable`
...
- Refactored SpamCheckService into SpamService
2016-08-15 13:18:15 -05:00
96399a81cb
Allow `Issue` to be submitted as spam
...
- Added controller actions as reusable concerns
- Added controller tests
2016-08-15 13:18:15 -05:00
cb8a425ba4
Fix bug where destroying a namespace would not always destroy projects
...
There is a race condition in DestroyGroupService now that projects are deleted asynchronously:
1. User attempts to delete group
2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project
3. DestroyGroupService destroys the Group, leaving all its projects without a namespace
4. Projects::DestroyService runs later but the can?(current_user,
:remove_project) is `false` because the user no longer has permission to
destroy projects with no namespace.
5. This leaves the project in pending_delete state with no namespace/group.
Projects without a namespace or group also adds another problem: it's not possible to destroy the container
registry tags, since container_registry_path_with_namespace is the wrong value.
The fix is to destroy the group asynchronously and to run execute directly on Projects::DestroyService.
Closes #17893
2016-08-11 15:36:35 -07:00
519275c110
fixes part1 of files to start using active tense
2016-08-09 15:06:23 +01:00
338072cc4b
Layout for Users Groups and Projects on admin area
2016-07-07 13:25:58 -05:00
abca19da8b
Use HTTP matchers if possible
2016-06-27 20:10:42 +02:00
75739e54be
Enable RSpec/NotToNot cop and auto-correct offenses
...
Also removes the note from the development/testing.md guide
2016-05-24 15:40:29 -04:00
bec350528c
Force password change after admin reset
...
When an admin changes a user's password for them, force the user to
reset the password after logging in by expiring the new password
immediately.
2016-05-16 09:21:24 +01:00
b992e2520c
Fix typo
2016-04-22 21:46:47 +00:00
d3462e711c
Fix issue with impersonation
2016-04-22 23:21:56 +02:00
222e1dc59c
Fixes #14638 .
...
The SQL query was ambiguous and in this case we want to filter projects.
2016-04-06 13:56:28 -03:00
340f1fc976
Minor clean up on admin/users_controller_spec
2016-03-31 22:29:32 +02:00
eefc46e0d5
Fix rubocop offenses
2016-02-02 11:25:44 -02:00
718b1dddfe
Refactor Admin::SpamLogsController to block user before destroying
2016-02-02 11:25:44 -02:00
d20e75a8d8
Support Akismet spam checking for creation of issues via API
...
Currently any spam detected by Akismet by non-members via API will be logged
in a separate table in the admin page.
Closes #5612
2016-02-02 11:25:44 -02:00
ec67e9be1d
Repair ldap_blocked state when no ldap identity exist anymore
2016-01-08 16:26:04 -02:00
ba9855d487
Prevent ldap_blocked users from being unblocked by the Admin UI
2016-01-08 16:26:04 -02:00
daca985a6e
Prevent impersonation if blocked
2015-12-02 08:07:29 -05:00
3bb626f91c
refactor login as to be impersonation with better login/logout
...
Modifies the existing "login as" feature to be called impersonation, as
well as keeping track of who is impersonating to revert back to that
user without having to log out.
2015-10-29 11:00:17 +01:00
Tiago Botelho
Rémy Coutable
Bob Van Landuyt
Robert Speicher
Oswaldo Ferreira
Grzegorz Bizon
Nick Thomas
Gabriel Mazetto
James Lopez
Dmitriy Zaporozhets
Sean McGivern
Toon Claes
Markus Koller
Lin Jen-Shin
Z.J. van de Weg
Oren Kanner
Steve Halasz
Stan Hu
Robert Speicher
Patricio Cano
Kamil Trzcinski
Alfredo Sumaran
Z.J. van de Weg
Douwe Maan
Douwe Maan
PotHix
Douglas Barbosa Alexandre
Gabriel Mazetto
Andrew Tomaka
James Newton