72a7b30c9f
Change all `:empty_project` to `:project`
2017-08-02 17:47:31 -04:00
64e589c581
Resolve "Inconsistent location of members page between groups and projects"
2017-07-07 14:40:41 +00:00
fe13f11041
Create and use project path helpers that only need a project, no namespace
2017-07-05 11:11:59 -05:00
a6ec5121f0
Correct RSpec/SingleLineHook cop offenses
2017-06-14 13:18:56 -05:00
5c602e306c
Limit non-administrators to adding 100 members at a time to groups and projects
2017-06-06 16:04:26 +01:00
395fca1493
Refactor members controller destroy action
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2017-04-17 17:44:30 +03:00
7de75920f7
Refactor controller code that creates project/group members
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2017-04-17 14:45:14 +03:00
4642ca6686
Use `empty_project` where possible in controller specs
2017-01-25 17:14:38 -05:00
57b5612aaa
Removed the "Groups" option from the settings gear
...
Fixed more tests
2017-01-03 10:52:14 -06:00
68c730bb99
Fixed rspec tests for the project members also fixed the index
...
view (removed an extra tag )
2017-01-03 10:52:14 -06:00
d211011698
Make access request specs explicitly enable or disable access requests as required
2016-11-11 15:45:47 +00:00
921677782f
Implement CreateMembers service to make controller thin
2016-11-01 10:17:04 +02:00
3608f9284e
Improve create project member test at project_members_controller_spec
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-10-24 13:14:00 +03:00
036fac06d1
Gracefully handle adding of no users to projects and groups
...
- Disable {project, group} members submit button if no users
If no users are selected, the submit button should be disabled.
- Alert user when no users were added to {project, group}.
When no users were selected for adding, an alert message is
flashed that no users were added.
- Also, this commit adds a feedback when users were actually added to a
project, in symmetry with how group members are handled.
Closes #22967 , #23270 .
2016-10-24 13:14:00 +03:00
168197cd5a
Fix project member access levels
2016-10-21 12:57:53 +03:00
2fabd1a123
Change the order of tested methods in project_members_controller_spec
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-10-19 22:14:57 +03:00
357c794a49
Refactor project_members_controller_spec
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-10-19 15:13:59 +03:00
c8b1311934
Fix a few things after the initial improvment to Members::DestroyService
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-10-03 16:57:48 +02:00
bd78f5733c
Exclude requesters from Project#members, Group#members and User#members
...
And create new Project#requesters, Group#requesters scopes.
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-07-01 17:44:46 +02:00
abca19da8b
Use HTTP matchers if possible
2016-06-27 20:10:42 +02:00
909a0ff3ac
Fix and remove duplicate specs
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-20 12:36:59 +02:00
724f986fb2
Redirect to the member's source on request withdrawal
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-18 05:46:45 +02:00
515205d3c1
UI and copywriting improvements
...
+ Move 'Edit Project/Group' out of membership-related partial
+ Show the access request buttons only to logged-in users
+ Put the request access buttons out of in a more visible button
+ Improve the copy in the #remove_member_message helper
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-14 13:18:14 +02:00
d71fbe0dbd
Factorize #request_access and #approve_access_request into a new AccessRequestActions controller concern
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-14 13:07:26 +02:00
d26f81239a
Add request access for groups
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-14 13:07:26 +02:00
75739e54be
Enable RSpec/NotToNot cop and auto-correct offenses
...
Also removes the note from the development/testing.md guide
2016-05-24 15:40:29 -04:00
9581aba4d4
Add changelog entry and fix convention in a spec
2016-04-20 12:41:35 -03:00
0b91ff287d
Projects members tab should follow visibility levels
2016-04-18 17:53:34 -03:00
62f6601c59
Show project members only for members
2016-04-18 17:53:34 -03:00
bb9c194c23
Respond 404 when unauthorized user imports members
2016-04-05 14:37:06 +02:00
c52b5c92fb
Do not leak project exists when importing members
...
When importing members, and user does not have permissions to read
members in a source project, do not leak information about source
project existence. Notifiy user that project has not been found instead.
2016-04-05 13:55:15 +02:00
b248ee9381
Check permissions when importing project members
...
Closes #14899
2016-04-05 13:32:28 +02:00
Robert Speicher
Tim Zallmann
Douwe Maan
Nick Thomas
Dmitriy Zaporozhets
Jose Ivan Vargas
Valery Sizov
Linus G Thiel
Rémy Coutable
Z.J. van de Weg
Felipe Artur
Grzegorz Bizon