Commit Graph

35 Commits

Author SHA1 Message Date
Robert Speicher 9513bd18c4 Ensure all project factories use `:repository` trait or `:empty_project` 2017-08-01 14:51:52 -04:00
Robert Speicher 1a0064dceb Use `empty_project` where possible in spec/features/projects 2017-07-27 13:12:16 -04:00
Keifer Furzland 7e113b6824 Remove superfluous type defs in specs
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:52 +02:00
Rémy Coutable 05e152fa7f
Fix the :project factory by not copying the test repo twice
Also, fixing some calls to the :project factory with the :test_repo
trait since this trait is already included in the :project factory.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 09:58:06 +02:00
Robert Speicher 9eeba8fb49 Auto-correct ProjectPathHelper violations 2017-07-06 12:20:50 -04:00
Robert Speicher e939bf7be1 Change gitlab_sign_in to sign_in where possible 2017-06-29 12:18:23 -04:00
Stan Hu 516a3b7880 Revert "Annotate" to "Blame" 2017-06-22 17:07:19 -07:00
Robert Speicher 45fb1f9542 Change `login_as` uses to `gitlab_sign_in` 2017-06-19 18:59:01 -05:00
Douwe Maan 7944254563 Implement diff viewers 2017-06-14 10:12:21 -05:00
Douwe Maan b38c74d696 Revert 'New file from interface on existing branch' 2017-06-09 10:10:47 -05:00
Douwe Maan 370bc86fb0 Detect if file that appears to be text in the first 1024 bytes is actually binary afer loading all data 2017-06-08 12:49:03 -05:00
Ilya Vassilevsky 3801dc0e6e Promote blameless culture by using "annotate" instead
User-facing changes (fast & easy win)
2017-06-02 08:48:02 +04:00
Oswaldo Ferreira 2338785ec9 Use wait_for_requests to wait all JS request 2017-05-22 20:39:49 -03:00
Douwe Maan 1ede99571b Fix inaccurate code comment 2017-05-18 09:11:23 -05:00
Douwe Maan 24b105e2e1 Add auxiliary blob viewers to dependency files 2017-05-17 14:10:00 -05:00
Douwe Maan 08706f6837 Implement auxiliary blob viewers 2017-05-10 20:07:04 -05:00
Douwe Maan 720cc14a75 Refactor Blob support of external storage in preparation of job artifact blobs 2017-05-03 10:20:05 -05:00
Phil Hughes 0c83f747ec Fixed PDF blob specs
The PDF file is no longer included in the repo, so we need to create the PDF before running the tests
2017-05-02 10:37:57 +01:00
Douwe Maan 54040ce066 Show Raw button as Download for binary files 2017-04-30 14:06:21 -05:00
Douwe Maan 60ebd101d0 Use blob viewers for snippets 2017-04-30 11:21:20 -05:00
Douwe Maan 87a3bd26fa Address feedback 2017-04-27 12:23:27 -05:00
Douwe Maan 964e7d206b Add specs 2017-04-27 12:23:26 -05:00
Douwe Maan a7fd95cd22 Render viewer error synchronously so that 'view the source' link will work 2017-04-27 12:23:26 -05:00
Douwe Maan 7cc4546bc9 Add specs 2017-04-27 12:23:26 -05:00
Jacopo ff76adb547 Unnecessary "include WaitForAjax" and "include ApiHelpers"
Removed all the unnecessary include of `WaitForAjax` and `ApiHelpers` in the specs.
Removed unnecessary usage of `api:true`
2017-04-21 22:32:02 +02:00
Douwe Maan d170133bde Refactor changing files in web UI 2017-04-20 00:37:44 +00:00
Jose Ivan Vargas 7592137f21 Fix rspec and spinach tests 2017-04-06 14:58:57 -05:00
Eric Eastwood b42dc1a52b Linking to edit file directly 2017-04-06 16:36:38 +00:00
Bryce Johnson f564cbb21a Make file templates easy to use and discover 2017-04-03 17:54:40 +00:00
Jacopo 7b04b63eeb New directory from interface on existing branch
The user can create a new directory on a different branch than the
source branch when the branch already exists.
2017-03-21 11:51:53 +01:00
Alfredo Sumaran 08f7e49d29 Merge branch '19742-permalink-blame-button-line-number-hash-links' into 'master'
Update permalink/blame buttons with line number fragment hash

Closes #19742

See merge request !9461
2017-03-13 19:35:18 +00:00
Eric Eastwood c024248539 Update permalink/blame buttons with line number fragment hash
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/19742
2017-03-13 11:58:59 -05:00
Jacopo e0fe2834eb New file from interface on existing branch
Now you can create a new file and select a target_branch != source_branch.
If the file that you want to create already exists on the target branch an error message is shown
A glDropdown is used to select and create a new branch instead of a text field.
2017-03-13 16:36:11 +01:00
Eric Eastwood 584b86da34 Add keyboard shortcut to move to file permalink
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/8082
2017-02-06 16:57:52 -06:00
Douwe Maan 742cee756b Merge branch 'jej-22869' into 'security'
Fix information disclosure in `Projects::BlobController#update`

It was possible to discover private project names by modifying `from_merge_request`parameter in `Projects::BlobController#update`. This fixes that.

- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- Tests
  - [x] Added for this feature/bug
  - [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

https://gitlab.com/gitlab-org/gitlab-ce/issues/22869

See merge request !2023
2016-11-28 21:25:18 -03:00