Commit Graph

191 Commits

Author SHA1 Message Date
Rémy Coutable c946ee1282
Enable the Layout/SpaceBeforeBlockBraces cop
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-08-09 11:52:22 +02:00
Robert Speicher 72a7b30c9f Change all `:empty_project` to `:project` 2017-08-02 17:47:31 -04:00
Rémy Coutable ddccd24c13 Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:53 +02:00
Grzegorz Bizon d382ed5eb6 Fix CI/CD job auto-retry specs 2017-07-20 07:43:15 +02:00
Grzegorz Bizon c1918fb10b Add a new `retry` CI/CD configuration keyword 2017-07-17 12:05:07 +02:00
Kamil Trzcinski 6d272f8e7d Pass before_script and script as-is preserving arrays 2017-07-07 14:42:54 +02:00
Nick Thomas 35f4a00f37 Introduce cache policies for CI jobs 2017-07-05 15:39:26 +01:00
Tomasz Maczukin 16ff3229cb Fix rubocop offenses 2017-07-02 14:48:11 +02:00
Tomasz Maczukin dcdf2a8bc5 Make entrypoint and command keys to be array of strings 2017-07-02 14:48:11 +02:00
Z.J. van de Weg 9b2ae90d2c Remove references to build in pipeline charts
Being the good boyscouts, but mainly because of [the comment in the
review](https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12378#note_33302115)
the words used for classes and variables are changed to not use builds
anymore.
2017-06-23 14:50:03 +02:00
Tomasz Maczukin 3e75fd6c5b
Improve specs for GitlabCiYamlProcessor 2017-06-12 14:27:17 +02:00
Tomasz Maczukin 8c6e2bada2
Add support for docker image configuration in .gitlab-ci.yml 2017-06-12 12:58:35 +02:00
Shinya Maeda ecd9c30930 Add source policy spec 2017-06-08 00:34:59 +09:00
Filip Krakowski 7d16f698d5 Fix typo in test 2017-06-08 00:34:59 +09:00
Filip Krakowski cd0c472711 Fix static-analysis offenses (again) 2017-06-08 00:34:58 +09:00
Filip Krakowski 1dd054e178 Fix static-analysis offenses 2017-06-08 00:34:58 +09:00
Filip Krakowski ecb54cddd1 Add all sources as special keywords for only and except 2017-06-08 00:34:58 +09:00
Filip Krakowski 8db63b2628 Use pipeline.source to determine what triggered a pipeline 2017-06-08 00:34:58 +09:00
Filip Krakowski 6c8e72b410 Add 'schedules' keyword to 'only' and 'except' 2017-06-08 00:34:58 +09:00
Grzegorz Bizon fe0b2f81c7 Refine implementation of pipeline stage seeds 2017-06-02 12:16:11 +02:00
Grzegorz Bizon c72e21fd97 Return stage seeds object from YAML processor 2017-05-31 15:13:40 +02:00
Grzegorz Bizon 1f1f570724 Implement CI/CD config attributes for persisted stages 2017-05-30 12:48:05 +02:00
Rémy Coutable 3db37e0562 Enable the Style/TrailingCommaInArguments cop
Use the EnforcedStyleForMultiline: no_comma option.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-10 18:25:45 +02:00
Rémy Coutable d40e1f547e Enable the Style/TrailingCommaInLiteral cop
Use the EnforcedStyleForMultiline: no_comma option.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-10 18:25:45 +02:00
Kamil Trzciński 828d81ee1f Optimise trace handling code to use streaming instead of full read 2017-04-06 16:20:27 +00:00
Grzegorz Bizon 66dd209661 Ignore job by default if it is a manual action
This makes it possible to maintain backwards compatibility with configs
created when manual actions were non-blocking.

From now manual actions are blocking if configured with `allow_failure:
false`, otherwise manual actions are optional, and their status is
ignored.
2017-03-06 12:01:33 +01:00
Douwe Maan 56de781a2c Revert "Enable Style/DotPosition"
This reverts commit e00fb2bdc2090e9cabeb1eb35a2672a882cc96e9.

# Conflicts:
#	.rubocop.yml
#	.rubocop_todo.yml
#	lib/gitlab/ci/config/entry/global.rb
#	lib/gitlab/ci/config/entry/jobs.rb
#	spec/lib/gitlab/ci/config/entry/factory_spec.rb
#	spec/lib/gitlab/ci/config/entry/global_spec.rb
#	spec/lib/gitlab/ci/config/entry/job_spec.rb
#	spec/lib/gitlab/ci/status/build/factory_spec.rb
#	spec/lib/gitlab/incoming_email_spec.rb
2017-02-23 09:33:19 -06:00
Douwe Maan 1fe7501b49 Revert "Prefer leading style for Style/DotPosition"
This reverts commit cb10b725c8929b8b4460f89c9d96c773af39ba6b.
2017-02-23 09:33:05 -06:00
Douwe Maan 7d4b52b27d Enable Style/WordArray 2017-02-23 09:32:41 -06:00
Douwe Maan 206953a430 Prefer leading style for Style/DotPosition 2017-02-23 09:32:22 -06:00
Douwe Maan c10064aad5 Enable Style/SpaceInsideBrackets 2017-02-23 09:31:56 -06:00
Douwe Maan 3dadf306dd Enable Style/DotPosition 2017-02-23 09:31:56 -06:00
Lin Jen-Shin 9eb8133145 Make sure our current .gitlab-ci.yml is valid
This could prevent errors described in:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8970

Everything we're using right now, should be valid of course.
2017-02-10 16:33:10 +08:00
Grzegorz Bizon 7c271fb549 Fix Rubocop offense in legacy CI/CD config specs 2017-02-06 10:46:21 +01:00
Grzegorz Bizon 149f67cc2e Remove coverage entry from global CI/CD options 2017-02-04 23:04:17 +01:00
Leandro Camargo 8fe708f4a2 Make more code improvements around the '/' stripping logic 2017-01-25 01:07:45 -02:00
Leandro Camargo be7106a145 Force coverage value to always be surrounded by '/' 2017-01-25 01:07:44 -02:00
Leandro Camargo f8bec0d1fb Improve specs styles/organization and add some more specs 2017-01-25 01:07:44 -02:00
Leandro Camargo 6323cd7203 Comply to more requirements and requests made in the code review 2017-01-25 01:07:44 -02:00
Leandro Camargo f1e920ed86 Simplify coverage setting and comply to some requests in code review 2017-01-25 01:07:44 -02:00
Leandro Camargo 0713a7c3a9 Add specs to cover the implemented feature and fix a small bug 2017-01-25 01:07:44 -02:00
Douwe Maan 764fc0dd69 Merge branch 'zj-unadressable-url-variables' into 'master'
Do not check for valid url for .gitlab-ci.yml

Closes #22970

See merge request !8451
2017-01-12 18:19:11 +00:00
Z.J. van de Weg 6ef6f9f205 Do not check for valid url for .gitlab-ci.yml
Until this commit, GitLab would check if the URL in your .gitlab-ci.yml
would be valid and adressable. However, this approach is rather limited.

To begin, the URL couldn't be http://example:$PORT/my-project, as the
PORT value would be interpolated after checking if the URL was valid,
which its not. Also this gem will limit the amount of protocols allowed.

This commit doesn't check, at all, if the URL is valid. This is now the
responsablilty of the user. In my opion this is right, as the user
ultimately benefits from a correct URL, but also, its impossible to
cover all cases.
2017-01-05 19:59:10 +01:00
Jared Deckard 44b0b97cf0 Test newline and carraige return groups 2016-12-28 16:32:45 -06:00
Lin Jen-Shin 05bc71c856 Convert CI YAML variables keys into strings
So that this would be more consistent with the other variables,
which all of them are string based.

Closes #25554
2016-12-15 17:05:53 +08:00
Grzegorz Bizon 65724301e6 Make CI job script a required configuration entry 2016-11-18 14:14:41 +01:00
Kamil Trzcinski ad85928752 Add logical validation to gitlab-ci.yml 2016-10-18 12:22:51 +02:00
Kamil Trzcinski bebfceb1df Fix specs 2016-10-17 23:42:49 +02:00
Kamil Trzcinski cf6a35f09a Improve JwtController implementation 2016-09-20 19:15:13 +02:00
Kamil Trzcinski 0672c5a92e Post-merge improve of CI permissions 2016-09-20 15:41:41 +02:00