Rémy Coutable
cddc5cacfb
Use described_class when possible
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:53 +02:00
Rémy Coutable
ddccd24c13
Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:53 +02:00
Nick Thomas
aeb2869f66
Prevent bad data being added to application settings when Redis is unavailable
2017-07-10 15:40:51 +01:00
Rémy Coutable
97611c88fc
Don't use Flipper for the Performance Bar
...
The implementation now simply rely on the
`performance_bar_allowed_group_id` Application Setting.
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-07 02:34:51 +02:00
Rémy Coutable
040eeb1039
Allow to enable the Performance Bar for a group from the admin area
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-06 18:57:02 +02:00
Robert Speicher
a6ec5121f0
Correct RSpec/SingleLineHook cop offenses
2017-06-14 13:18:56 -05:00
Sean McGivern
3c546acf78
Allow disabling usage ping in `gitlab.yml`
...
Setting `usage_ping_enabled` to false in `gitlab.yml`:
1. Disables the usage ping, regardless of the value stored in the database.
2. Prevents the usage ping from being enabled through the admin panel. It can
only be enabled by either removing the line from `gitlab.yml` and configuring
through the admin panel, or setting it to true in `gitlab.yml`.
2017-05-11 09:20:11 +01:00
Rémy Coutable
d40e1f547e
Enable the Style/TrailingCommaInLiteral cop
...
Use the EnforcedStyleForMultiline: no_comma option.
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-10 18:25:45 +02:00
Douglas Barbosa Alexandre
d464d79032
Lazily sets UUID in ApplicationSetting for new installations
2017-04-26 17:06:15 -03:00
Lin Jen-Shin
83418ad846
Merge remote-tracking branch 'upstream/master' into 27762-add-default-artifacts-expiration
...
* upstream/master: (247 commits)
Switched CONTRIBUTING.md style guide recommendation for method chaining
Fix new offenses
Stylistic tweaks
Fix OAuth/SAML user blocking behavior
Revert "Enable Style/DotPosition"
Revert "Prefer leading style for Style/DotPosition"
Revert "Enable Style/BarePercentLiterals"
Manually correct autocorrect
Move up delegate calls
Exclude migrations from Style/MutableConstant
ActiveSupport delegation is preferred over Forwardable
Update haml_lint to work with newest rubocop
Add explanations to cops
Update rubocop and rubocop-rspec and regenerate .rubocop_todo.yml
Update rubocop and rubocop-rspec and regenerate .rubocop_todo.yml
Order cops alphabetically
Don’t exclude some file in lib from rubocop
Fix new offenses
Enable Rails/Delegate
Enable Style/WordArray
...
2017-02-24 17:14:35 +08:00
Douwe Maan
56de781a2c
Revert "Enable Style/DotPosition"
...
This reverts commit e00fb2bdc2090e9cabeb1eb35a2672a882cc96e9.
# Conflicts:
# .rubocop.yml
# .rubocop_todo.yml
# lib/gitlab/ci/config/entry/global.rb
# lib/gitlab/ci/config/entry/jobs.rb
# spec/lib/gitlab/ci/config/entry/factory_spec.rb
# spec/lib/gitlab/ci/config/entry/global_spec.rb
# spec/lib/gitlab/ci/config/entry/job_spec.rb
# spec/lib/gitlab/ci/status/build/factory_spec.rb
# spec/lib/gitlab/incoming_email_spec.rb
2017-02-23 09:33:19 -06:00
Douwe Maan
1fe7501b49
Revert "Prefer leading style for Style/DotPosition"
...
This reverts commit cb10b725c8929b8b4460f89c9d96c773af39ba6b.
2017-02-23 09:33:05 -06:00
Douwe Maan
7d4b52b27d
Enable Style/WordArray
2017-02-23 09:32:41 -06:00
Douwe Maan
206953a430
Prefer leading style for Style/DotPosition
2017-02-23 09:32:22 -06:00
Douwe Maan
3dadf306dd
Enable Style/DotPosition
2017-02-23 09:31:56 -06:00
Lin Jen-Shin
2b0426a497
Fix tests due to error key changed
2017-02-21 18:46:52 +08:00
Lin Jen-Shin
eede4ab1a2
0 for unlimited, disallow blank, feedback:
...
https://gitlab.com/gitlab-org/gitlab-ce/issues/27762#note_23520780
2017-02-16 23:40:13 +08:00
Lin Jen-Shin
46082f4b65
Use static error message and don't give booleans
...
in validation. Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9219#note_23437431
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9219#note_23437868
2017-02-16 19:30:32 +08:00
Lin Jen-Shin
cfd839d6f5
Fix tests and disallow 0 to make it consistent with .gitlab-ci.yml
2017-02-15 15:31:51 +08:00
Lin Jen-Shin
602f3b84c0
Add a few more tests and make sure empty value sets to nil
2017-02-15 15:31:51 +08:00
Jacob Vosmaer
6bcc52a536
Refine Git garbage collection
2016-11-04 14:30:11 +01:00
Nick Thomas
c1388d0efb
Allow multiple repository storage shards to be enabled, and automatically round-robin between them
2016-11-04 04:01:08 +00:00
tiagonbotelho
1d268a89de
adds second batch of tests changed to active tense
2016-08-09 15:11:39 +01:00
Patricio Cano
6b8eceda39
Default to manual input for `domain_whitelist`, syntax fixes and added new tests.
2016-07-18 17:53:43 -05:00
Patricio Cano
c71e658cca
Refactor and rename `restricted_signup_domains` to `domain_whitelist` to better conform to its behavior and newly introduced behavior.
2016-07-18 17:53:43 -05:00
Patricio Cano
7943767267
Refactored the domain separator regex, plus syntax and grammar fixes.
2016-07-18 17:52:29 -05:00
Patricio Cano
defb8660c0
Added the ability to block sign ups using a domain blacklist.
2016-07-18 17:52:29 -05:00
Alejandro Rodríguez
4a8a69837a
Add Application Setting to configure default Repository Path for new projects
2016-06-29 23:35:00 -04:00
Andrei Gliga
deca3da1a7
stub Devise.omniauth_providers to return GitHub even if the gitlab.yml has no omniauth provider enabled
...
This will fix failing tests in case gitlab.yml file has no omniauth providers enabled
2016-05-12 13:44:46 +03:00
Andrei Gliga
47ee5125e8
validate disabled_oauth_sign_in_sources in ApplicationSe
2016-05-12 13:44:46 +03:00
Jeroen van Baarsen
f1479b56b7
Remove the annotate gem and delete old annotations
...
In 8278b763d9 the default behaviour of annotation
has changes, which was causing a lot of noise in diffs. We decided in #17382
that it is better to get rid of the whole annotate gem, and instead let people
look at schema.rb for the columns in a table.
Fixes : #17382
2016-05-09 18:00:28 +02:00
connorshea
85cc172959
Remove "Congratulations!" tweet button on newly-created project.
...
I’ve removed everything related to the feature based on this commit:
ce08f919f34fd8849834365
Resolves #10857 .
2016-03-31 17:09:36 -06:00
Rémy Coutable
b34963bc12
Validate email addresses using Devise.email_regexp
...
Also:
- Get rid of legacy :strict_mode
- Get rid of custom :email validator
- Add some shared examples to spec emails validation
2016-02-09 18:15:35 +01:00
Grzegorz Bizon
1cbc75b53c
Validate maximum attachment size in application settings
...
`max_attachment_size` in `ApplicationSetting` should be present,
only integers greater than zero are valid.
Closes #13188
2016-02-09 12:11:16 +01:00
Jeroen Nijhof
85e0fce9ee
Add sentry integration
2016-01-18 17:15:10 +01:00
Stan Hu
79c0e7212a
Annotate models
2016-01-06 13:09:55 +00:00
Gabriel Mazetto
33964469b3
WIP require two factor authentication
2015-12-24 19:00:18 -02:00
Kamil Trzcinski
e80e3f5372
Migrate CI::Project to Project
2015-12-11 18:02:09 +01:00
Robert Speicher
d5ea93469b
Add custom UrlValidator
2015-12-07 16:57:26 -05:00
Dmitriy Zaporozhets
a237999f00
Annotate models
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2015-11-13 19:22:46 +01:00
Kamil Trzcinski
4fda9ef8a5
Fix tests
2015-11-08 23:55:47 +01:00
Stan Hu
d7812a95cf
Re-annotate models
2015-09-06 07:48:48 -07:00
Atsushi Ishida
f33898ecfb
Re-annotate models
2015-08-03 01:52:54 +09:00
themaze75
1d080f5745
session_expire_seconds => session_expire_delay
...
delay is in seconds
more legible code in session_store
Added `GitLab restart required` help block to session_expire_delay
2015-06-10 22:10:00 -04:00
Eric Maziade
84a414fe53
Add session expiration delay configuration through UI application
...
settings
2015-06-05 11:50:37 -04:00
Stan Hu
a3157626f1
Re-annotate models
2015-05-03 13:38:27 -07:00
Stan Hu
eb4f1eb5f5
Add application setting to restrict user signups to e-mail domains
...
This feature was requested long ago:
http://feedback.gitlab.com/forums/176466-general/suggestions/4118466-ability-to-register-only-from-ceratain-domains
This MR is based off !253 but changed to use application settings and use wildcard strings
to give more flexibility in pattern matching. Regexps seemed overkill and easy to get wrong.
Only restrict e-mail addresses upon creation
2015-05-02 09:36:52 -07:00
Vinnie Okada
cacac147de
Move restricted visibility settings to the UI
...
Add checkboxes to the application settings page for restricted
visibility levels, and remove those settings from gitlab.yml.
2015-03-07 13:11:08 -07:00
Dmitriy Zaporozhets
66c61f023b
Re-annotate models
2015-03-04 14:14:00 -08:00
Jeroen van Baarsen
0c4a70a306
Updated rspec to rspec 3.x syntax
...
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
2015-02-12 19:17:35 +01:00