Robert Speicher
c8b802471b
Enable the RSpec/HookArgument cop and auto-correct offenses
2017-08-10 19:29:42 -04:00
Rémy Coutable
40bdbfb096
Merge branch 'fix-jira-integration' into 'master'
...
Ensure `JIRA::Resource::Issue` responds to `resolution` before calling it
See merge request !13240
2017-08-04 09:41:50 +00:00
Lin Jen-Shin
bb5f79d43e
Don't include EmailHelpers manually, pick with rspec
...
`:mailer` is needed to pick it easily, while
`type: :mailer` is needed for picking it automatically for
tests located in spec/mailers/*_spec.rb
It's a bit complicated in spec/services/notification_service_spec.rb
but we'll leave it alone for now.
2017-08-03 21:55:48 +08:00
Mehdi Lahmam
03d199fb10
Ensure `JIRA::Resource::Issue` responds to `resolution` before calling it
2017-08-03 15:25:47 +02:00
Robert Speicher
72a7b30c9f
Change all `:empty_project` to `:project`
2017-08-02 17:47:31 -04:00
Robert Speicher
9513bd18c4
Ensure all project factories use `:repository` trait or `:empty_project`
2017-08-01 14:51:52 -04:00
Gabriel Mazetto
c6dee99803
Rename path_with_namespace -> disk_path when dealing with the filesystem
2017-08-01 07:26:58 +02:00
Gabriel Mazetto
abb878326c
Rename many path_with_namespace -> full_path
2017-08-01 07:26:58 +02:00
Sean McGivern
fa4d08ed81
Merge branch '32483-jira-error' into 'master'
...
Display specific error message when JIRA test fails
Closes #32483
See merge request !13100
2017-07-28 07:21:04 +00:00
Rémy Coutable
cddc5cacfb
Use described_class when possible
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:53 +02:00
Rémy Coutable
ddccd24c13
Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:53 +02:00
Keifer Furzland
7e113b6824
Remove superfluous type defs in specs
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:52 +02:00
Jarka Kadlecova
aa2b3ff1e4
Display specific error message when JIRA test fails
2017-07-27 07:51:36 +02:00
Jarka Kadlecova
1c57299400
Remove project_key from the Jira configuration
2017-07-25 17:25:41 +02:00
Alexander Randa
e0ab5618a0
Wrong data type when testing webhooks
2017-07-20 15:12:06 +00:00
Felipe Artur
3715c1cfb5
Fix external issue trackers redirect
2017-07-18 11:44:47 -03:00
Sean McGivern
5db156544c
Prevent GitLab issue tracker spec from failing later specs
2017-07-13 10:31:00 +01:00
Paul Charlton
cb3b4a15e6
Support multiple Redis instances based on queue type
2017-07-11 03:35:47 +00:00
Douwe Maan
c81928cfa7
Include new URL helpers retroactively into includers of Gitlab::Routing
2017-07-07 10:43:37 -05:00
Lin Jen-Shin
dbb313c26f
Encode certificate-authority-data in base64
2017-07-06 19:38:41 +08:00
Lin Jen-Shin
e7acc88156
Rename KUBECONFIG_FILE to KUBECONFIG
2017-07-06 15:55:40 +08:00
Lin Jen-Shin
ef7deb18df
Merge remote-tracking branch 'upstream/master' into 33360-generate-kubeconfig
...
* upstream/master: (888 commits)
Fix Rubocop offense
Use a previous approach for cycle analytics dummy pipeline
Allow admin to disable all restricted visibility levels
Removes file_name_regex from Gitlab::Regex
Remove IIFEs around several javascript classes
Update CHANGELOG.md for 9.3.5
Add ProjectPathHelper cop
Create and use project path helpers that only need a project, no namespace
Handles realtime with 2 states for environments table
Revert "Merge branch '18000-remember-me-for-oauth-login' into 'master'"
Allow creation of files and directories with spaces in web UI
Disable Flipper memoizer in tests to avoid transient failures
Introduce cache policies for CI jobs
fix sidebar padding for full-width items (Time Tracking help)
Replace 'snippets/snippets.feature' spinach with rspec
Rename ci_config_file to ci_config_path
Add back Pipeline#ci_yaml_file_path due to all the troubles
Revert change to design. Go back to scrollable page
Fix cycle analytics tests by making pipeline valid
Fixes the column widths for the new navigation options in settings
...
2017-07-06 15:54:41 +08:00
Rémy Coutable
1b0c6ffd51
Disable RSpec/BeforeAfterAll and enable RSpec/ImplicitExpect cops
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-06-30 17:52:27 +02:00
Adam Niedzielski
9da3076944
Improve support for external issue references
2017-06-30 14:47:53 +02:00
http://jneen.net/
2f0a7088d3
rm use of deprecated webmock api in teamcity_service_spec
2017-06-26 18:00:01 -07:00
http://jneen.net/
7ef3cf64d6
rm use of deprecated webmock api in campfire_service_spec
2017-06-26 18:00:01 -07:00
http://jneen.net/
e57d1bbf13
rm use of deprecated webmock api in jira model spec
2017-06-26 18:00:01 -07:00
http://jneen.net/
9ca4a3988b
rm use of deprecated webmock api in bamboo_service_spec
2017-06-26 18:00:01 -07:00
Pawel Chojnacki
e00f487049
Fix bug where Service `created_at` time was used instead of deployment time.
2017-06-22 21:19:55 +02:00
Pawel Chojnacki
97c42df3b8
Merge remote-tracking branch 'upstream/master' into 28717-additional-metrics-review-branch
2017-06-22 15:05:52 +02:00
Grzegorz Bizon
0430b76441
Enable Style/DotPosition Rubocop 👮
2017-06-21 13:48:12 +00:00
Douwe Maan
33d4a6e244
Remove backticks from chat messages because they're not rendered as code
2017-06-19 11:57:03 -05:00
Pawel Chojnacki
9f2c992ff1
Merge remote-tracking branch 'upstream/master' into 28717-additional-metrics-review-branch
2017-06-16 18:19:41 +02:00
Lin Jen-Shin
6eaec942e6
Changelog entry, doc, and only pass KUBECONFIG_FILE
2017-06-16 22:31:36 +08:00
Lin Jen-Shin
07a65da1d9
Generate KUBECONFIG in KubernetesService#predefined_variables
2017-06-16 22:15:40 +08:00
Robert Speicher
a6ec5121f0
Correct RSpec/SingleLineHook cop offenses
2017-06-14 13:18:56 -05:00
Nick Thomas
fc6e3515a6
Backport EE changes to the Kubernetes service
2017-06-14 10:51:18 +01:00
Pawel Chojnacki
dbb3c28088
Merge remote-tracking branch 'upstream/master' into 28717-additional-metrics-review-branch
...
# Conflicts:
# app/models/project_services/prometheus_service.rb
# app/views/projects/services/_form.html.haml
2017-06-07 10:27:52 +02:00
Pawel Chojnacki
c0a66dbd2d
Fix prometheus service tests
2017-06-06 11:16:15 +02:00
Jarka Kadlecova
6fad5640e7
fix failing specs
2017-06-01 07:47:15 +02:00
Jarka Kadlecova
ab8d54b26b
Don’t create comment on JIRA if link already exists
2017-05-30 15:37:27 +02:00
Jarka Kadlecova
6c17e4f04d
Add API URL to JIRA settings
2017-05-26 15:14:38 +02:00
Robert Speicher
516e3532c6
Merge branch 'revert-b0498c17' into 'master'
...
Refactor `DynamicPathValidator` and `GitLab::Regex` some more
See merge request !11693
2017-05-25 15:14:16 +00:00
Kamil Trzcinski
911e1c2d07
Fix terminals support for Kubernetes service
...
It was broken, because we introduced a default namespace, which was not used by terminal methods.
2017-05-25 15:03:39 +02:00
Douwe Maan
43b1750892
Revert "Remove changes that are not absolutely necessary"
...
This reverts commit b0498c176f
2017-05-24 20:59:26 +00:00
Douwe Maan
bec9ec9a6e
Merge branch '27439-performance-deltas' into 'master'
...
Expose memory deltas between app deployments and refactor prometheus queries to support more custom queries
See merge request !10981
2017-05-12 17:15:31 +00:00
Douwe Maan
ff82acf343
Consistently use monospace font for commit SHAs and branch and tag names
2017-05-12 09:55:25 -05:00
Pawel Chojnacki
693602d957
Keep presentation logic in one place and remove unecessary arguments.
...
+ fix tests
2017-05-11 23:07:12 +02:00
Pawel Chojnacki
4f824d2aec
Custom queries for prometheus
...
- Tests for prometheus queries
- fix rubocop warnings
- Remove unused method. Add more queries to deployment queries.
- Wrap BaseQuery in module hierarchy
Renname Prometheus class to PrometheusClient
2017-05-11 23:07:12 +02:00
Rémy Coutable
3db37e0562
Enable the Style/TrailingCommaInArguments cop
...
Use the EnforcedStyleForMultiline: no_comma option.
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-10 18:25:45 +02:00