Robert Speicher
72a7b30c9f
Change all `:empty_project` to `:project`
2017-08-02 17:47:31 -04:00
Rémy Coutable
cddc5cacfb
Use described_class when possible
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:53 +02:00
Rémy Coutable
ddccd24c13
Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:53 +02:00
Eric Eastwood
ea090291bb
Rename "Slash commands" to "Quick actions"
...
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/27070
Deprecate "chat commands" in favor of "slash commands"
We looked for things like:
- `slash commmand`
- `slash_command`
- `slash-command`
- `SlashCommand`
2017-06-15 09:01:56 -05:00
Robert Speicher
a6ec5121f0
Correct RSpec/SingleLineHook cop offenses
2017-06-14 13:18:56 -05:00
Douwe Maan
09838ac626
Update diff discussion position per discussion instead of per note
2017-05-31 14:34:56 -05:00
Douwe Maan
ab91f76e8b
Add system note with link to diff comparison when MR discussion becomes outdated
2017-05-23 16:27:30 -05:00
Jacob Schatz
aa874a1cd6
Merge branch 'mia_backort' into 'master'
...
Backport of Multiple Assignees feature
See merge request !11089
2017-05-05 19:17:28 +00:00
Valery Sizov
933447e0da
Address static analyzer warning
2017-05-05 20:44:19 +03:00
Valery Sizov
0cfe35f727
Multiple issue assignee: CE restriction for multiple assignees
2017-05-05 18:55:16 +03:00
Jarka Kadlecova
e4f7b87ddb
Support comments for personal snippets
2017-05-05 15:45:49 +02:00
Valery Sizov
387c4b2c21
Backport of multiple_assignees_feature [ci skip]
2017-05-04 17:11:53 +03:00
Douwe Maan
bb8cc94668
Don't use original_discussion_id
2017-04-05 17:44:14 +01:00
Douwe Maan
79889a6aa3
Add specs
2017-04-05 17:44:14 +01:00
Douwe Maan
08bbb9fce6
Add option to start a new discussion on an MR
2017-04-05 17:44:14 +01:00
Jarka Kadlecova
a74a6cfddf
Create todos only for new mentions
2017-03-29 17:20:11 +02:00
Robert Speicher
ca9a79f620
Use `:empty_project` where possible in service specs
2017-03-27 20:44:09 -04:00
mhasbini
9f949d4e24
add /award slash command
...
add /award slash command; Allow posting of just an emoji in comment
2017-02-28 22:38:19 +02:00
dixpac
0dacf3c169
Fix inconsistent naming for services that delete things
...
* Changed name of delete_user_service and worker to destroy
* Move and change delete_group_service to Groups::DestroyService
* Rename Notes::DeleteService to Notes::DestroyService
2017-02-08 09:16:43 +01:00
Jarka Kadlecova
0c350b7939
address comments
2017-01-25 10:10:05 +01:00
Jarka Kadlecova
d6b11dafd3
Support notes without project
2017-01-18 18:38:17 -05:00
Douwe Maan
f208897ccb
Merge branch 'backport-time-tracking-ce' into 'master'
...
Backport timetracking to CE
See merge request !8195
2017-01-18 15:49:22 +00:00
Ruben Davila
17196a2ff3
Backport backend work for time tracking.
2017-01-15 11:10:04 -05:00
Jarka Kadlecova
7ab3dd4b30
support `/merge` slash comand for MRs
2017-01-11 08:48:07 -05:00
Felipe Artur
1b082a4c33
Check if user can read issue before being assigned
2016-12-27 19:25:17 -02:00
Oswaldo Ferreira
d48d879ef5
Does not raise error when Note not found when processing NewNoteWorker
...
- Also remove unnecessary param
2016-11-11 22:54:11 -02:00
Rémy Coutable
929ff01ac0
Ensure we have a user before checking for their permission in Notes::SlashCommandsService
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-09-20 13:58:14 +02:00
Douwe Maan
9aa3edc615
Remove unneeded aliases
2016-08-18 14:29:48 -05:00
Douwe Maan
029b7d2e92
Fixed specs and fixes based on failing specs
2016-08-16 17:42:34 -05:00
Rémy Coutable
7cc4ab14b8
New Notes::SlashCommandsService service
...
Check for update_issuable permission in Notes::SlashCommandsService
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-08-13 00:06:11 +02:00
Rémy Coutable
0eea8c8857
Support slash commands in noteable description and notes
...
Some important things to note:
- commands are removed from noteable.description / note.note
- commands are translated to params so that they are treated as normal
params in noteable Creation services
- the logic is not in the models but in the Creation services, which is
the right place for advanced logic that has nothing to do with what
models should be responsible of!
- UI/JS needs to be updated to handle notes which consist of commands
only
- the `/merge` command is not handled yet
Other improvements:
- Don't process commands in commit notes and display a flash is note is only commands
- Add autocomplete for slash commands
- Add description and params to slash command DSL methods
- Ensure replying by email with a commands-only note works
- Use :subscription_event instead of calling noteable.subscribe
- Support :todo_event in IssuableBaseService
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-08-13 00:05:57 +02:00
Robert Speicher
adc6ec4a9c
Avoid `describe`-ing symbols in specs
2016-07-12 10:27:58 -05:00
Douwe Maan
c66bcf34dd
Add comment with diff to DiffPositionUpdateService spec
2016-07-07 16:14:57 -04:00
Douwe Maan
213f646f9a
Add tests for DiffPositionUpdateService
2016-07-06 18:51:01 -04:00
ZJ van de Weg
e0cabb67d0
Fix latests concerns
2016-05-18 08:47:15 -05:00
Zeger-Jan van de Weg
7a4e7ad04e
Fix tests and wrong choices during merge
2016-05-12 09:23:21 +02:00
Zeger-Jan van de Weg
dccf8a9fc8
Add tests on Awardables and Award Emoji
2016-05-10 12:03:13 +02:00
Robert Schilling
dc39c8372d
Adapt tests to new testing guidelines
2016-04-12 15:43:29 +02:00
Robert Schilling
9aefaa41ab
Fix code review issues
2016-04-12 14:24:05 +02:00
Robert Schilling
ba21c00f01
Delete notes via API
2016-04-12 14:24:05 +02:00
Douglas Barbosa Alexandre
3d52e139b1
Rename Tasks to Todos
2016-02-20 12:39:27 -02:00
Douglas Barbosa Alexandre
ce78813c2a
Create or mark task pending as soon the action happens
2016-02-20 12:12:05 -02:00
Douglas Barbosa Alexandre
3b98adcc75
Create a pending task when a user is mentioned when edit a issue/mr/note
2016-02-20 12:12:05 -02:00
Douglas Barbosa Alexandre
9da03c45c9
Mark pending tasks for the current user as done when he edit a note
2016-02-20 12:10:26 -02:00
Douglas Barbosa Alexandre
49cd19652a
Mark pending tasks for the note author as done when he left a note
2016-02-20 12:10:26 -02:00
Josh Frye
f3d4f2eac7
Fix Rubocop error
2016-01-28 14:44:45 -05:00
Josh Frye
c95bc65519
Update tests
2016-01-28 13:04:42 -05:00
Douwe Maan
a2cfb44157
Tag service specs
2015-12-09 11:55:49 +01:00
Valery Sizov
22bbb379ae
fox tests
2015-11-19 23:00:30 +02:00
Valery Sizov
671a49cfd5
added specs
2015-11-19 14:41:05 +02:00