d831e8e1d0
Add a test to show that threshold 40 would corrupt
...
If we set `ENCODING_CONFIDENCE_THRESHOLD` to 40,
this test case would not pass. If we raise to 50,
this would pass.
Note that if in the future rugged didn't return
corrupt data, this would be less relevant. But still
icu recommend the threshold to be 50, we should just
stick with 50.
2017-08-08 19:10:46 +08:00
feb8974cc8
Merge branch '35941-fix-testing-issue-following-gitaly-install-fix' into 'master'
...
Unset the `RUBYOPT` env variable before installing `gitaly-ruby`
Closes #35941 and #35967
See merge request !13313
2017-08-08 09:39:49 +00:00
21937a157d
Print the setup steps and duration and fix an issue resulting in re-setuping GitLab Shell on each test run
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-08-04 17:27:50 +02:00
201ce2cb55
Unset the RUBYOPT env variable before installing gitaly-ruby
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-08-04 16:10:52 +02:00
805a28e6a1
Revert "Merge branch 'fix-gitaly-install' into 'master'"
...
This reverts commit 23c502b4341018ab0516
2017-08-04 15:59:30 +02:00
b9075d22d7
Revert "Merge branch 'rs-warm-capybara-only-in-ci' into 'master'"
...
This reverts merge request !12761
2017-08-03 19:21:43 +00:00
23c502b434
Merge branch 'fix-gitaly-install' into 'master'
...
Ensure we run installation Rake tasks in a clean env in TestEnv
Closes #35859
See merge request !13249
2017-08-03 11:36:41 +00:00
06165fa0af
Remove test gitaly when older than version file
2017-08-03 10:15:08 +00:00
532ad2e56e
Don't call load_tasks as this would load the tasks twice
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-08-02 19:02:01 +02:00
6a29d3a487
Ensure we run installation Rake tasks in a clean env in TestEnv
...
If we call `system('rake', 'taks_name')`, `ENV['RUBYOPT']` is set to
`'-rbundler/setup'` but some tasks (e.g. `gitlab:gitaly:install` need
a clean env since they install their own Gem bundle.
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-08-02 19:02:01 +02:00
e99564568b
CI fixes for gitaly-ruby
2017-08-01 10:48:46 +02:00
ba81e6defb
Merge branch 'gitaly-ruby-bundler' into 'master'
...
Support the fact that Gitaly uses bundler
See merge request !13135
2017-07-28 09:20:37 +00:00
1631ad02fd
Support the fact that Gitaly uses bundler
2017-07-27 16:35:40 +02:00
5013f3a816
use updated gitlab-test repo for signed commits
2017-07-27 15:43:36 +02:00
396b8f91ec
Fix saving diffs that are not valid UTF-8
...
Previously, we used Psych, which would:
1. Check if a string was encoded as binary, and not ASCII-compatible.
2. Add the !binary tag in that case.
3. Convert to base64.
We need to do the same thing, using a new column in place of the tag.
2017-07-26 15:34:57 +01:00
4144352aae
Don't attempt to warm the Capybara cache outside of CI
...
We initially started doing this because the first feature test to use
the JavaScript driver would often time out due to asset compilation on
CI. We should still do it in CI since the cost is (relatively) low, but
doing so for every local run is both tiresome and generally unnecessary,
as developer machines will be faster than most shared CI runners, and
the cost of retrying a test after a timeout is much, much lower.
2017-07-10 13:18:03 -04:00
78089d1153
Remove option to disable Gitaly completely
2017-07-07 12:48:34 +02:00
6e37e69671
Merge branch 'shell-test-rebuild' into 'master'
...
Reinstall shell on the test env if it's outdated
See merge request !12285
2017-06-28 21:28:02 +00:00
0430b76441
Enable Style/DotPosition Rubocop 👮
2017-06-21 13:48:12 +00:00
b4e1529e57
Reinstall shell on the test env if it's outdated
2017-06-19 17:06:17 -04:00
3cda57b4ab
Actually clean gitlab-test path when TestEnv.set_repo_refs fails
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-06-06 16:23:40 +02:00
c65a8a6e3a
added tests
2017-05-30 16:00:57 +01:00
eef12afc74
Re-download and recompile Gitaly in tests if the version changed
2017-05-24 18:17:02 -04:00
ba441bb6f4
Shorten the last two commit SHA, because CONSISTENCY
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-18 13:04:50 +02:00
7e56ac8f43
If TestEnv#set_repo_refs fails, clean test repos and retry
...
Sometimes, new references are not retrieved when a `git fetch` is called
in a bare repos. The easiest solution is to cleanup the test repos and
retry in this case. This only happens when a new ref is added to
TestEnv::BRANCH_SHA or TestEnv::FORKED_BRANCH_SHA.
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-18 13:04:50 +02:00
628cc84891
Factorize TestEvent#copy_repo
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-18 13:04:50 +02:00
60106c1e1e
Log gitaly output during testing
2017-05-15 10:52:34 +02:00
43f037c903
Don't reuse gRPC channels
...
It seems that bad things happen when two gRPC stubs share one gRPC
channel so let's stop doing that. The downside of this is that we
create more gRPC connections; one per stub.
2017-05-15 10:52:33 +02:00
ef7001c9c6
Merge branch 'master' into 'balsalmiq-support'
...
# Conflicts:
# spec/features/projects/commit/cherry_pick_spec.rb
# spec/features/projects/environments/environment_spec.rb
2017-05-02 09:11:55 +00:00
9f3985c613
Move PDFLab into GitLab
2017-04-28 12:52:36 -04:00
c3633db617
Merge branch 'master' into 'balsalmiq-support'
...
# Conflicts:
# config/webpack.config.js
2017-04-26 11:26:10 +00:00
a9a1f7a61a
Merge branch 'gitaly-testing-toml' into 'master'
...
Gitaly testing toml
Closes gitaly#182
See merge request !10605
2017-04-25 08:21:06 +00:00
476037b05b
Configure Gitaly through settings file instead of ENV vars
2017-04-18 22:43:41 -03:00
2c643a552e
Merge branch 'master' into notebooklab-in-repo
2017-04-13 08:01:55 +01:00
bf5248ac28
Pull in fixture files from the repo
2017-04-11 21:25:10 +01:00
d6cc8feb6c
Setup and run a Gitaly server for testing if GitalyClient is enabled
2017-04-11 16:00:44 -03:00
cf67894504
Finished feature specs
2017-04-11 13:06:45 +01:00
bf64582f67
Fix warning when cloning repo that already exists
...
fixes the warning:
fatal: destination path '~/gitlab-ce/gitlab/tmp/tests/gitlab-test-fork_bare' already exists and is not an empty directory.
2017-04-02 12:03:28 +02:00
c0564c549d
Fix Spinach and Capybara dependencies
...
Closes #30347
2017-04-01 22:49:22 -07:00
2fa5607448
Properly eagerly-load the Capybara server for JS feature specs only
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-03-31 14:43:36 +02:00
f659c406ab
Eager-load the Capybara server to prevent timeouts
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-03-31 11:43:17 +02:00
e559283cc0
Increase Capybara's timeout
...
Also disabled assets warming for Capybara/RSpec and remove a check to
skip assets warming when ./tmp/cache/assets/test exists because assets
are now served by webpack-dev-server.
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-03-31 11:43:17 +02:00
8a0753a55a
Don't clean up the gitlab-test-fork_bare repo
2017-03-30 17:21:19 +01:00
60c0c0f3d0
Merge branch '29843-project-subgroup-transfer' into 'security'
...
Use full path for moving directories when changing namespace path
See merge request !2078
2017-03-29 19:16:50 -07:00
4d6e377cd9
fix new MR form erroneously selects tag as source when branch of same name exists #23237
2017-03-24 06:28:21 +08:00
0b9d56f960
Update storage settings to allow extra values per shard
...
This will be necessary when adding gitaly settings. This version
doesn't make any functional changes, but allows us to include this
breaking change in 9.0 and add the needed extra settings in the future
with backwards compatibility
2017-03-03 12:13:30 -03:00
ad640bc5f9
Use Namespace#full_path instead of #path where appropriate
2017-02-23 17:55:01 -06:00
1fe7501b49
Revert "Prefer leading style for Style/DotPosition"
...
This reverts commit cb10b725c8929b8b4460f89c9d96c773af39ba6b.
2017-02-23 09:33:05 -06:00
206953a430
Prefer leading style for Style/DotPosition
2017-02-23 09:32:22 -06:00
b7d8df503c
Enable Style/MutableConstant
2017-02-23 09:31:56 -06:00
Lin Jen-Shin
Rémy Coutable
Robert Speicher
Jacob Vosmaer (GitLab)
Sean McGivern
Alexis Reigel
Sean McGivern
Robert Speicher
Grzegorz Bizon
Alejandro Rodríguez
Phil Hughes
Luke "Jared" Bennett
Sam Rose
Bob Van Landuyt
Stan Hu
Nick Thomas
Rémy Coutable
Sanster
Douwe Maan