1041 lines
37 KiB
Ruby
1041 lines
37 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe Projects::DestroyService, :aggregate_failures, :event_store_publisher, feature_category: :groups_and_projects do
|
|
include ContainerRegistryHelpers
|
|
include ProjectForksHelper
|
|
include BatchDestroyDependentAssociationsHelper
|
|
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
let!(:project) { create(:project, :repository, namespace: user.namespace) }
|
|
let(:path) { project.repository.disk_path }
|
|
let(:async) { false } # execute or async_execute
|
|
|
|
before do
|
|
stub_container_registry_config(enabled: true)
|
|
stub_container_registry_tags(repository: :any, tags: [])
|
|
end
|
|
|
|
shared_examples 'deleting the project' do
|
|
it 'deletes the project', :sidekiq_inline do
|
|
allow(Gitlab::AppLogger).to receive(:info)
|
|
expect(Gitlab::AppLogger).to receive(:info).with(
|
|
class: 'Projects::DestroyService',
|
|
message: "Project \"#{project.full_path}\" was deleted",
|
|
project_id: project.id,
|
|
full_path: project.full_path
|
|
)
|
|
|
|
destroy_project(project, user, {})
|
|
|
|
expect(Project.unscoped.all).not_to include(project)
|
|
|
|
expect(project.gitlab_shell.repository_exists?(project.repository_storage, path + '.git')).to be_falsey
|
|
end
|
|
|
|
it 'publishes a ProjectDeletedEvent' do
|
|
expected_data = {
|
|
project_id: project.id,
|
|
namespace_id: project.namespace_id,
|
|
root_namespace_id: project.root_namespace.id
|
|
}
|
|
|
|
expect { destroy_project(project, user, {}) }.to publish_event(Projects::ProjectDeletedEvent).with(expected_data)
|
|
end
|
|
end
|
|
|
|
shared_examples 'deleting the project with pipeline and build' do
|
|
before do
|
|
stub_gitlab_api_client_to_support_gitlab_api(supported: false)
|
|
end
|
|
|
|
context 'with pipeline and build related records', :sidekiq_inline do # which has optimistic locking
|
|
let!(:pipeline) { create(:ci_pipeline, project: project) }
|
|
let!(:build) { create(:ci_build, :artifacts, :with_runner_session, pipeline: pipeline) }
|
|
let!(:trace_chunks) { create(:ci_build_trace_chunk, build: build) }
|
|
let!(:job_variables) { create(:ci_job_variable, job: build) }
|
|
let!(:report_result) { create(:ci_build_report_result, build: build) }
|
|
let!(:pending_state) { create(:ci_build_pending_state, build: build) }
|
|
let!(:pipeline_artifact) { create(:ci_pipeline_artifact, pipeline: pipeline) }
|
|
let!(:secure_file) { create(:ci_secure_file, project: project) }
|
|
|
|
it 'deletes build and pipeline related records' do
|
|
expect { destroy_project(project, user, {}) }
|
|
.to change { Ci::Build.count }.by(-1)
|
|
.and change { Ci::BuildTraceChunk.count }.by(-1)
|
|
.and change { Ci::JobArtifact.count }.by(-2)
|
|
.and change { Ci::DeletedObject.count }.by(2)
|
|
.and change { Ci::PipelineArtifact.count }.by(-1)
|
|
.and change { Ci::JobVariable.count }.by(-1)
|
|
.and change { Ci::BuildPendingState.count }.by(-1)
|
|
.and change { Ci::BuildReportResult.count }.by(-1)
|
|
.and change { Ci::BuildRunnerSession.count }.by(-1)
|
|
.and change { Ci::Pipeline.count }.by(-1)
|
|
.and change { Ci::SecureFile.count }.by(-1)
|
|
end
|
|
|
|
it 'avoids N+1 queries' do
|
|
recorder = ActiveRecord::QueryRecorder.new { destroy_project(project, user, {}) }
|
|
|
|
project = create(:project, :repository, namespace: user.namespace)
|
|
pipeline = create(:ci_pipeline, project: project)
|
|
builds = create_list(:ci_build, 3, :artifacts, pipeline: pipeline)
|
|
create(:ci_pipeline_artifact, pipeline: pipeline)
|
|
create_list(:ci_build_trace_chunk, 3, build: builds[0])
|
|
|
|
expect { destroy_project(project, project.first_owner, {}) }.not_to exceed_query_limit(recorder)
|
|
end
|
|
|
|
it_behaves_like 'deleting the project'
|
|
|
|
context 'when project repository feature is disabled' do
|
|
before do
|
|
project.project_feature.update!(
|
|
repository_access_level: ProjectFeature::DISABLED,
|
|
builds_access_level: ProjectFeature::DISABLED,
|
|
merge_requests_access_level: ProjectFeature::DISABLED
|
|
)
|
|
end
|
|
|
|
context 'with different pipeline sources' do
|
|
before do
|
|
# We're creating many pipelines
|
|
allow(Gitlab::QueryLimiting).to receive(:threshold).and_return(479)
|
|
|
|
external_pull_request = create(:external_pull_request, project: project)
|
|
create(:ci_pipeline, project: project, source: :external_pull_request_event, external_pull_request: external_pull_request)
|
|
|
|
create(:ci_pipeline, project: project)
|
|
.update_attribute(:source, :unknown) # Skip validation to create pipeline with unknown source
|
|
|
|
# `unknown` & `external_pull_request_event` types are created above
|
|
Enums::Ci::Pipeline.sources.except(:unknown, :external_pull_request_event).each_key do |source|
|
|
create(:ci_pipeline, project: project, source: source)
|
|
end
|
|
end
|
|
|
|
it_behaves_like 'deleting the project'
|
|
|
|
it 'deletes all the pipelines associated with the project' do
|
|
project_id = project.id
|
|
|
|
destroy_project(project, user)
|
|
|
|
expect(Ci::Pipeline.where(project_id: project_id)).not_to exist
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when project is undergoing refresh' do
|
|
let!(:build_artifacts_size_refresh) { create(:project_build_artifacts_size_refresh, :pending, project: project) }
|
|
|
|
it 'does not log about artifact deletion but continues to delete artifacts' do
|
|
expect(Gitlab::ProjectStatsRefreshConflictsLogger).not_to receive(:warn_artifact_deletion_during_stats_refresh)
|
|
|
|
expect { destroy_project(project, user, {}) }
|
|
.to change { Ci::JobArtifact.count }.by(-2)
|
|
.and change { Projects::BuildArtifactsSizeRefresh.count }.by(-1)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
shared_examples 'handles errors thrown during async destroy' do |error_message|
|
|
it 'does not allow the error to bubble up' do
|
|
expect do
|
|
destroy_project(project, user, {})
|
|
end.not_to raise_error
|
|
end
|
|
|
|
it 'reports the error' do
|
|
expect(Gitlab::ErrorTracking).to receive(:track_exception).and_call_original
|
|
destroy_project(project, user, {})
|
|
end
|
|
|
|
it 'unmarks the project as "pending deletion"' do
|
|
destroy_project(project, user, {})
|
|
|
|
expect(project.reload.pending_delete).to be(false)
|
|
end
|
|
|
|
it 'stores an error message in `projects.delete_error`' do
|
|
destroy_project(project, user, {})
|
|
|
|
expect(project.reload.delete_error).to be_present
|
|
expect(project.delete_error).to match(error_message)
|
|
end
|
|
|
|
context 'when parent group visibility was made more restrictive while project was marked "pending deletion"' do
|
|
let!(:group) { create(:group, :public) }
|
|
let!(:project) { create(:project, :repository, :public, namespace: group) }
|
|
|
|
it 'sets the project visibility level to that of the parent group' do
|
|
group.add_owner(user)
|
|
project.group.update_attribute(:visibility_level, Gitlab::VisibilityLevel::INTERNAL)
|
|
|
|
expect(project.reload.visibility_level).to be(Gitlab::VisibilityLevel::PUBLIC)
|
|
expect(project.group.visibility_level).to be(Gitlab::VisibilityLevel::INTERNAL)
|
|
|
|
destroy_project(project, user, {})
|
|
|
|
expect(project.reload.visibility_level).to be(Gitlab::VisibilityLevel::INTERNAL)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when the deleting user does not have access' do
|
|
before do
|
|
project.update!(pending_delete: true)
|
|
end
|
|
|
|
it 'unsets the pending_delete on project' do
|
|
expect(destroy_project(project, create(:user))).to be(false)
|
|
|
|
project.reload
|
|
|
|
expect(project.pending_delete).to be_falsey
|
|
end
|
|
end
|
|
|
|
context "deleting a project with merge requests" do
|
|
let!(:merge_request) { create(:merge_request, source_project: project) }
|
|
|
|
before do
|
|
allow(project).to receive(:destroy!).and_return(true)
|
|
end
|
|
|
|
[MergeRequestDiffCommit, MergeRequestDiffFile].each do |model|
|
|
it "deletes #{model} records of the merge request" do
|
|
merge_request_diffs = merge_request.merge_request_diffs
|
|
expect(merge_request_diffs.size).to eq(1)
|
|
|
|
records_count = model.where(merge_request_diff_id: merge_request_diffs.first.id).count
|
|
|
|
expect { destroy_project(project, user, {}) }.to change { model.count }.by(-records_count)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'deleting a project with merge request diffs' do
|
|
let!(:merge_request) { create(:merge_request, source_project: project) }
|
|
let!(:another_project_mr) { create(:merge_request, source_project: create(:project)) }
|
|
|
|
it 'deletes merge request diffs' do
|
|
merge_request_diffs = merge_request.merge_request_diffs
|
|
expect(merge_request_diffs.size).to eq(1)
|
|
|
|
expect { destroy_project(project, user, {}) }.to change(MergeRequestDiff, :count).by(-1)
|
|
expect { another_project_mr.reload }.not_to raise_error
|
|
end
|
|
end
|
|
|
|
context 'deleting a project with deployments' do
|
|
let!(:deployment) { create(:deployment, project: project) }
|
|
|
|
it 'deletes deployments' do
|
|
expect { destroy_project(project, user, {}) }.to change(Deployment, :count).by(-1)
|
|
end
|
|
end
|
|
|
|
it_behaves_like 'deleting the project'
|
|
|
|
context 'personal projects count cache' do
|
|
context 'when the executor is the creator of the project itself' do
|
|
it 'invalidates personal_project_count cache of the the owner of the personal namespace' do
|
|
expect(user).to receive(:invalidate_personal_projects_count)
|
|
|
|
destroy_project(project, user, {})
|
|
end
|
|
end
|
|
|
|
context 'when the executor is the instance administrator', :enable_admin_mode do
|
|
it 'invalidates personal_project_count cache of the the owner of the personal namespace' do
|
|
expect(user).to receive(:invalidate_personal_projects_count)
|
|
|
|
destroy_project(project, create(:admin), {})
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'with running pipelines' do
|
|
let!(:pipelines) { create_list(:ci_pipeline, 3, :running, project: project) }
|
|
let(:destroy_pipeline_service) { double('DestroyPipelineService', unsafe_execute: nil) }
|
|
|
|
it 'bulks-fails with AbortPipelineService and then executes DestroyPipelineService for each pipelines' do
|
|
allow(::Ci::DestroyPipelineService).to receive(:new).and_return(destroy_pipeline_service)
|
|
|
|
expect(::Ci::AbortPipelinesService)
|
|
.to receive_message_chain(:new, :execute)
|
|
.with(project.all_pipelines, :project_deleted)
|
|
|
|
pipelines.each do |pipeline|
|
|
expect(destroy_pipeline_service).to receive(:unsafe_execute).with(pipeline)
|
|
end
|
|
|
|
destroy_project(project, user, {})
|
|
end
|
|
end
|
|
|
|
context 'when project has remote mirrors' do
|
|
let!(:project) do
|
|
create(:project, :repository, namespace: user.namespace).tap do |project|
|
|
project.remote_mirrors.create!(url: 'http://test.com')
|
|
end
|
|
end
|
|
|
|
it 'destroys them' do
|
|
expect(RemoteMirror.count).to eq(1)
|
|
|
|
destroy_project(project, user, {})
|
|
|
|
expect(RemoteMirror.count).to eq(0)
|
|
end
|
|
end
|
|
|
|
context 'when project has exports' do
|
|
let!(:project_with_export) do
|
|
create(:project, :repository, namespace: user.namespace).tap do |project|
|
|
create(
|
|
:import_export_upload,
|
|
project: project,
|
|
export_file: fixture_file_upload('spec/fixtures/project_export.tar.gz')
|
|
)
|
|
end
|
|
end
|
|
|
|
it 'destroys project and export' do
|
|
expect do
|
|
destroy_project(project_with_export, user, {})
|
|
end.to change(ImportExportUpload, :count).by(-1)
|
|
|
|
expect(Project.all).not_to include(project_with_export)
|
|
end
|
|
end
|
|
|
|
context 'Sidekiq fake' do
|
|
before do
|
|
# Dont run sidekiq to check if renamed repository exists
|
|
Sidekiq::Testing.fake! { destroy_project(project, user, {}) }
|
|
end
|
|
|
|
it { expect(Project.all).not_to include(project) }
|
|
|
|
it do
|
|
expect(project.gitlab_shell.repository_exists?(project.repository_storage, path + '.git')).to be_falsey
|
|
end
|
|
end
|
|
|
|
context 'when flushing caches fail due to Git errors' do
|
|
before do
|
|
allow(project.repository).to receive(:before_delete).and_raise(::Gitlab::Git::CommandError)
|
|
allow(Gitlab::GitLogger).to receive(:warn).with(
|
|
class: ::Repositories::DestroyService.name,
|
|
container_id: project.id,
|
|
disk_path: project.disk_path,
|
|
message: 'Gitlab::Git::CommandError').and_call_original
|
|
end
|
|
|
|
it_behaves_like 'deleting the project'
|
|
end
|
|
|
|
context 'when flushing caches fail due to Redis' do
|
|
before do
|
|
new_user = create(:user)
|
|
project.team.add_member(new_user, Gitlab::Access::DEVELOPER)
|
|
allow_any_instance_of(described_class).to receive(:flush_caches).and_raise(::Redis::CannotConnectError)
|
|
end
|
|
|
|
it 'keeps project team intact upon an error' do
|
|
perform_enqueued_jobs do
|
|
destroy_project(project, user, {})
|
|
rescue ::Redis::CannotConnectError
|
|
end
|
|
|
|
expect(project.team.members.count).to eq 2
|
|
end
|
|
end
|
|
|
|
context 'with async_execute', :sidekiq_inline do
|
|
let(:async) { true }
|
|
|
|
context 'async delete of project with private issue visibility' do
|
|
before do
|
|
project.project_feature.update_attribute("issues_access_level", ProjectFeature::PRIVATE)
|
|
end
|
|
|
|
it_behaves_like 'deleting the project'
|
|
end
|
|
|
|
it_behaves_like 'deleting the project with pipeline and build'
|
|
|
|
context 'errors' do
|
|
context 'when `remove_legacy_registry_tags` fails' do
|
|
before do
|
|
expect_any_instance_of(described_class)
|
|
.to receive(:remove_legacy_registry_tags).and_return(false)
|
|
end
|
|
|
|
it_behaves_like 'handles errors thrown during async destroy', /Failed to remove some tags/
|
|
end
|
|
|
|
context 'when `remove_repository` fails' do
|
|
before do
|
|
expect_any_instance_of(described_class)
|
|
.to receive(:remove_repository).and_return(false)
|
|
end
|
|
|
|
it_behaves_like 'handles errors thrown during async destroy', /Failed to remove/
|
|
end
|
|
|
|
context 'when `execute` raises expected error' do
|
|
before do
|
|
expect_any_instance_of(Project)
|
|
.to receive(:destroy!).and_raise(StandardError.new("Other error message"))
|
|
end
|
|
|
|
it_behaves_like 'handles errors thrown during async destroy', /Other error message/
|
|
end
|
|
|
|
context 'when `execute` raises unexpected error' do
|
|
before do
|
|
expect_any_instance_of(Project)
|
|
.to receive(:destroy!).and_raise(Exception.new('Other error message'))
|
|
end
|
|
|
|
it 'allows error to bubble up and rolls back project deletion' do
|
|
expect do
|
|
destroy_project(project, user, {})
|
|
end.to raise_error(Exception, 'Other error message')
|
|
|
|
expect(project.reload.pending_delete).to be(false)
|
|
expect(project.delete_error).to include("Other error message")
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'for an archived project' do
|
|
before do
|
|
project.update!(archived: true)
|
|
end
|
|
|
|
it_behaves_like 'deleting the project with pipeline and build'
|
|
end
|
|
end
|
|
|
|
describe 'container registry' do
|
|
context 'when there are regular container repositories' do
|
|
let(:container_repository) { create(:container_repository) }
|
|
|
|
before do
|
|
stub_container_registry_tags(repository: project.full_path + '/image', tags: ['tag'])
|
|
project.container_repositories << container_repository
|
|
end
|
|
|
|
context 'when image repository deletion succeeds' do
|
|
it 'returns true' do
|
|
expect_next_instance_of(Projects::ContainerRepository::CleanupTagsService) do |instance|
|
|
expect(instance).to receive(:execute).and_return(status: :success)
|
|
end
|
|
|
|
expect(destroy_project(project, user)).to be true
|
|
end
|
|
end
|
|
|
|
context 'when image repository deletion raises an error' do
|
|
it 'returns false' do
|
|
expect_next_instance_of(Projects::ContainerRepository::CleanupTagsService) do |service|
|
|
expect(service).to receive(:execute).and_raise(RuntimeError)
|
|
end
|
|
|
|
expect(destroy_project(project, user)).to be false
|
|
end
|
|
end
|
|
|
|
context 'when image repository deletion fails' do
|
|
it 'returns false' do
|
|
expect_next_instance_of(Projects::ContainerRepository::DestroyService) do |service|
|
|
expect(service).to receive(:execute).and_return({ status: :error })
|
|
end
|
|
|
|
expect(destroy_project(project, user)).to be false
|
|
end
|
|
end
|
|
|
|
context 'when registry is disabled' do
|
|
before do
|
|
stub_container_registry_config(enabled: false)
|
|
end
|
|
|
|
it 'does not attempting to remove any tags' do
|
|
expect(Projects::ContainerRepository::DestroyService).not_to receive(:new)
|
|
|
|
destroy_project(project, user)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when there are tags for legacy root repository' do
|
|
before do
|
|
stub_container_registry_tags(repository: project.full_path, tags: ['tag'])
|
|
end
|
|
|
|
context 'when image repository tags deletion succeeds' do
|
|
it 'removes tags' do
|
|
expect_next_instance_of(Projects::ContainerRepository::DestroyService) do |service|
|
|
expect(service).to receive(:execute).and_return({ status: :success })
|
|
end
|
|
|
|
destroy_project(project, user)
|
|
end
|
|
end
|
|
|
|
context 'when image repository tags deletion fails' do
|
|
it 'raises an exception' do
|
|
expect_next_instance_of(Projects::ContainerRepository::DestroyService) do |service|
|
|
expect(service).to receive(:execute).and_return({ status: :error })
|
|
end
|
|
|
|
expect(destroy_project(project, user)).to be false
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when there are no tags for legacy root repository' do
|
|
before do
|
|
stub_container_registry_tags(repository: project.full_path, tags: [])
|
|
end
|
|
|
|
it 'does not try to destroy the repository' do
|
|
expect(Projects::ContainerRepository::DestroyService).not_to receive(:new)
|
|
|
|
destroy_project(project, user)
|
|
end
|
|
end
|
|
|
|
describe 'tag protection rules handling' do
|
|
let_it_be_with_refind(:project) { create(:project, :repository, namespace: user.namespace) }
|
|
|
|
subject { destroy_project(project, user) }
|
|
|
|
context 'when there are tag protection rules' do
|
|
before_all do
|
|
create(:container_registry_protection_tag_rule,
|
|
project: project,
|
|
tag_name_pattern: 'xyz',
|
|
minimum_access_level_for_delete: Gitlab::Access::ADMIN
|
|
)
|
|
|
|
project.add_owner(user)
|
|
project.container_repositories << create(:container_repository)
|
|
end
|
|
|
|
context 'when there are registry tags' do
|
|
before do
|
|
stub_container_registry_tags(repository: project.full_path, tags: ['tag'])
|
|
allow_any_instance_of(described_class)
|
|
.to receive(:remove_legacy_registry_tags).and_return(true)
|
|
end
|
|
|
|
context 'when the current user is an admin', :enable_admin_mode do
|
|
let(:user) { build_stubbed(:admin) }
|
|
|
|
it { is_expected.to be true }
|
|
end
|
|
|
|
context 'when the current user role meets the minimum access level for delete' do
|
|
before_all do
|
|
project.container_registry_protection_tag_rules.first.update!(
|
|
minimum_access_level_for_delete: Gitlab::Access::OWNER
|
|
)
|
|
end
|
|
|
|
it { is_expected.to be true }
|
|
end
|
|
|
|
context 'when the current user role does not meet the minimum access level for delete' do
|
|
it { is_expected.to be false }
|
|
end
|
|
end
|
|
|
|
context 'when there are no registry tags' do
|
|
it { is_expected.to be true }
|
|
end
|
|
end
|
|
|
|
context 'when there are no tag protection rules' do
|
|
it { is_expected.to be true }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'for a forked project with LFS objects' do
|
|
let(:forked_project) { fork_project(project, user) }
|
|
|
|
before do
|
|
project.lfs_objects << create(:lfs_object)
|
|
forked_project.reload
|
|
end
|
|
|
|
it 'destroys the fork' do
|
|
expect { destroy_project(forked_project, user) }
|
|
.not_to raise_error
|
|
end
|
|
|
|
it 'does not update project statistics for the deleted project' do
|
|
expect(ProjectCacheWorker).not_to receive(:perform_async)
|
|
|
|
destroy_project(forked_project, user)
|
|
end
|
|
end
|
|
|
|
context 'as the root of a fork network' do
|
|
let!(:fork_1) { fork_project(project, user) }
|
|
let!(:fork_2) { fork_project(project, user) }
|
|
|
|
it 'updates the fork network with the project name' do
|
|
fork_network = project.fork_network
|
|
|
|
destroy_project(project, user)
|
|
|
|
fork_network.reload
|
|
|
|
expect(fork_network.deleted_root_project_name).to eq(project.full_name)
|
|
expect(fork_network.root_project).to be_nil
|
|
end
|
|
end
|
|
|
|
context 'with related storage move records' do
|
|
context 'when project has active repository storage move records' do
|
|
let!(:project_repository_storage_move) { create(:project_repository_storage_move, :scheduled, container: project) }
|
|
|
|
it 'does not delete the project' do
|
|
expect(destroy_project(project, user)).to be_falsey
|
|
|
|
expect(project.delete_error).to eq "Couldn't remove the project. A project repository storage move is in progress. Try again when it's complete."
|
|
expect(project.pending_delete).to be_falsey
|
|
end
|
|
end
|
|
|
|
context 'when project has active snippet storage move records' do
|
|
let(:project_snippet) { create(:project_snippet, project: project) }
|
|
let!(:snippet_repository_storage_move) { create(:snippet_repository_storage_move, :started, container: project_snippet) }
|
|
|
|
it 'does not delete the project' do
|
|
expect(destroy_project(project, user)).to be_falsey
|
|
|
|
expect(project.delete_error).to eq "Couldn't remove the project. A related snippet repository storage move is in progress. Try again when it's complete."
|
|
expect(project.pending_delete).to be_falsey
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'repository removal' do
|
|
describe '.trash_project_repositories!' do
|
|
let(:trash_project_repositories!) { described_class.new(project, user, {}).send(:trash_project_repositories!) }
|
|
|
|
# Destroys 3 repositories:
|
|
# 1. Project repository
|
|
# 2. Wiki repository
|
|
# 3. Design repository
|
|
|
|
it 'Repositories::DestroyService is called for existing repos' do
|
|
expect_next_instances_of(::Repositories::DestroyService, 3) do |instance|
|
|
expect(instance).to receive(:execute).and_return(status: :success)
|
|
end
|
|
|
|
trash_project_repositories!
|
|
end
|
|
|
|
context 'when the removal has errors' do
|
|
using RSpec::Parameterized::TableSyntax
|
|
|
|
let(:mock_error) { instance_double(::Repositories::DestroyService, execute: { message: 'foo', status: :error }) }
|
|
let(:project_repository) { project.repository }
|
|
let(:wiki_repository) { project.wiki.repository }
|
|
let(:design_repository) { project.design_repository }
|
|
|
|
where(:repo, :message) do
|
|
ref(:project_repository) | 'Failed to remove project repository. Please try again or contact administrator.'
|
|
ref(:wiki_repository) | 'Failed to remove wiki repository. Please try again or contact administrator.'
|
|
ref(:design_repository) | 'Failed to remove design repository. Please try again or contact administrator.'
|
|
end
|
|
|
|
with_them do
|
|
before do
|
|
allow(::Repositories::DestroyService).to receive(:new).with(anything).and_call_original
|
|
allow(::Repositories::DestroyService).to receive(:new).with(repo).and_return(mock_error)
|
|
end
|
|
|
|
it 'raises correct error' do
|
|
expect { trash_project_repositories! }.to raise_error(Projects::DestroyService::DestroyError, message)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
it 'removes project repository' do
|
|
expect { destroy_project(project, user, {}) }.to change { project.repository.exists? }.from(true).to(false)
|
|
end
|
|
|
|
it 'removes wiki repository' do
|
|
project.create_wiki unless project.wiki.repository.exists?
|
|
|
|
expect { destroy_project(project, user, {}) }.to change { project.wiki.repository.exists? }.from(true).to(false)
|
|
end
|
|
|
|
it 'removes design repository' do
|
|
project.design_repository.create_if_not_exists
|
|
|
|
expect { destroy_project(project, user, {}) }.to change { project.design_repository.exists? }.from(true).to(false)
|
|
end
|
|
end
|
|
|
|
context 'snippets' do
|
|
let!(:snippet1) { create(:project_snippet, project: project, author: user) }
|
|
let!(:snippet2) { create(:project_snippet, project: project, author: user) }
|
|
|
|
it 'does not include snippets when deleting in batches' do
|
|
expect(project).to receive(:destroy_dependent_associations_in_batches).with({ exclude: [:container_repositories, :snippets] })
|
|
|
|
destroy_project(project, user)
|
|
end
|
|
|
|
it 'calls the bulk snippet destroy service with the skip_authorization param set to true' do
|
|
expect(project.snippets.count).to eq 2
|
|
|
|
expect_next_instance_of(Snippets::BulkDestroyService, user, project.snippets) do |instance|
|
|
expect(instance).to receive(:execute).with(skip_authorization: true).and_call_original
|
|
end
|
|
|
|
expect do
|
|
destroy_project(project, user)
|
|
end.to change(Snippet, :count).by(-2)
|
|
end
|
|
|
|
context 'when an error is raised deleting snippets' do
|
|
let(:error_message) { 'foo' }
|
|
|
|
it 'does not delete project' do
|
|
allow_next_instance_of(Snippets::BulkDestroyService) do |instance|
|
|
allow(instance).to receive(:execute).and_return(ServiceResponse.error(message: error_message))
|
|
end
|
|
|
|
expect(Gitlab::AppLogger).to receive(:error).with("Snippet deletion failed on #{project.full_path} with the following message: #{error_message}")
|
|
expect(Gitlab::AppLogger).to receive(:error).with(/Failed to remove project snippets/)
|
|
expect(destroy_project(project, user)).to be_falsey
|
|
expect(project.gitlab_shell.repository_exists?(project.repository_storage, path + '.git')).to be_truthy
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when project has webhooks' do
|
|
let!(:web_hook1) { create(:project_hook, project: project) }
|
|
let!(:web_hook2) { create(:project_hook, project: project) }
|
|
let!(:another_project_web_hook) { create(:project_hook) }
|
|
let!(:web_hook_log) { create(:web_hook_log, web_hook: web_hook1) }
|
|
|
|
it 'deletes webhooks and logs related to project' do
|
|
expect_next_instance_of(WebHooks::DestroyService, user) do |instance|
|
|
expect(instance).to receive(:execute).with(web_hook1).and_call_original
|
|
end
|
|
expect_next_instance_of(WebHooks::DestroyService, user) do |instance|
|
|
expect(instance).to receive(:execute).with(web_hook2).and_call_original
|
|
end
|
|
|
|
expect do
|
|
destroy_project(project, user)
|
|
end.to change(WebHook, :count).by(-2)
|
|
end
|
|
|
|
context 'when an error is raised deleting webhooks' do
|
|
before do
|
|
allow_next_instance_of(WebHooks::DestroyService) do |instance|
|
|
allow(instance).to receive(:execute).and_return(message: 'foo', status: :error)
|
|
end
|
|
end
|
|
|
|
it_behaves_like 'handles errors thrown during async destroy', /Failed to remove webhooks/
|
|
end
|
|
end
|
|
|
|
it 'builds the project webhook payload' do
|
|
expect(Gitlab::HookData::ProjectBuilder).to receive(:new).with(project).and_call_original
|
|
|
|
destroy_project(project, user)
|
|
end
|
|
|
|
context 'when project has project bots' do
|
|
let!(:project_bot) { create(:user, :project_bot, maintainer_of: project) }
|
|
|
|
it 'deletes bot user as well' do
|
|
expect_next_instance_of(Users::DestroyService, user) do |instance|
|
|
expect(instance).to receive(:execute).with(project_bot, skip_authorization: true).and_call_original
|
|
end
|
|
|
|
destroy_project(project, user)
|
|
end
|
|
end
|
|
|
|
context 'when project has events' do
|
|
let!(:event) { create(:event, :created, project: project, target: project, author: user) }
|
|
|
|
it 'deletes events from the project' do
|
|
expect do
|
|
destroy_project(project, user)
|
|
end.to change(Event, :count).by(-1)
|
|
end
|
|
|
|
context 'when an error is returned while deleting events' do
|
|
it 'does not delete project' do
|
|
allow_next_instance_of(Events::DestroyService) do |instance|
|
|
allow(instance).to receive(:execute).and_return(ServiceResponse.error(message: 'foo'))
|
|
end
|
|
|
|
expect(destroy_project(project, user)).to be_falsey
|
|
expect(project.delete_error).to include('Failed to remove events')
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'error while destroying', :sidekiq_inline do
|
|
before do
|
|
stub_gitlab_api_client_to_support_gitlab_api(supported: false)
|
|
end
|
|
|
|
let!(:pipeline) { create(:ci_pipeline, project: project) }
|
|
let!(:builds) { create_list(:ci_build, 2, :artifacts, pipeline: pipeline) }
|
|
let!(:build_trace) { create(:ci_build_trace_chunk, build: builds[0]) }
|
|
|
|
it 'deletes on retry' do
|
|
# We can expect this to timeout for very large projects
|
|
# TODO: remove allow_next_instance_of: https://gitlab.com/gitlab-org/gitlab/-/issues/220440
|
|
allow_any_instance_of(Ci::Build).to receive(:destroy).and_raise('boom')
|
|
destroy_project(project, user, {})
|
|
|
|
allow_any_instance_of(Ci::Build).to receive(:destroy).and_call_original
|
|
destroy_project(project, user, {})
|
|
|
|
expect(Project.unscoped.all).not_to include(project)
|
|
expect(project.gitlab_shell.repository_exists?(project.repository_storage, path + '.git')).to be_falsey
|
|
expect(project.all_pipelines).to be_empty
|
|
expect(project.builds).to be_empty
|
|
end
|
|
end
|
|
|
|
context 'associations destroyed in batches' do
|
|
let!(:merge_request) { create(:merge_request, source_project: project) }
|
|
let!(:issue) { create(:issue, project: project) }
|
|
let!(:label) { create(:label, project: project) }
|
|
|
|
it 'destroys the associations marked as `dependent: :destroy`, in batches' do
|
|
query_recorder = ActiveRecord::QueryRecorder.new do
|
|
destroy_project(project, user, {})
|
|
end
|
|
|
|
expect(project.merge_requests).to be_empty
|
|
expect(project.issues).to be_empty
|
|
expect(project.labels).to be_empty
|
|
|
|
expected_queries = [
|
|
delete_in_batches_regexps(:merge_requests, :target_project_id, project, [merge_request]),
|
|
delete_in_batches_regexps(:issues, :project_id, project, [issue]),
|
|
delete_in_batches_regexps(:labels, :project_id, project, [label])
|
|
].flatten
|
|
|
|
expect(query_recorder.log).to include(*expected_queries)
|
|
end
|
|
|
|
context 'fails to destroy an association' do
|
|
let!(:pipeline) { create(:ci_pipeline, project: project) }
|
|
let!(:pipeline_artifact) { create(:ci_pipeline_artifact, pipeline: pipeline) }
|
|
|
|
before do
|
|
destroy_pipeline_double = instance_double('::Ci::DestroyPipelineService')
|
|
|
|
allow(::Ci::DestroyPipelineService)
|
|
.to receive(:new)
|
|
.and_return(destroy_pipeline_double)
|
|
|
|
allow(destroy_pipeline_double).to receive(:unsafe_execute)
|
|
end
|
|
|
|
it 'raises a clear error message about the failed deletion' do
|
|
expect(destroy_project(project, user)).to be_falsey
|
|
expect(project.delete_error).to eq 'Cannot delete record because dependent pipeline artifacts exist'
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#delete_commit_statuses' do
|
|
let(:service) { described_class.new(project, user, {}) }
|
|
let(:batch_size) { described_class::BATCH_SIZE }
|
|
|
|
context 'when there are no commit statuses' do
|
|
it 'does not delete anything and logs zero count' do
|
|
expect(Gitlab::AppLogger).to receive(:info).with(
|
|
class: described_class.name,
|
|
project_id: project.id,
|
|
message: 'leftover commit statuses',
|
|
orphaned_commit_status_count: 0
|
|
)
|
|
|
|
expect { service.send(:delete_commit_statuses) }.not_to change(::CommitStatus, :count)
|
|
end
|
|
end
|
|
|
|
context 'when there are fewer commit statuses than the batch size' do
|
|
before do
|
|
create_list(:commit_status, 2, project: project)
|
|
end
|
|
|
|
it 'deletes all statuses in a single batch and logs the count' do
|
|
expect(Gitlab::AppLogger).to receive(:info).with(
|
|
class: described_class.name,
|
|
project_id: project.id,
|
|
message: 'leftover commit statuses',
|
|
orphaned_commit_status_count: 2
|
|
)
|
|
|
|
expect { service.send(:delete_commit_statuses) }
|
|
.to change { CommitStatus.for_project(project).count }.from(2).to(0)
|
|
end
|
|
end
|
|
|
|
context 'when there are more commit statuses than the batch size' do
|
|
before do
|
|
stub_const("#{described_class}::BATCH_SIZE", 2)
|
|
create_list(:commit_status, 3, project: project)
|
|
end
|
|
|
|
it 'deletes statuses in multiple batches and logs the total count' do
|
|
expect(Gitlab::AppLogger).to receive(:info).with(
|
|
class: described_class.name,
|
|
project_id: project.id,
|
|
message: 'leftover commit statuses',
|
|
orphaned_commit_status_count: 3
|
|
)
|
|
|
|
expect { service.send(:delete_commit_statuses) }
|
|
.to change { CommitStatus.for_project(project).count }.from(3).to(0)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#delete_environments' do
|
|
let(:service) { described_class.new(project, user, {}) }
|
|
let(:batch_size) { described_class::BATCH_SIZE }
|
|
|
|
context 'when there are no environments' do
|
|
it 'does not delete anything and logs zero count' do
|
|
expect(Gitlab::AppLogger).to receive(:info).with(
|
|
class: described_class.name,
|
|
project_id: project.id,
|
|
message: 'Deleting environments completed',
|
|
deleted_environment_count: 0
|
|
)
|
|
|
|
expect { service.send(:delete_environments) }.not_to change(Environment, :count)
|
|
end
|
|
end
|
|
|
|
context 'when there are fewer environments than the batch size' do
|
|
before do
|
|
create_list(:environment, 2, project: project)
|
|
end
|
|
|
|
it 'deletes all environments in a single batch and logs the count' do
|
|
expect(Gitlab::AppLogger).to receive(:info).with(
|
|
class: described_class.name,
|
|
project_id: project.id,
|
|
message: 'Deleting environments completed',
|
|
deleted_environment_count: 2
|
|
)
|
|
|
|
expect { service.send(:delete_environments) }
|
|
.to change { Environment.for_project(project).count }.from(2).to(0)
|
|
end
|
|
end
|
|
|
|
context 'when there are more environments than the batch size' do
|
|
before do
|
|
stub_const("#{described_class}::BATCH_SIZE", 2)
|
|
create_list(:environment, 3, project: project)
|
|
end
|
|
|
|
it 'deletes environments in multiple batches and logs the total count' do
|
|
expect(Gitlab::AppLogger).to receive(:info).with(
|
|
class: described_class.name,
|
|
project_id: project.id,
|
|
message: 'Deleting environments completed',
|
|
deleted_environment_count: 3
|
|
)
|
|
|
|
expect { service.send(:delete_environments) }
|
|
.to change { Environment.for_project(project).count }.from(3).to(0)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#destroy_orphaned_ci_job_artifacts!' do
|
|
let(:service) { described_class.new(project, user) }
|
|
|
|
context 'when there are no orphaned job artifacts' do
|
|
let(:no_job_artifacts) { Ci::JobArtifact.none }
|
|
|
|
before do
|
|
allow(Ci::JobArtifact).to receive(:for_project).with(project).and_return(no_job_artifacts)
|
|
end
|
|
|
|
it 'returns early without performing any destroy operations' do
|
|
expect(no_job_artifacts).not_to receive(:begin_fast_destroy)
|
|
expect(no_job_artifacts).not_to receive(:finalize_fast_destroy)
|
|
|
|
service.send(:destroy_orphaned_ci_job_artifacts!)
|
|
end
|
|
end
|
|
|
|
context 'when there are orphaned job artifacts' do
|
|
let(:job) { create(:ci_build, project: project) }
|
|
let(:orphaned_job_artifact) { create(:ci_job_artifact, job: job, project: project) }
|
|
|
|
before do
|
|
orphaned_job_artifact.connection.transaction do
|
|
orphaned_job_artifact.connection.execute(<<~SQL)
|
|
SET session_replication_role = 'replica';
|
|
SQL
|
|
|
|
orphaned_job_artifact.update_column(:job_id, non_existing_record_id)
|
|
|
|
orphaned_job_artifact.connection.execute(<<~SQL)
|
|
SET session_replication_role = 'origin';
|
|
SQL
|
|
end
|
|
end
|
|
|
|
it 'destroys orphaned artifacts' do
|
|
expect { destroy_project(project, user) }.to change { Ci::JobArtifact.count }.by(-1)
|
|
|
|
expect(Ci::JobArtifact.exists?(orphaned_job_artifact.id)).to be_falsey
|
|
end
|
|
|
|
it 'logs that the artifacts have been destroyed' do
|
|
allow(Gitlab::AppLogger).to receive(:info) # Logged during artifact deletion
|
|
|
|
expect(Gitlab::AppLogger).to receive(:info).with(
|
|
class: described_class.name,
|
|
project_id: project.id,
|
|
message: 'Orphaned CI job artifacts deleted'
|
|
)
|
|
|
|
service.send(:destroy_orphaned_ci_job_artifacts!)
|
|
end
|
|
end
|
|
end
|
|
|
|
def destroy_project(project, user, params = {})
|
|
described_class.new(project, user, params).public_send(async ? :async_execute : :execute)
|
|
end
|
|
end
|