225 lines
6.8 KiB
Ruby
225 lines
6.8 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe Projects::BoardsController do
|
|
let(:project) { create(:project) }
|
|
let(:user) { create(:user) }
|
|
|
|
before do
|
|
project.add_maintainer(user)
|
|
sign_in(user)
|
|
end
|
|
|
|
describe 'GET index' do
|
|
it 'creates a new project board when project does not have one' do
|
|
expect { list_boards }.to change(project.boards, :count).by(1)
|
|
end
|
|
|
|
it 'sets boards_endpoint instance variable to a boards path' do
|
|
list_boards
|
|
|
|
expect(assigns(:boards_endpoint)).to eq project_boards_path(project)
|
|
end
|
|
|
|
it 'pushes swimlanes_buffered_rendering feature flag' do
|
|
allow(controller).to receive(:push_frontend_feature_flag).and_call_original
|
|
|
|
expect(controller).to receive(:push_frontend_feature_flag)
|
|
.with(:swimlanes_buffered_rendering, project, default_enabled: :yaml)
|
|
|
|
list_boards
|
|
end
|
|
|
|
context 'when format is HTML' do
|
|
it 'renders template' do
|
|
list_boards
|
|
|
|
expect(response).to render_template :index
|
|
expect(response.media_type).to eq 'text/html'
|
|
end
|
|
|
|
context 'with unauthorized user' do
|
|
before do
|
|
expect(Ability).to receive(:allowed?).with(user, :log_in, :global).and_call_original
|
|
allow(Ability).to receive(:allowed?).with(user, :read_project, project).and_return(true)
|
|
allow(Ability).to receive(:allowed?).with(user, :read_issue_board, project).and_return(false)
|
|
end
|
|
|
|
it 'returns a not found 404 response' do
|
|
list_boards
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
expect(response.media_type).to eq 'text/html'
|
|
end
|
|
end
|
|
|
|
context 'when user is signed out' do
|
|
let(:project) { create(:project, :public) }
|
|
|
|
it 'renders template' do
|
|
sign_out(user)
|
|
|
|
board = create(:board, project: project)
|
|
create(:board_project_recent_visit, project: board.project, board: board, user: user)
|
|
|
|
list_boards
|
|
|
|
expect(response).to render_template :index
|
|
expect(response.media_type).to eq 'text/html'
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when format is JSON' do
|
|
it 'returns a list of project boards' do
|
|
create_list(:board, 2, project: project)
|
|
|
|
expect(Boards::VisitsFinder).not_to receive(:new)
|
|
|
|
list_boards format: :json
|
|
|
|
expect(response).to match_response_schema('boards')
|
|
expect(json_response.length).to eq 2
|
|
end
|
|
|
|
context 'with unauthorized user' do
|
|
before do
|
|
expect(Ability).to receive(:allowed?).with(user, :log_in, :global).and_call_original
|
|
allow(Ability).to receive(:allowed?).with(user, :read_project, project).and_return(true)
|
|
allow(Ability).to receive(:allowed?).with(user, :read_issue_board, project).and_return(false)
|
|
end
|
|
|
|
it 'returns a not found 404 response' do
|
|
list_boards format: :json
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
expect(response.media_type).to eq 'application/json'
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'issues are disabled' do
|
|
let(:project) { create(:project, :issues_disabled) }
|
|
|
|
it 'returns a not found 404 response' do
|
|
list_boards
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
end
|
|
end
|
|
|
|
it_behaves_like 'unauthorized when external service denies access' do
|
|
subject { list_boards }
|
|
end
|
|
|
|
def list_boards(format: :html)
|
|
get :index, params: {
|
|
namespace_id: project.namespace,
|
|
project_id: project
|
|
},
|
|
format: format
|
|
end
|
|
end
|
|
|
|
describe 'GET show' do
|
|
let!(:board) { create(:board, project: project) }
|
|
|
|
it 'pushes swimlanes_buffered_rendering feature flag' do
|
|
allow(controller).to receive(:push_frontend_feature_flag).and_call_original
|
|
|
|
expect(controller).to receive(:push_frontend_feature_flag)
|
|
.with(:swimlanes_buffered_rendering, project, default_enabled: :yaml)
|
|
|
|
read_board board: board
|
|
end
|
|
|
|
it 'sets boards_endpoint instance variable to a boards path' do
|
|
read_board board: board
|
|
|
|
expect(assigns(:boards_endpoint)).to eq project_boards_path(project)
|
|
end
|
|
|
|
context 'when format is HTML' do
|
|
it 'renders template' do
|
|
expect { read_board board: board }.to change(BoardProjectRecentVisit, :count).by(1)
|
|
|
|
expect(response).to render_template :show
|
|
expect(response.media_type).to eq 'text/html'
|
|
end
|
|
|
|
context 'with unauthorized user' do
|
|
before do
|
|
expect(Ability).to receive(:allowed?).with(user, :log_in, :global).and_call_original
|
|
allow(Ability).to receive(:allowed?).with(user, :read_project, project).and_return(true)
|
|
allow(Ability).to receive(:allowed?).with(user, :read_issue_board, project).and_return(false)
|
|
end
|
|
|
|
it 'returns a not found 404 response' do
|
|
read_board board: board
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
expect(response.media_type).to eq 'text/html'
|
|
end
|
|
end
|
|
|
|
context 'when user is signed out' do
|
|
let(:project) { create(:project, :public) }
|
|
|
|
it 'does not save visit' do
|
|
sign_out(user)
|
|
|
|
expect { read_board board: board }.to change(BoardProjectRecentVisit, :count).by(0)
|
|
|
|
expect(response).to render_template :show
|
|
expect(response.media_type).to eq 'text/html'
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when format is JSON' do
|
|
it 'returns project board' do
|
|
expect(Boards::Visits::CreateService).not_to receive(:new)
|
|
|
|
read_board board: board, format: :json
|
|
|
|
expect(response).to match_response_schema('board')
|
|
end
|
|
|
|
context 'with unauthorized user' do
|
|
before do
|
|
expect(Ability).to receive(:allowed?).with(user, :log_in, :global).and_call_original
|
|
allow(Ability).to receive(:allowed?).with(user, :read_project, project).and_return(true)
|
|
allow(Ability).to receive(:allowed?).with(user, :read_issue_board, project).and_return(false)
|
|
end
|
|
|
|
it 'returns a not found 404 response' do
|
|
read_board board: board, format: :json
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
expect(response.media_type).to eq 'application/json'
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when board does not belong to project' do
|
|
it 'returns a not found 404 response' do
|
|
another_board = create(:board)
|
|
|
|
read_board board: another_board
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
end
|
|
end
|
|
|
|
def read_board(board:, format: :html)
|
|
get :show, params: {
|
|
namespace_id: project.namespace,
|
|
project_id: project,
|
|
id: board.to_param
|
|
},
|
|
format: format
|
|
end
|
|
end
|
|
end
|