gitlab-ce/app
Sean McGivern 5883ce95ef `current_application_settings` belongs on `Gitlab::CurrentSettings`
The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.
2017-08-31 13:38:33 +01:00
..
assets Merge branch 'winh-merge-request-version-dropdowns' into 'master' 2017-08-31 07:53:32 +00:00
controllers `current_application_settings` belongs on `Gitlab::CurrentSettings` 2017-08-31 13:38:33 +01:00
finders Add filter by my reaction 2017-08-30 07:48:55 +00:00
helpers `current_application_settings` belongs on `Gitlab::CurrentSettings` 2017-08-31 13:38:33 +01:00
mailers `current_application_settings` belongs on `Gitlab::CurrentSettings` 2017-08-31 13:38:33 +01:00
models `current_application_settings` belongs on `Gitlab::CurrentSettings` 2017-08-31 13:38:33 +01:00
policies `current_application_settings` belongs on `Gitlab::CurrentSettings` 2017-08-31 13:38:33 +01:00
presenters
serializers Merge branch 'rs-trailingwhitespace-cop' into 'master' 2017-08-16 10:27:46 +00:00
services `current_application_settings` belongs on `Gitlab::CurrentSettings` 2017-08-31 13:38:33 +01:00
uploaders Make sure uploads for personal snippets are correctly rendered 2017-08-11 18:15:02 +02:00
validators
views Remove tooltips from new sidebar 2017-08-30 16:55:01 +01:00
workers Track enqueued and ongoing MRs 2017-08-28 15:48:09 -03:00