148 lines
4.7 KiB
Ruby
148 lines
4.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe Gitlab::Patch::RedisCacheStore, :use_clean_rails_redis_caching, feature_category: :scalability do
|
|
let(:cache) { Rails.cache }
|
|
|
|
before do
|
|
cache.write('x', 1)
|
|
cache.write('y', 2)
|
|
cache.write('z', 3)
|
|
|
|
cache.write('{user1}:x', 1)
|
|
cache.write('{user1}:y', 2)
|
|
cache.write('{user1}:z', 3)
|
|
|
|
cache.instance_variable_set(:@pipeline_batch_size, nil)
|
|
end
|
|
|
|
describe '#read_multi_mget' do
|
|
shared_examples 'reading using cache stores' do
|
|
it 'gets multiple cross-slot keys' do
|
|
expect(
|
|
Gitlab::Instrumentation::RedisClusterValidator.allow_cross_slot_commands do
|
|
# fetch_multi requires a block and we have to specifically test it
|
|
# as it is used in the Gitlab project
|
|
cache.fetch_multi('x', 'y', 'z') { |key| key }
|
|
end
|
|
).to eq({ 'x' => 1, 'y' => 2, 'z' => 3 })
|
|
end
|
|
|
|
it 'gets multiple keys' do
|
|
expect(
|
|
cache.fetch_multi('{user1}:x', '{user1}:y', '{user1}:z') { |key| key }
|
|
).to eq({ '{user1}:x' => 1, '{user1}:y' => 2, '{user1}:z' => 3 })
|
|
end
|
|
|
|
context 'when reading large amount of keys' do
|
|
let(:input_size) { 2100 }
|
|
let(:chunk_size) { 1000 }
|
|
|
|
shared_examples 'read large amount of keys' do
|
|
it 'breaks the input into 2 chunks for redis cluster' do
|
|
cache.redis.with do |redis|
|
|
normal_cluster = !redis.is_a?(Gitlab::Redis::MultiStore) && Gitlab::Redis::ClusterUtil.cluster?(redis)
|
|
multistore_cluster = redis.is_a?(Gitlab::Redis::MultiStore) &&
|
|
::Gitlab::Redis::ClusterUtil.cluster?(redis.default_store)
|
|
|
|
if normal_cluster || multistore_cluster
|
|
times = (input_size.to_f / chunk_size).ceil
|
|
expect(redis).to receive(:pipelined).exactly(times).times.and_call_original
|
|
|
|
expect_next_instances_of(::Redis::PipelinedConnection, times) do |p|
|
|
expect(p).to receive(:get).at_most(chunk_size).times
|
|
end
|
|
else
|
|
expect(redis).to receive(:mget).and_call_original
|
|
end
|
|
end
|
|
|
|
Gitlab::Instrumentation::RedisClusterValidator.allow_cross_slot_commands do
|
|
cache.read_multi(*Array.new(input_size) { |i| i })
|
|
end
|
|
end
|
|
end
|
|
|
|
it_behaves_like 'read large amount of keys'
|
|
end
|
|
end
|
|
|
|
context 'when cache is Rails.cache' do
|
|
let(:cache) { Rails.cache }
|
|
|
|
it_behaves_like 'reading using cache stores'
|
|
end
|
|
|
|
context 'when cache is feature flag cache store' do
|
|
let(:cache) { Gitlab::Redis::FeatureFlag.cache_store }
|
|
|
|
it_behaves_like 'reading using cache stores'
|
|
end
|
|
|
|
context 'when cache is repository cache store' do
|
|
let(:cache) { Gitlab::Redis::RepositoryCache.cache_store }
|
|
|
|
it_behaves_like 'reading using cache stores'
|
|
end
|
|
end
|
|
|
|
describe '#delete_multi_entries' do
|
|
shared_examples 'deleting using cache stores' do
|
|
it 'deletes multiple cross-slot keys' do
|
|
expect(Gitlab::Instrumentation::RedisClusterValidator.allow_cross_slot_commands do
|
|
cache.delete_multi(%w[x y z])
|
|
end).to eq(3)
|
|
end
|
|
|
|
it 'deletes multiple keys' do
|
|
expect(
|
|
cache.delete_multi(%w[{user1}:x {user1}:y {user1}:z])
|
|
).to eq(3)
|
|
end
|
|
|
|
context 'when deleting large amount of keys' do
|
|
before do
|
|
2000.times { |i| cache.write(i, i) }
|
|
end
|
|
|
|
it 'calls pipeline multiple times' do
|
|
cache.redis.with do |redis|
|
|
# no expectation on number of times as it could vary depending on cluster size
|
|
# if the Redis is a Redis Cluster
|
|
if Gitlab::Redis::ClusterUtil.cluster?(redis)
|
|
expect(redis).to receive(:pipelined).at_least(2).and_call_original
|
|
else
|
|
expect(redis).to receive(:del).and_call_original
|
|
end
|
|
end
|
|
|
|
expect(
|
|
Gitlab::Instrumentation::RedisClusterValidator.allow_cross_slot_commands do
|
|
cache.delete_multi(Array(0..1999))
|
|
end
|
|
).to eq(2000)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when cache is Rails.cache' do
|
|
let(:cache) { Rails.cache }
|
|
|
|
it_behaves_like 'deleting using cache stores'
|
|
end
|
|
|
|
context 'when cache is feature flag cache store' do
|
|
let(:cache) { Gitlab::Redis::FeatureFlag.cache_store }
|
|
|
|
it_behaves_like 'deleting using cache stores'
|
|
end
|
|
|
|
context 'when cache is repository cache store' do
|
|
let(:cache) { Gitlab::Redis::RepositoryCache.cache_store }
|
|
|
|
it_behaves_like 'deleting using cache stores'
|
|
end
|
|
end
|
|
end
|