6d37fe952b
Fix missing access checks on issue lookup using IssuableFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ⚠️ - Potentially untested 💣 - No test coverage 🚥 - Test coverage of some sort exists (a test failed when error raised) 🚦 - Test coverage of return value (a test failed when nil used) ✅ - Permissions check tested - [x] ✅ app/controllers/projects/branches_controller.rb:39 - `before_action :authorize_push_code!` helpes limit/prevent exploitation. Always checks for reporter access so fine with confidential issues, issues only visible to team, etc. - [x] 🚥 app/models/cycle_analytics/summary.rb:9 [`.count`] - [x] ✅ app/controllers/projects/todos_controller.rb:19 - [x] Potential double render in app/controllers/projects/todos_controller.rb - https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#cedccb227af9bfdf88802767cb58d43c2b977439_24_24 See merge request !2030 |
||
|---|---|---|
| .. | ||
| admin | ||
| ci | ||
| concerns | ||
| dashboard | ||
| explore | ||
| groups | ||
| import | ||
| oauth | ||
| profiles | ||
| projects | ||
| sherlock | ||
| abuse_reports_controller.rb | ||
| application_controller.rb | ||
| autocomplete_controller.rb | ||
| confirmations_controller.rb | ||
| dashboard_controller.rb | ||
| emojis_controller.rb | ||
| groups_controller.rb | ||
| health_check_controller.rb | ||
| help_controller.rb | ||
| invites_controller.rb | ||
| jwt_controller.rb | ||
| koding_controller.rb | ||
| notification_settings_controller.rb | ||
| omniauth_callbacks_controller.rb | ||
| passwords_controller.rb | ||
| profiles_controller.rb | ||
| projects_controller.rb | ||
| registrations_controller.rb | ||
| root_controller.rb | ||
| search_controller.rb | ||
| sent_notifications_controller.rb | ||
| sessions_controller.rb | ||
| snippets_controller.rb | ||
| uploads_controller.rb | ||
| users_controller.rb | ||