61 lines
2.0 KiB
Ruby
61 lines
2.0 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Gitlab::Git::RevList, lib: true do
|
|
let(:project) { create(:project, :repository) }
|
|
|
|
context "validations" do
|
|
described_class::ALLOWED_VARIABLES.each do |var|
|
|
context var do
|
|
it "accepts values starting with the project repo path" do
|
|
env = { var => "#{project.repository.path_to_repo}/objects" }
|
|
rev_list = described_class.new('oldrev', 'newrev', project: project, env: env)
|
|
|
|
expect(rev_list).to be_valid
|
|
end
|
|
|
|
it "rejects values starting not with the project repo path" do
|
|
env = { var => "/some/other/path" }
|
|
rev_list = described_class.new('oldrev', 'newrev', project: project, env: env)
|
|
|
|
expect(rev_list).not_to be_valid
|
|
end
|
|
|
|
it "rejects values containing the project repo path but not starting with it" do
|
|
env = { var => "/some/other/path/#{project.repository.path_to_repo}" }
|
|
rev_list = described_class.new('oldrev', 'newrev', project: project, env: env)
|
|
|
|
expect(rev_list).not_to be_valid
|
|
end
|
|
|
|
it "ignores nil values" do
|
|
env = { var => nil }
|
|
rev_list = described_class.new('oldrev', 'newrev', project: project, env: env)
|
|
|
|
expect(rev_list).to be_valid
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context "#execute" do
|
|
let(:env) { { "GIT_OBJECT_DIRECTORY" => project.repository.path_to_repo } }
|
|
let(:rev_list) { Gitlab::Git::RevList.new('oldrev', 'newrev', project: project, env: env) }
|
|
|
|
it "calls out to `popen` without environment variables if the record is invalid" do
|
|
allow(rev_list).to receive(:valid?).and_return(false)
|
|
|
|
expect(Open3).to receive(:popen3).with(hash_excluding(env), any_args)
|
|
|
|
rev_list.execute
|
|
end
|
|
|
|
it "calls out to `popen` with environment variables if the record is valid" do
|
|
allow(rev_list).to receive(:valid?).and_return(true)
|
|
|
|
expect(Open3).to receive(:popen3).with(hash_including(env), any_args)
|
|
|
|
rev_list.execute
|
|
end
|
|
end
|
|
end
|