25818bd7ae
We've seen a significant performance penalty when using `BatchLoader#__replace_with!`. This defines methods on the batch loader that proxy to the 'real' object using send. The alternative is `method_missing`, which is slower. However, we've noticed that `method_missing` can be faster if: 1. The objects being loaded have a large interface. 2. We don't call too many methods on the loaded object. Avatar uploads meet both criteria above, so let's use the newly-released feature in https://github.com/exAspArk/batch-loader/pull/45. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60903 |
||
|---|---|---|
| .. | ||
| workers/object_storage | ||
| attachment_uploader_spec.rb | ||
| avatar_uploader_spec.rb | ||
| external_diff_uploader_spec.rb | ||
| file_mover_spec.rb | ||
| file_uploader_spec.rb | ||
| gitlab_uploader_spec.rb | ||
| import_export_uploader_spec.rb | ||
| job_artifact_uploader_spec.rb | ||
| legacy_artifact_uploader_spec.rb | ||
| lfs_object_uploader_spec.rb | ||
| namespace_file_uploader_spec.rb | ||
| object_storage_spec.rb | ||
| personal_file_uploader_spec.rb | ||
| records_uploads_spec.rb | ||
| uploader_helper_spec.rb | ||