root
/
gitlab-ce
mirror of https://gitlab.com/free-releases/gitlab-ce.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity
gitlab-ce/spec/javascripts
History
Fatih Acet b624e45126 Merge branch 'improve-build-scroll-controls-responsive-behaviour' into 'master' 
Improved build page scroll UX

## What does this MR do?

This MR smoothes the UX of the builds page by more effectively affixing the scroll step buttons.

It also ensures the scroll step buttons are always in view, even if the sidemenu is open.

It also moves the autoscroll button into the same container as the scroll buttons.

## Are there points in the code the reviewer needs to double check?

## Why was this MR needed?

The build scroll buttons are always in unpredictable places and are often hidden behind sidemenus.

## Screenshots (if relevant)

![2016-09-08_17.43.58](/uploads/49cb9ad5ef2764453afaa405af7111b2/2016-09-08_17.43.58.gif)

## Does this MR meet the acceptance criteria?

- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [ ] Added for this feature/bug
  - [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

Contributes #21832

See merge request !6270
 		2016-11-08 21:41:48 +00:00
..
behaviors disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
boards Move Ajax interceptor into describe block (!7304) 2016-11-05 12:11:43 +01:00
extensions disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
fixtures Add javascript unit tests for Build 2016-11-04 15:07:51 +00:00
graphs disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
u2f disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
.eslintrc Added new .eslintrc for jasmine tests and corrected build_spec 2016-11-04 15:25:22 +00:00
abuse_reports_spec.js.es6 disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
activities_spec.js.es6 disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
application_spec.js disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
awards_handler_spec.js disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
build_spec.js.es6 Added new .eslintrc for jasmine tests and corrected build_spec 2016-11-04 15:25:22 +00:00
dashboard_spec.js.es6 Replaced jquery.cookie with js.cookie 2016-10-27 21:33:16 +01:00
datetime_utility_spec.js.es6 disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
diff_comments_store_spec.js.es6 Remove logging to console in diff_comments_store_spec 2016-11-05 12:41:36 +01:00
gl_dropdown_spec.js.es6 Do not allow text input in dropdown while loading 2016-10-28 23:26:33 +03:00
gl_field_errors_spec.js.es6 Change show-gl-field-errors to gl-show-field-errors 2016-11-02 11:35:21 +01:00
header_spec.js Enable linting for ES6 files 2016-10-27 21:35:07 +02:00
issue_spec.js Replace static issue fixtures by script (!6059) 2016-10-28 14:02:17 +02:00
labels_issue_sidebar_spec.js.es6 disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
line_highlighter_spec.js disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
merge_request_spec.js disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
merge_request_tabs_spec.js disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
merge_request_widget_spec.js Replace jQuery.timeago with timeago.js 2016-11-07 14:49:00 -06:00
new_branch_spec.js disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
notes_spec.js disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
project_title_spec.js disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
right_sidebar_spec.js Merge branch 'add-todo-toggle-event' into 'master' 2016-10-27 13:28:40 +00:00
search_autocomplete_spec.js disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
shortcuts_issuable_spec.js disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
spec_helper.js Remove leftover references to coffeescript from comments and docs. 2016-10-31 11:39:52 +01:00
syntax_highlight_spec.js disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
zen_mode_spec.js disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00