120 lines
3.7 KiB
Ruby
120 lines
3.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe MergeRequests::ReopenService, feature_category: :code_review_workflow do
|
|
let(:user) { create(:user) }
|
|
let(:user2) { create(:user) }
|
|
let(:guest) { create(:user) }
|
|
let(:merge_request) { create(:merge_request, :closed, assignees: [user2], author: create(:user)) }
|
|
let(:project) { merge_request.project }
|
|
|
|
before do
|
|
project.add_maintainer(user)
|
|
project.add_developer(user2)
|
|
project.add_guest(guest)
|
|
end
|
|
|
|
describe '#execute' do
|
|
it_behaves_like 'cache counters invalidator'
|
|
it_behaves_like 'merge request reviewers cache counters invalidator'
|
|
|
|
context 'valid params' do
|
|
let(:service) { described_class.new(project: project, current_user: user) }
|
|
|
|
before do
|
|
allow(service).to receive(:execute_hooks)
|
|
merge_request.create_cleanup_schedule(scheduled_at: Time.current)
|
|
merge_request.update_column(:merge_ref_sha, 'abc123')
|
|
|
|
perform_enqueued_jobs do
|
|
service.execute(merge_request)
|
|
end
|
|
end
|
|
|
|
it { expect(merge_request).to be_valid }
|
|
it { expect(merge_request).to be_opened }
|
|
|
|
it 'executes hooks with reopen action' do
|
|
expect(service).to have_received(:execute_hooks)
|
|
.with(merge_request, 'reopen')
|
|
end
|
|
|
|
it 'does not call GroupMentionWorker' do
|
|
expect(Integrations::GroupMentionWorker).not_to receive(:perform_async)
|
|
end
|
|
|
|
it 'sends email to user2 about reopen of merge_request', :sidekiq_might_not_need_inline do
|
|
email = ActionMailer::Base.deliveries.last
|
|
expect(email.to.first).to eq(user2.email)
|
|
expect(email.subject).to include(merge_request.title)
|
|
end
|
|
|
|
it 'destroys cleanup schedule record' do
|
|
expect(merge_request.reload.cleanup_schedule).to be_nil
|
|
end
|
|
|
|
it 'clears the cached merge_ref_sha' do
|
|
expect(merge_request.reload.merge_ref_sha).to be_nil
|
|
end
|
|
|
|
context 'note creation' do
|
|
it 'creates resource state event about merge_request reopen' do
|
|
event = merge_request.resource_state_events.last
|
|
expect(event.state).to eq('reopened')
|
|
end
|
|
end
|
|
end
|
|
|
|
it 'caches merge request closing issues' do
|
|
expect(merge_request).to receive(:cache_merge_request_closes_issues!)
|
|
|
|
described_class.new(project: project, current_user: user).execute(merge_request)
|
|
end
|
|
|
|
it 'updates metrics' do
|
|
metrics = merge_request.metrics
|
|
service = double(MergeRequestMetricsService)
|
|
allow(MergeRequestMetricsService)
|
|
.to receive(:new)
|
|
.with(metrics)
|
|
.and_return(service)
|
|
|
|
expect(service).to receive(:reopen)
|
|
|
|
described_class.new(project: project, current_user: user).execute(merge_request)
|
|
end
|
|
|
|
it 'calls the merge request activity counter' do
|
|
expect(Gitlab::UsageDataCounters::MergeRequestActivityUniqueCounter)
|
|
.to receive(:track_reopen_mr_action)
|
|
.with(user: user)
|
|
|
|
described_class.new(project: project, current_user: user).execute(merge_request)
|
|
end
|
|
|
|
it 'refreshes the number of open merge requests for a valid MR' do
|
|
service = described_class.new(project: project, current_user: user)
|
|
|
|
expect do
|
|
service.execute(merge_request)
|
|
|
|
BatchLoader::Executor.clear_current
|
|
end
|
|
.to change { project.open_merge_requests_count }.from(0).to(1)
|
|
end
|
|
|
|
context 'current user is not authorized to reopen merge request' do
|
|
before do
|
|
perform_enqueued_jobs do
|
|
@merge_request = described_class.new(project: project, current_user: guest).execute(merge_request)
|
|
end
|
|
end
|
|
|
|
it 'does not reopen the merge request' do
|
|
expect(@merge_request).to be_closed
|
|
end
|
|
end
|
|
end
|
|
end
|