grafana/public/app/plugins/datasource/elasticsearch/modifyQuery.test.ts

139 lines
7.2 KiB
TypeScript
Raw Permalink Normal View History

Log Rows: Added popover menu with filter options when a log line is selected (#75306) * LogRow: detect text selection * LogRow: refactor menu as component * LogRow: add actions to menu * LogRow: hack menu position * Remove unsused imports * LogRowMessage: remove popover code * PopoverMenu: refactor * LogRows: implement PopoverMenu at log rows level * PopoverMenu: implement copy * PopoverMenu: receive row model * PopoverMenu: fix onClick capture issue * Explore: add new filter methods and props for line filters * PopoverMenu: use new filter props * Explore: separate toggleable and non toggleable filters * PopoverMenu: improve copy * ModifyQuery: extend line filter with value argument * PopoverMenu: close with escape * Remove unused import * Prettier * PopoverMenu: remove label filter options * LogRow: rename text selection handling prop * Update test * Remove unused import * Popover menu: add unit test * LogRows: update unit test * Log row: hide the log row menu if the user is selecting text * Log row: dont hide row menu if popover is not in scope * Log rows: rename state variable * Popover menu: allow menu to scroll * Log rows: fix classname prop * Log rows: close popover if mouse event comes from outside the log rows * Declare new class using object style * Fix style declaration * Logs Popover Menu: add string filtering functions (#76757) * Loki modifyQuery: add line does not contain query modification * Elastic modifyQuery: implement line filters * Modify query: change action name to not be loki specific * Prettier * Prettier * Elastic: escape filter values * Popover menu: create feature flag * Log Rows: integrate logsRowsPopoverMenu flag * Rename feature flag * Popover menu: track interactions * Prettier * logRowsPopoverMenu: update stage * Popover menu: add ds type to tracking data * Log rows: move feature flag check * Improve handle deselection
2023-11-16 17:48:10 +08:00
import { queryHasFilter, removeFilterFromQuery, addFilterToQuery, addStringFilterToQuery } from './modifyQuery';
describe('queryHasFilter', () => {
it('should return true if the query contains the positive filter', () => {
expect(queryHasFilter('label:"value"', 'label', 'value')).toBe(true);
expect(queryHasFilter('label: "value"', 'label', 'value')).toBe(true);
expect(queryHasFilter('label : "value"', 'label', 'value')).toBe(true);
expect(queryHasFilter('label:value', 'label', 'value')).toBe(true);
expect(queryHasFilter('this:"that" AND label:value', 'label', 'value')).toBe(true);
expect(queryHasFilter('this:"that" OR (test:test AND label:value)', 'label', 'value')).toBe(true);
expect(queryHasFilter('this:"that" OR (test:test AND label:value)', 'test', 'test')).toBe(true);
expect(queryHasFilter('(this:"that" OR test:test) AND label:value', 'this', 'that')).toBe(true);
expect(queryHasFilter('(this:"that" OR test:test) AND label:value', 'test', 'test')).toBe(true);
expect(queryHasFilter('(this:"that" OR test :test) AND label:value', 'test', 'test')).toBe(true);
expect(
queryHasFilter(
'message:"Jun 20 17:19:47 Xtorm syslogd[348]: ASL Sender Statistics"',
'message',
'Jun 20 17:19:47 Xtorm syslogd[348]: ASL Sender Statistics'
)
).toBe(true);
});
it('should return false if the query does not contain the positive filter', () => {
expect(queryHasFilter('label:"value"', 'label', 'otherValue')).toBe(false);
expect(queryHasFilter('-label:"value"', 'label', 'value')).toBe(false);
});
it('should return true if the query contains the negative filter', () => {
expect(queryHasFilter('-label:"value"', 'label', 'value', '-')).toBe(true);
expect(queryHasFilter('-label: "value"', 'label', 'value', '-')).toBe(true);
expect(queryHasFilter('-label : "value"', 'label', 'value', '-')).toBe(true);
expect(queryHasFilter('-label:value', 'label', 'value', '-')).toBe(true);
expect(queryHasFilter('this:"that" AND -label:value', 'label', 'value', '-')).toBe(true);
});
it('should return false if the query does not contain the negative filter', () => {
expect(queryHasFilter('label:"value"', 'label', 'otherValue', '-')).toBe(false);
expect(queryHasFilter('label:"value"', 'label', 'value', '-')).toBe(false);
});
it('should support filters containing colons', () => {
expect(queryHasFilter('label\\:name:"value"', 'label:name', 'value')).toBe(true);
expect(queryHasFilter('-label\\:name:"value"', 'label:name', 'value', '-')).toBe(true);
});
it('should support filters containing quotes', () => {
expect(queryHasFilter('label\\:name:"some \\"value\\""', 'label:name', 'some "value"')).toBe(true);
expect(queryHasFilter('-label\\:name:"some \\"value\\""', 'label:name', 'some "value"', '-')).toBe(true);
});
});
describe('addFilterToQuery', () => {
it('should add a positive filter to the query', () => {
expect(addFilterToQuery('', 'label', 'value')).toBe('label:"value"');
});
it('should add a positive filter to the query with other filters', () => {
expect(addFilterToQuery('label2:"value2"', 'label', 'value')).toBe('label2:"value2" AND label:"value"');
});
it('should add a negative filter to the query', () => {
expect(addFilterToQuery('', 'label', 'value', '-')).toBe('-label:"value"');
});
it('should add a negative filter to the query with other filters', () => {
expect(addFilterToQuery('label2:"value2"', 'label', 'value', '-')).toBe('label2:"value2" AND -label:"value"');
});
it('should support filters with colons', () => {
expect(addFilterToQuery('', 'label:name', 'value')).toBe('label\\:name:"value"');
});
it('should support filters with quotes', () => {
expect(addFilterToQuery('', 'label:name', 'the "value"')).toBe('label\\:name:"the \\"value\\""');
});
});
describe('removeFilterFromQuery', () => {
it('should remove filter from query', () => {
expect(removeFilterFromQuery('label:"value"', 'label', 'value')).toBe('');
});
it('should remove filter from query with other filters', () => {
expect(removeFilterFromQuery('label:"value" AND label2:"value2"', 'label', 'value')).toBe('label2:"value2"');
expect(removeFilterFromQuery('label:value AND label2:"value2"', 'label', 'value')).toBe('label2:"value2"');
expect(removeFilterFromQuery('label : "value" OR label2:"value2"', 'label', 'value')).toBe('label2:"value2"');
expect(removeFilterFromQuery('test:"test" OR label:"value" AND label2:"value2"', 'label', 'value')).toBe(
'test:"test" OR label2:"value2"'
);
expect(removeFilterFromQuery('test:"test" OR (label:"value" AND label2:"value2")', 'label', 'value')).toBe(
'test:"test" OR label2:"value2"'
);
expect(removeFilterFromQuery('(test:"test" OR label:"value") AND label2:"value2"', 'label', 'value')).toBe(
'(test:"test") AND label2:"value2"'
);
expect(removeFilterFromQuery('(test:"test" OR label:"value") AND label2:"value2"', 'test', 'test')).toBe(
'label:"value" AND label2:"value2"'
);
expect(removeFilterFromQuery('test:"test" OR (label:"value" AND label2:"value2")', 'label2', 'value2')).toBe(
'test:"test" OR (label:"value")'
);
});
it('should not remove the wrong filter', () => {
expect(removeFilterFromQuery('-label:"value" AND label2:"value2"', 'label', 'value')).toBe(
'-label:"value" AND label2:"value2"'
);
expect(removeFilterFromQuery('label2:"value2" OR -label:value', 'label', 'value')).toBe(
'label2:"value2" OR -label:value'
);
expect(removeFilterFromQuery('-label : "value" OR label2:"value2"', 'label', 'value')).toBe(
'-label : "value" OR label2:"value2"'
);
});
it('should support filters with colons', () => {
expect(removeFilterFromQuery('label\\:name:"value"', 'label:name', 'value')).toBe('');
});
it('should support filters with quotes', () => {
expect(removeFilterFromQuery('label\\:name:"the \\"value\\""', 'label:name', 'the "value"')).toBe('');
});
});
Log Rows: Added popover menu with filter options when a log line is selected (#75306) * LogRow: detect text selection * LogRow: refactor menu as component * LogRow: add actions to menu * LogRow: hack menu position * Remove unsused imports * LogRowMessage: remove popover code * PopoverMenu: refactor * LogRows: implement PopoverMenu at log rows level * PopoverMenu: implement copy * PopoverMenu: receive row model * PopoverMenu: fix onClick capture issue * Explore: add new filter methods and props for line filters * PopoverMenu: use new filter props * Explore: separate toggleable and non toggleable filters * PopoverMenu: improve copy * ModifyQuery: extend line filter with value argument * PopoverMenu: close with escape * Remove unused import * Prettier * PopoverMenu: remove label filter options * LogRow: rename text selection handling prop * Update test * Remove unused import * Popover menu: add unit test * LogRows: update unit test * Log row: hide the log row menu if the user is selecting text * Log row: dont hide row menu if popover is not in scope * Log rows: rename state variable * Popover menu: allow menu to scroll * Log rows: fix classname prop * Log rows: close popover if mouse event comes from outside the log rows * Declare new class using object style * Fix style declaration * Logs Popover Menu: add string filtering functions (#76757) * Loki modifyQuery: add line does not contain query modification * Elastic modifyQuery: implement line filters * Modify query: change action name to not be loki specific * Prettier * Prettier * Elastic: escape filter values * Popover menu: create feature flag * Log Rows: integrate logsRowsPopoverMenu flag * Rename feature flag * Popover menu: track interactions * Prettier * logRowsPopoverMenu: update stage * Popover menu: add ds type to tracking data * Log rows: move feature flag check * Improve handle deselection
2023-11-16 17:48:10 +08:00
describe('addStringFilterToQuery', () => {
it('should add a positive filter to a query', () => {
expect(addStringFilterToQuery('label:"value"', 'filter')).toBe('label:"value" AND "filter"');
expect(addStringFilterToQuery('', 'filter')).toBe('"filter"');
expect(addStringFilterToQuery(' ', 'filter')).toBe('"filter"');
});
it('should add a negative filter to a query', () => {
expect(addStringFilterToQuery('label:"value"', 'filter', false)).toBe('label:"value" NOT "filter"');
expect(addStringFilterToQuery('', 'filter', false)).toBe('NOT "filter"');
expect(addStringFilterToQuery(' ', 'filter', false)).toBe('NOT "filter"');
});
it('should escape filter values', () => {
expect(addStringFilterToQuery('label:"value"', '"filter"')).toBe('label:"value" AND "\\"filter\\""');
expect(addStringFilterToQuery('label:"value"', '"filter"', false)).toBe('label:"value" NOT "\\"filter\\""');
});
it('should escape filter values with backslashes', () => {
expect(addStringFilterToQuery('label:"value"', '"filter with \\"')).toBe(
'label:"value" AND "\\"filter with \\\\\\""'
);
expect(addStringFilterToQuery('label:"value"', '"filter with \\"', false)).toBe(
'label:"value" NOT "\\"filter with \\\\\\""'
);
});
Log Rows: Added popover menu with filter options when a log line is selected (#75306) * LogRow: detect text selection * LogRow: refactor menu as component * LogRow: add actions to menu * LogRow: hack menu position * Remove unsused imports * LogRowMessage: remove popover code * PopoverMenu: refactor * LogRows: implement PopoverMenu at log rows level * PopoverMenu: implement copy * PopoverMenu: receive row model * PopoverMenu: fix onClick capture issue * Explore: add new filter methods and props for line filters * PopoverMenu: use new filter props * Explore: separate toggleable and non toggleable filters * PopoverMenu: improve copy * ModifyQuery: extend line filter with value argument * PopoverMenu: close with escape * Remove unused import * Prettier * PopoverMenu: remove label filter options * LogRow: rename text selection handling prop * Update test * Remove unused import * Popover menu: add unit test * LogRows: update unit test * Log row: hide the log row menu if the user is selecting text * Log row: dont hide row menu if popover is not in scope * Log rows: rename state variable * Popover menu: allow menu to scroll * Log rows: fix classname prop * Log rows: close popover if mouse event comes from outside the log rows * Declare new class using object style * Fix style declaration * Logs Popover Menu: add string filtering functions (#76757) * Loki modifyQuery: add line does not contain query modification * Elastic modifyQuery: implement line filters * Modify query: change action name to not be loki specific * Prettier * Prettier * Elastic: escape filter values * Popover menu: create feature flag * Log Rows: integrate logsRowsPopoverMenu flag * Rename feature flag * Popover menu: track interactions * Prettier * logRowsPopoverMenu: update stage * Popover menu: add ds type to tracking data * Log rows: move feature flag check * Improve handle deselection
2023-11-16 17:48:10 +08:00
});