mirror of https://github.com/grafana/grafana.git
				
				
				
			Reorder cipher suites for better security (#22101)
Put the cipher suites with Forward Secrecy at or nearer the top, keeping any TLS v1.3 suites at the top, following best practice guides for the ordering of the rest. There is no change to the selection of suites only reordering.
This commit is contained in:
		
							parent
							
								
									37aa584a54
								
							
						
					
					
						commit
						39e0ce305b
					
				|  | @ -193,18 +193,18 @@ func (hs *HTTPServer) configureHttps() error { | ||||||
| 		MinVersion:               tls.VersionTLS12, | 		MinVersion:               tls.VersionTLS12, | ||||||
| 		PreferServerCipherSuites: true, | 		PreferServerCipherSuites: true, | ||||||
| 		CipherSuites: []uint16{ | 		CipherSuites: []uint16{ | ||||||
| 			tls.TLS_RSA_WITH_AES_128_CBC_SHA, | 			tls.TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256, | ||||||
| 			tls.TLS_RSA_WITH_AES_256_CBC_SHA, | 			tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, | ||||||
|  | 			tls.TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384, | ||||||
|  | 			tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, | ||||||
|  | 			tls.TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA, | ||||||
|  | 			tls.TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA, | ||||||
|  | 			tls.TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA, | ||||||
|  | 			tls.TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA, | ||||||
| 			tls.TLS_RSA_WITH_AES_128_GCM_SHA256, | 			tls.TLS_RSA_WITH_AES_128_GCM_SHA256, | ||||||
| 			tls.TLS_RSA_WITH_AES_256_GCM_SHA384, | 			tls.TLS_RSA_WITH_AES_256_GCM_SHA384, | ||||||
| 			tls.TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA, | 			tls.TLS_RSA_WITH_AES_128_CBC_SHA, | ||||||
| 			tls.TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA, | 			tls.TLS_RSA_WITH_AES_256_CBC_SHA, | ||||||
| 			tls.TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA, |  | ||||||
| 			tls.TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA, |  | ||||||
| 			tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, |  | ||||||
| 			tls.TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256, |  | ||||||
| 			tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, |  | ||||||
| 			tls.TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384, |  | ||||||
| 		}, | 		}, | ||||||
| 	} | 	} | ||||||
| 
 | 
 | ||||||
|  | @ -238,12 +238,12 @@ func (hs *HTTPServer) configureHttp2() error { | ||||||
| 			tls.TLS_CHACHA20_POLY1305_SHA256, | 			tls.TLS_CHACHA20_POLY1305_SHA256, | ||||||
| 			tls.TLS_AES_128_GCM_SHA256, | 			tls.TLS_AES_128_GCM_SHA256, | ||||||
| 			tls.TLS_AES_256_GCM_SHA384, | 			tls.TLS_AES_256_GCM_SHA384, | ||||||
| 			tls.TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305, |  | ||||||
| 			tls.TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256, | 			tls.TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256, | ||||||
| 			tls.TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384, |  | ||||||
| 			tls.TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305, |  | ||||||
| 			tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, | 			tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, | ||||||
|  | 			tls.TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384, | ||||||
| 			tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, | 			tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, | ||||||
|  | 			tls.TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305, | ||||||
|  | 			tls.TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305, | ||||||
| 		}, | 		}, | ||||||
| 		NextProtos: []string{"h2", "http/1.1"}, | 		NextProtos: []string{"h2", "http/1.1"}, | ||||||
| 	} | 	} | ||||||
|  |  | ||||||
		Loading…
	
		Reference in New Issue