root
/
grafana
mirror of https://github.com/grafana/grafana.git
1
0
Fork 0
Code Issues Actions 30 Packages Projects Releases Wiki Activity

Skip flaky test (#45785)

This commit is contained in:
Sofia Papagiannaki 2022-02-23 17:56:21 +02:00 committed by GitHub
parent ce4bba888c
commit 3cfbbbdbf2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/services/sqlstore/migrations/migrations_test.go
View File

@ -155,6 +155,11 @@ func TestMigrationLock(t *testing.T) {
func TestMigratorLocking(t *testing.T) { func TestMigratorLocking(t *testing.T) {
dbType := getDBType() dbType := getDBType()
testDB := getTestDB(t, dbType) testDB := getTestDB(t, dbType)
// skip for SQLite for now since it occasionally fails for not clear reason
// anyway starting migrations concurretly for the same migrator is impossible use case
if dbType == SQLite {
t.Skip()
}
x, err := xorm.NewEngine(testDB.DriverName, testDB.ConnStr) x, err := xorm.NewEngine(testDB.DriverName, testDB.ConnStr)
require.NoError(t, err) require.NoError(t, err)
@ -181,7 +186,7 @@ func TestMigratorLocking(t *testing.T) {
}) })
} }
}) })
assert.Equal(t, int64(1), errorNum) assert.Equal(t, int64(1), atomic.LoadInt64(&errorNum))
} }
func TestDatabaseLocking(t *testing.T) { func TestDatabaseLocking(t *testing.T) {