diff --git a/public/app/plugins/datasource/grafana-azure-monitor-datasource/components/LogsQueryEditor/LogsQueryEditor.tsx b/public/app/plugins/datasource/grafana-azure-monitor-datasource/components/LogsQueryEditor/LogsQueryEditor.tsx index d81ac96920b..1e77997c5c4 100644 --- a/public/app/plugins/datasource/grafana-azure-monitor-datasource/components/LogsQueryEditor/LogsQueryEditor.tsx +++ b/public/app/plugins/datasource/grafana-azure-monitor-datasource/components/LogsQueryEditor/LogsQueryEditor.tsx @@ -1,6 +1,6 @@ import React from 'react'; -import { Alert, InlineFieldRow } from '@grafana/ui'; +import { Alert } from '@grafana/ui'; import Datasource from '../../datasource'; import { AzureMonitorErrorish, AzureMonitorOption, AzureMonitorQuery } from '../../types'; @@ -35,24 +35,22 @@ const LogsQueryEditor: React.FC = ({ return (
- - - + ); - const resourcePickerButton = await screen.findByRole('button', { name: /grafanastaging/ }); + const resourcePickerButton = await screen.findByRole('button', { name: /grafana/ }); expect(screen.getByText('Microsoft.Compute/virtualMachines')).toBeInTheDocument(); expect(screen.getByText('Metric A')).toBeInTheDocument(); diff --git a/public/app/plugins/datasource/grafana-azure-monitor-datasource/components/NewMetricsQueryEditor/MetricsQueryEditor.tsx b/public/app/plugins/datasource/grafana-azure-monitor-datasource/components/NewMetricsQueryEditor/MetricsQueryEditor.tsx index a0ce1ff4a52..22f85cedc63 100644 --- a/public/app/plugins/datasource/grafana-azure-monitor-datasource/components/NewMetricsQueryEditor/MetricsQueryEditor.tsx +++ b/public/app/plugins/datasource/grafana-azure-monitor-datasource/components/NewMetricsQueryEditor/MetricsQueryEditor.tsx @@ -1,9 +1,10 @@ +import { css } from '@emotion/css'; import React from 'react'; import { PanelData } from '@grafana/data/src/types'; import { EditorRows, EditorRow, EditorFieldGroup } from '@grafana/experimental'; import { config } from '@grafana/runtime'; -import { InlineFieldRow } from '@grafana/ui'; +import { InlineFieldRow, useStyles2 } from '@grafana/ui'; import type Datasource from '../../datasource'; import type { AzureMonitorQuery, AzureMonitorOption, AzureMonitorErrorish } from '../../types'; @@ -37,6 +38,8 @@ const MetricsQueryEditor: React.FC = ({ onChange, setError, }) => { + const styles = useStyles2(getStyles); + const metricsMetadata = useMetricMetadata(query, datasource, onChange); const metricNamespaces = useMetricNamespaces(query, datasource, onChange, setError); const metricNames = useMetricNames(query, datasource, onChange, setError); @@ -141,7 +144,7 @@ const MetricsQueryEditor: React.FC = ({ } else { return (
- + = ({ /> - + = ({ setError={setError} /> - + = ({ } }; +const getStyles = () => ({ + row: css({ + rowGap: 0, + }), +}); + export default MetricsQueryEditor; diff --git a/public/app/plugins/datasource/grafana-azure-monitor-datasource/components/ResourceField/ResourceField.tsx b/public/app/plugins/datasource/grafana-azure-monitor-datasource/components/ResourceField/ResourceField.tsx index 2a2bb98b879..20e5bbc01aa 100644 --- a/public/app/plugins/datasource/grafana-azure-monitor-datasource/components/ResourceField/ResourceField.tsx +++ b/public/app/plugins/datasource/grafana-azure-monitor-datasource/components/ResourceField/ResourceField.tsx @@ -1,16 +1,15 @@ -import { css } from '@emotion/css'; +import { cx } from '@emotion/css'; import React, { useCallback, useEffect, useState } from 'react'; -import { GrafanaTheme2 } from '@grafana/data'; import { Button, Icon, Modal, useStyles2 } from '@grafana/ui'; import Datasource from '../../datasource'; import { AzureQueryEditorFieldProps, AzureMonitorQuery, AzureResourceSummaryItem } from '../../types'; import { Field } from '../Field'; import ResourcePicker from '../ResourcePicker'; +import getStyles from '../ResourcePicker/styles'; import { ResourceRowType } from '../ResourcePicker/types'; import { parseResourceURI } from '../ResourcePicker/utils'; -import { Space } from '../Space'; function parseResourceDetails(resourceURI: string) { const parsed = parseResourceURI(resourceURI); @@ -80,7 +79,7 @@ const ResourceField: React.FC = ({ - @@ -128,37 +127,27 @@ interface FormattedResourceProps { } const FormattedResource = ({ resource }: FormattedResourceProps) => { + const styles = useStyles2(getStyles); + + if (resource.resourceName) { + return ( + + {resource.resourceName} + + ); + } + if (resource.resourceGroupName) { + return ( + + {resource.resourceGroupName} + + ); + } return ( {resource.subscriptionName} - {resource.resourceGroupName && ( - <> - - {resource.resourceGroupName} - - )} - {resource.resourceName && ( - <> - - {resource.resourceName} - - )} ); }; -const Separator = () => ( - <> - - {'/'} - - -); - export default ResourceField; - -const getStyles = (theme: GrafanaTheme2) => ({ - modal: css({ - width: theme.breakpoints.values.lg, - }), -}); diff --git a/public/app/plugins/datasource/grafana-azure-monitor-datasource/components/ResourcePicker/styles.ts b/public/app/plugins/datasource/grafana-azure-monitor-datasource/components/ResourcePicker/styles.ts index 51db0d61820..ecc2992500b 100644 --- a/public/app/plugins/datasource/grafana-azure-monitor-datasource/components/ResourcePicker/styles.ts +++ b/public/app/plugins/datasource/grafana-azure-monitor-datasource/components/ResourcePicker/styles.ts @@ -66,6 +66,16 @@ const getStyles = (theme: GrafanaTheme2) => ({ whiteSpace: 'nowrap', }), + resourceField: css({ + maxWidth: theme.spacing(36), + overflow: 'hidden', + }), + + resourceFieldButton: css({ + padding: '7px', + textAlign: 'left', + }), + nestedRowCheckbox: css({ zIndex: 0, }), @@ -88,6 +98,10 @@ const getStyles = (theme: GrafanaTheme2) => ({ margin: '4px 0', fontStyle: 'italic', }), + + modal: css({ + width: theme.breakpoints.values.lg, + }), }); export default getStyles;