root
/
grafana
mirror of https://github.com/grafana/grafana.git
1
0
Fork 0
Code Issues Actions 90 Packages Projects Releases Wiki Activity

sql: make sure queries do not have fill-params (#81576)

This commit is contained in:
Gábor Farkas 2024-02-05 08:08:35 +01:00 committed by GitHub
parent 202eecccbc
commit 8175b31e16
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/tsdb/sqleng/sql_engine.go
View File

@ -175,6 +175,13 @@ func (e *DataSourceHandler) QueryData(ctx context.Context, req *backend.QueryDat
if err != nil { if err != nil {
return nil, fmt.Errorf("error unmarshal query json: %w", err) return nil, fmt.Errorf("error unmarshal query json: %w", err)
} }
// the fill-params are only stored inside this function, during query-interpolation. we do not support
// sending them in "from the outside"
if queryjson.Fill || queryjson.FillInterval != 0.0 || queryjson.FillMode != "" || queryjson.FillValue != 0.0 {
return nil, fmt.Errorf("query fill-parameters not supported")
}
if queryjson.RawSql == "" { if queryjson.RawSql == "" {
continue continue
} }