root
/
grafana
mirror of https://github.com/grafana/grafana.git
1
0
Fork 0
Code Issues Actions 253 Packages Projects Releases Wiki Activity

Expression: Fix a bug of the display name of the threshold expression result (#85912) 

* replace ReferenceVar with RefID when creating the math command for the ThresholdCommand

* Fix the Hysteresis test
This commit is contained in:
Faye Lin 2024-04-12 23:46:14 +08:00 committed by GitHub
parent 10c6ab5a17
commit a94ab259c6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/expr/hysteresis_test.go
View File

@ -15,7 +15,7 @@ import (
func TestHysteresisExecute(t *testing.T) { func TestHysteresisExecute(t *testing.T) {
number := func(label string, value float64) mathexp.Number { number := func(label string, value float64) mathexp.Number {
n := mathexp.NewNumber("A", data.Labels{"label": label}) n := mathexp.NewNumber("B", data.Labels{"label": label})
n.SetValue(&value) n.SetValue(&value)
return n return n
} }

2
pkg/expr/threshold.go
View File

@ -120,7 +120,7 @@ func (tc *ThresholdCommand) Execute(ctx context.Context, now time.Time, vars mat
return mathexp.Results{}, err return mathexp.Results{}, err
} }
mathCommand, err := NewMathCommand(tc.ReferenceVar, mathExpression) mathCommand, err := NewMathCommand(tc.RefID, mathExpression)
if err != nil { if err != nil {
return mathexp.Results{}, err return mathexp.Results{}, err
} }