From c04027919b763c3010d6b46da6a96e6a3eefc421 Mon Sep 17 00:00:00 2001 From: Joao Silva <100691367+JoaoSilvaGrafana@users.noreply.github.com> Date: Thu, 3 Oct 2024 11:45:31 +0100 Subject: [PATCH] Bookmarks: Turn feature toggle on by default (#94194) --- .../configure-grafana/feature-toggles/index.md | 2 +- pkg/services/featuremgmt/registry.go | 3 ++- pkg/services/featuremgmt/toggles_gen.csv | 2 +- pkg/services/featuremgmt/toggles_gen.json | 12 ++++++++---- 4 files changed, 12 insertions(+), 7 deletions(-) diff --git a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md index 40fbc6d5e36..82fe792d360 100644 --- a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md +++ b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md @@ -74,6 +74,7 @@ Most [generally available](https://grafana.com/docs/release-life-cycle/#general- | `newDashboardSharingComponent` | Enables the new sharing drawer design | | | `notificationBanner` | Enables the notification banner UI and API | Yes | | `pluginProxyPreserveTrailingSlash` | Preserve plugin proxy trailing slash. | | +| `pinNavItems` | Enables pinning of nav items | Yes | | `openSearchBackendFlowEnabled` | Enables the backend query flow for Open Search datasource plugin | Yes | | `cloudWatchRoundUpEndTime` | Round up end time for metric queries to the next minute to avoid missing data | Yes | @@ -190,7 +191,6 @@ Experimental features might be changed or removed without prior notice. | `alertingListViewV2` | Enables the new alert list view design | | `dashboardRestore` | Enables deleted dashboard restore feature (backend only) | | `alertingCentralAlertHistory` | Enables the new central alert history. | -| `pinNavItems` | Enables pinning of nav items | | `failWrongDSUID` | Throws an error if a datasource has an invalid UIDs | | `alertingApiServer` | Register Alerting APIs with the K8s API server | | `dashboardRestoreUI` | Enables the frontend to be able to restore a recently deleted dashboard | diff --git a/pkg/services/featuremgmt/registry.go b/pkg/services/featuremgmt/registry.go index cfc855564cb..040fae2c88a 100644 --- a/pkg/services/featuremgmt/registry.go +++ b/pkg/services/featuremgmt/registry.go @@ -1303,8 +1303,9 @@ var ( { Name: "pinNavItems", Description: "Enables pinning of nav items", - Stage: FeatureStageExperimental, + Stage: FeatureStageGeneralAvailability, Owner: grafanaFrontendPlatformSquad, + Expression: "true", // enabled by default }, { Name: "authZGRPCServer", diff --git a/pkg/services/featuremgmt/toggles_gen.csv b/pkg/services/featuremgmt/toggles_gen.csv index b9a5d9c3104..2be708e1aa2 100644 --- a/pkg/services/featuremgmt/toggles_gen.csv +++ b/pkg/services/featuremgmt/toggles_gen.csv @@ -170,7 +170,7 @@ preserveDashboardStateWhenNavigating,experimental,@grafana/dashboards-squad,fals alertingCentralAlertHistory,experimental,@grafana/alerting-squad,false,false,true pluginProxyPreserveTrailingSlash,GA,@grafana/plugins-platform-backend,false,false,false azureMonitorPrometheusExemplars,preview,@grafana/partner-datasources,false,false,false -pinNavItems,experimental,@grafana/grafana-frontend-platform,false,false,false +pinNavItems,GA,@grafana/grafana-frontend-platform,false,false,false authZGRPCServer,experimental,@grafana/identity-access-team,false,false,false openSearchBackendFlowEnabled,GA,@grafana/aws-datasources,false,false,false ssoSettingsLDAP,experimental,@grafana/identity-access-team,false,false,false diff --git a/pkg/services/featuremgmt/toggles_gen.json b/pkg/services/featuremgmt/toggles_gen.json index 5778da92976..5ae6b05eb1e 100644 --- a/pkg/services/featuremgmt/toggles_gen.json +++ b/pkg/services/featuremgmt/toggles_gen.json @@ -2280,13 +2280,17 @@ { "metadata": { "name": "pinNavItems", - "resourceVersion": "1718727528075", - "creationTimestamp": "2024-06-10T11:40:03Z" + "resourceVersion": "1727948775526", + "creationTimestamp": "2024-06-10T11:40:03Z", + "annotations": { + "grafana.app/updatedTimestamp": "2024-10-03 09:46:15.526594 +0000 UTC" + } }, "spec": { "description": "Enables pinning of nav items", - "stage": "experimental", - "codeowner": "@grafana/grafana-frontend-platform" + "stage": "GA", + "codeowner": "@grafana/grafana-frontend-platform", + "expression": "true" } }, {