mirror of https://github.com/grafana/grafana.git
Graphite: Backend querying improvements (#111549)
This commit is contained in:
parent
bb7358be29
commit
ed7163a26f
|
|
@ -85,7 +85,7 @@ func TestIntegrationGraphite(t *testing.T) {
|
|||
// nolint:gosec
|
||||
resp, err := http.Post(u, "application/json", buf1)
|
||||
require.NoError(t, err)
|
||||
require.Equal(t, http.StatusInternalServerError, resp.StatusCode)
|
||||
require.Equal(t, http.StatusBadRequest, resp.StatusCode)
|
||||
t.Cleanup(func() {
|
||||
err := resp.Body.Close()
|
||||
require.NoError(t, err)
|
||||
|
|
|
|||
|
|
@ -100,7 +100,7 @@ func (s *Service) CallResource(ctx context.Context, req *backend.CallResourceReq
|
|||
func (s *Service) createRequest(ctx context.Context, dsInfo *datasourceInfo, params URLParams) (*http.Request, error) {
|
||||
u, err := url.Parse(dsInfo.URL)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
return nil, backend.DownstreamError(err)
|
||||
}
|
||||
|
||||
if params.SubPath != "" {
|
||||
|
|
@ -125,7 +125,7 @@ func (s *Service) createRequest(ctx context.Context, dsInfo *datasourceInfo, par
|
|||
req, err := http.NewRequestWithContext(ctx, method, u.String(), params.Body)
|
||||
if err != nil {
|
||||
s.logger.Info("Failed to create request", "error", err)
|
||||
return nil, fmt.Errorf("failed to create request: %w", err)
|
||||
return nil, backend.PluginError(fmt.Errorf("failed to create request: %w", err))
|
||||
}
|
||||
|
||||
for k, v := range params.Headers {
|
||||
|
|
|
|||
|
|
@ -42,7 +42,7 @@ func (rt *healthCheckFailRoundTripper) RoundTrip(req *http.Request) (*http.Respo
|
|||
Status: "400",
|
||||
StatusCode: 400,
|
||||
Header: nil,
|
||||
Body: nil,
|
||||
Body: io.NopCloser(strings.NewReader("this is a failed healthcheck")),
|
||||
ContentLength: 0,
|
||||
Request: req,
|
||||
}, nil
|
||||
|
|
@ -107,7 +107,7 @@ func Test_CheckHealth(t *testing.T) {
|
|||
assert.NoError(t, err)
|
||||
assert.Equal(t, backend.HealthStatusError, res.Status)
|
||||
assert.Equal(t, "Graphite health check failed. See details below", res.Message)
|
||||
assert.Equal(t, []byte("{\"verboseMessage\": \"request failed, status: 400\" }"), res.JSONDetails)
|
||||
assert.Equal(t, []byte("{\"verboseMessage\": \"request failed with error: this is a failed healthcheck\" }"), res.JSONDetails)
|
||||
})
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -16,8 +16,10 @@ import (
|
|||
"github.com/grafana/grafana-plugin-sdk-go/backend"
|
||||
"github.com/grafana/grafana-plugin-sdk-go/backend/tracing"
|
||||
"github.com/grafana/grafana-plugin-sdk-go/data"
|
||||
"github.com/grafana/grafana-plugin-sdk-go/experimental/errorsource"
|
||||
"go.opentelemetry.io/otel/attribute"
|
||||
"go.opentelemetry.io/otel/codes"
|
||||
"golang.org/x/net/html"
|
||||
)
|
||||
|
||||
func (s *Service) RunQuery(ctx context.Context, req *backend.QueryDataRequest, dsInfo *datasourceInfo) (*backend.QueryDataResponse, error) {
|
||||
|
|
@ -26,10 +28,13 @@ func (s *Service) RunQuery(ctx context.Context, req *backend.QueryDataRequest, d
|
|||
req *http.Request
|
||||
formData url.Values
|
||||
}{}
|
||||
result := backend.NewQueryDataResponse()
|
||||
|
||||
for _, query := range req.Queries {
|
||||
graphiteReq, formData, emptyQuery, err := s.createGraphiteRequest(ctx, query, dsInfo)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
result.Responses[query.RefID] = backend.ErrorResponseWithErrorSource(err)
|
||||
return result, nil
|
||||
}
|
||||
|
||||
if emptyQuery != nil {
|
||||
|
|
@ -46,7 +51,6 @@ func (s *Service) RunQuery(ctx context.Context, req *backend.QueryDataRequest, d
|
|||
}
|
||||
}
|
||||
|
||||
var result = backend.QueryDataResponse{}
|
||||
if len(emptyQueries) != 0 {
|
||||
s.logger.Warn("Found query models without targets", "models without targets", strings.Join(emptyQueries, "\n"))
|
||||
// If no queries had a valid target, return an error; otherwise, attempt with the targets we have
|
||||
|
|
@ -56,9 +60,9 @@ func (s *Service) RunQuery(ctx context.Context, req *backend.QueryDataRequest, d
|
|||
}
|
||||
// marking this downstream error as it is a user error, but arguably this is a plugin error
|
||||
// since the plugin should have frontend validation that prevents us from getting into this state
|
||||
missingQueryResponse := backend.ErrDataResponseWithSource(400, backend.ErrorSourceDownstream, "no query target found for the alert rule")
|
||||
missingQueryResponse := backend.ErrDataResponseWithSource(400, backend.ErrorSourceDownstream, "no query target found")
|
||||
result.Responses["A"] = missingQueryResponse
|
||||
return &result, nil
|
||||
return result, nil
|
||||
}
|
||||
}
|
||||
|
||||
|
|
@ -83,7 +87,8 @@ func (s *Service) RunQuery(ctx context.Context, req *backend.QueryDataRequest, d
|
|||
if err != nil {
|
||||
span.RecordError(err)
|
||||
span.SetStatus(codes.Error, err.Error())
|
||||
return &result, err
|
||||
result.Responses[refId] = backend.ErrorResponseWithErrorSource(backend.DownstreamError(err))
|
||||
return result, nil
|
||||
}
|
||||
|
||||
defer func() {
|
||||
|
|
@ -97,16 +102,13 @@ func (s *Service) RunQuery(ctx context.Context, req *backend.QueryDataRequest, d
|
|||
if err != nil {
|
||||
span.RecordError(err)
|
||||
span.SetStatus(codes.Error, err.Error())
|
||||
return &result, err
|
||||
result.Responses[refId] = backend.ErrorResponseWithErrorSource(err)
|
||||
return result, nil
|
||||
}
|
||||
|
||||
frames = append(frames, queryFrames...)
|
||||
}
|
||||
|
||||
result = backend.QueryDataResponse{
|
||||
Responses: make(backend.Responses),
|
||||
}
|
||||
|
||||
for _, f := range frames {
|
||||
if resp, ok := result.Responses[f.Name]; ok {
|
||||
resp.Frames = append(resp.Frames, f)
|
||||
|
|
@ -118,7 +120,7 @@ func (s *Service) RunQuery(ctx context.Context, req *backend.QueryDataRequest, d
|
|||
}
|
||||
}
|
||||
|
||||
return &result, nil
|
||||
return result, nil
|
||||
}
|
||||
|
||||
// processQuery converts a Graphite data source query to a Graphite query target. It returns the target,
|
||||
|
|
@ -127,7 +129,7 @@ func (s *Service) processQuery(query backend.DataQuery) (string, *GraphiteQuery,
|
|||
queryJSON := GraphiteQuery{}
|
||||
err := json.Unmarshal(query.JSON, &queryJSON)
|
||||
if err != nil {
|
||||
return "", &queryJSON, false, fmt.Errorf("failed to decode the Graphite query: %w", err)
|
||||
return "", &queryJSON, false, backend.PluginError(fmt.Errorf("failed to decode the Graphite query: %w", err))
|
||||
}
|
||||
s.logger.Debug("Graphite", "query", queryJSON)
|
||||
currTarget := queryJSON.TargetFull
|
||||
|
|
@ -237,7 +239,7 @@ func (s *Service) toDataFrames(response *http.Response, refId string) (frames da
|
|||
func (s *Service) parseResponse(res *http.Response) ([]TargetResponseDTO, error) {
|
||||
body, err := io.ReadAll(res.Body)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
return nil, backend.DownstreamError(err)
|
||||
}
|
||||
defer func() {
|
||||
if err := res.Body.Close(); err != nil {
|
||||
|
|
@ -246,20 +248,50 @@ func (s *Service) parseResponse(res *http.Response) ([]TargetResponseDTO, error)
|
|||
}()
|
||||
|
||||
if res.StatusCode/100 != 2 {
|
||||
s.logger.Info("Request failed", "status", res.Status, "body", string(body))
|
||||
return nil, fmt.Errorf("request failed, status: %s", res.Status)
|
||||
graphiteError := parseGraphiteError(res.StatusCode, string(body))
|
||||
s.logger.Info("Request failed", "status", res.Status, "error", graphiteError, "body", string(body))
|
||||
return nil, errorsource.SourceError(backend.ErrorSourceFromHTTPStatus(res.StatusCode), fmt.Errorf("request failed with error: %s", graphiteError), false)
|
||||
}
|
||||
|
||||
var data []TargetResponseDTO
|
||||
err = json.Unmarshal(body, &data)
|
||||
if err != nil {
|
||||
s.logger.Info("Failed to unmarshal graphite response", "error", err, "status", res.Status, "body", string(body))
|
||||
return nil, err
|
||||
return nil, backend.DownstreamError(err)
|
||||
}
|
||||
|
||||
return data, nil
|
||||
}
|
||||
|
||||
/**
|
||||
* Duplicated from the frontend.
|
||||
* Graphite-web before v1.6 returns HTTP 500 with full stack traces in an HTML page
|
||||
* when a query fails. It results in massive error alerts with HTML tags in the UI.
|
||||
* This function removes all HTML tags and keeps only the last line from the stack
|
||||
* trace which should be the most meaningful.
|
||||
*/
|
||||
func parseGraphiteError(status int, body string) (errorMsg string) {
|
||||
errorMsg = body
|
||||
if status == http.StatusInternalServerError {
|
||||
if strings.HasPrefix(body, "<body") {
|
||||
htmlErrorMsg := ""
|
||||
tokenizer := html.NewTokenizer(strings.NewReader(body))
|
||||
// Break here as that typically means we've reached EOF
|
||||
for tokenizer.Next() != html.ErrorToken {
|
||||
token := tokenizer.Token()
|
||||
if token.Type == html.TextToken {
|
||||
trimmed := strings.TrimSpace(token.Data)
|
||||
if trimmed != "" {
|
||||
htmlErrorMsg += html.UnescapeString(trimmed) + "\n"
|
||||
}
|
||||
}
|
||||
}
|
||||
errorMsg = strings.TrimSpace(htmlErrorMsg)
|
||||
}
|
||||
}
|
||||
return errorMsg
|
||||
}
|
||||
|
||||
func fixIntervalFormat(target string) string {
|
||||
rMinute := regexp.MustCompile(`'(\d+)m'`)
|
||||
target = rMinute.ReplaceAllStringFunc(target, func(m string) string {
|
||||
|
|
|
|||
|
|
@ -3,6 +3,7 @@ package graphite
|
|||
import (
|
||||
"context"
|
||||
"encoding/json"
|
||||
"fmt"
|
||||
"io"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
|
|
@ -14,6 +15,7 @@ import (
|
|||
"github.com/grafana/grafana-plugin-sdk-go/backend"
|
||||
"github.com/grafana/grafana-plugin-sdk-go/backend/httpclient"
|
||||
"github.com/grafana/grafana-plugin-sdk-go/data"
|
||||
"github.com/grafana/grafana-plugin-sdk-go/experimental"
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
"go.opentelemetry.io/otel/trace/noop"
|
||||
|
|
@ -99,7 +101,7 @@ func TestProcessQuery(t *testing.T) {
|
|||
Queries: queries,
|
||||
})
|
||||
assert.NoError(t, err)
|
||||
expectedResponse := backend.ErrDataResponseWithSource(400, backend.ErrorSourceDownstream, "no query target found for the alert rule")
|
||||
expectedResponse := backend.ErrDataResponseWithSource(400, backend.ErrorSourceDownstream, "no query target found")
|
||||
assert.Equal(t, expectedResponse, rsp.Responses["A"])
|
||||
})
|
||||
|
||||
|
|
@ -115,13 +117,14 @@ func TestProcessQuery(t *testing.T) {
|
|||
|
||||
t.Run("QueryData happy path with service provider and plugin context", func(t *testing.T) {
|
||||
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
_, _ = w.Write([]byte(`[
|
||||
_, err := w.Write([]byte(`[
|
||||
{
|
||||
"target": "target A",
|
||||
"tags": { "fooTag": "fooValue", "barTag": "barValue", "int": 100, "float": 3.14 },
|
||||
"datapoints": [[50, 1], [null, 2], [100, 3]]
|
||||
}
|
||||
]`))
|
||||
require.NoError(t, err)
|
||||
}))
|
||||
t.Cleanup(server.Close)
|
||||
|
||||
|
|
@ -259,3 +262,444 @@ func TestFixIntervalFormat(t *testing.T) {
|
|||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestRunQueryE2E(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
serverResponse string
|
||||
serverStatus int
|
||||
queries []backend.DataQuery
|
||||
expectError bool
|
||||
errorContains string
|
||||
multipleTargets map[string]string
|
||||
}{
|
||||
{
|
||||
name: "successful single query with data",
|
||||
serverStatus: 200,
|
||||
serverResponse: `[
|
||||
{
|
||||
"target": "stats.counters.web.hits",
|
||||
"datapoints": [[100, 1609459200], [150, 1609459260], [120, 1609459320]]
|
||||
}
|
||||
]`,
|
||||
queries: []backend.DataQuery{
|
||||
{
|
||||
RefID: "A",
|
||||
TimeRange: backend.TimeRange{
|
||||
From: time.Unix(1609459200, 0),
|
||||
To: time.Unix(1609459320, 0),
|
||||
},
|
||||
MaxDataPoints: 1000,
|
||||
JSON: []byte(`{
|
||||
"target": "stats.counters.web.hits"
|
||||
}`),
|
||||
},
|
||||
},
|
||||
expectError: false,
|
||||
},
|
||||
{
|
||||
name: "successful single query with null values",
|
||||
serverStatus: 200,
|
||||
serverResponse: `[
|
||||
{
|
||||
"target": "stats.counters.web.hits",
|
||||
"datapoints": [[100, 1609459200], [null, 1609459260], [120, 1609459320]]
|
||||
}
|
||||
]`,
|
||||
queries: []backend.DataQuery{
|
||||
{
|
||||
RefID: "A",
|
||||
TimeRange: backend.TimeRange{
|
||||
From: time.Unix(1609459200, 0),
|
||||
To: time.Unix(1609459320, 0),
|
||||
},
|
||||
MaxDataPoints: 1000,
|
||||
JSON: []byte(`{
|
||||
"target": "stats.counters.web.hits"
|
||||
}`),
|
||||
},
|
||||
},
|
||||
expectError: false,
|
||||
},
|
||||
{
|
||||
name: "successful single query with tags",
|
||||
serverStatus: 200,
|
||||
serverResponse: `[
|
||||
{
|
||||
"target": "stats.counters.web.hits",
|
||||
"tags": {
|
||||
"host": "server1",
|
||||
"environment": "production",
|
||||
"port": 8080,
|
||||
"rate": 99.5
|
||||
},
|
||||
"datapoints": [[100, 1609459200], [150, 1609459260]]
|
||||
}
|
||||
]`,
|
||||
queries: []backend.DataQuery{
|
||||
{
|
||||
RefID: "A",
|
||||
TimeRange: backend.TimeRange{
|
||||
From: time.Unix(1609459200, 0),
|
||||
To: time.Unix(1609459260, 0),
|
||||
},
|
||||
MaxDataPoints: 1000,
|
||||
JSON: []byte(`{
|
||||
"target": "stats.counters.web.hits"
|
||||
}`),
|
||||
},
|
||||
},
|
||||
expectError: false,
|
||||
},
|
||||
{
|
||||
name: "successful multiple queries",
|
||||
serverStatus: 200,
|
||||
multipleTargets: map[string]string{
|
||||
"stats.counters.web.hits": `[
|
||||
{
|
||||
"target": "stats.counters.web.hits",
|
||||
"datapoints": [[100, 1609459200], [150, 1609459260]]
|
||||
}
|
||||
]`,
|
||||
"stats.counters.api.calls": `[
|
||||
{
|
||||
"target": "stats.counters.api.calls",
|
||||
"datapoints": [[50, 1609459200], [75, 1609459260]]
|
||||
}
|
||||
]`,
|
||||
},
|
||||
queries: []backend.DataQuery{
|
||||
{
|
||||
RefID: "A",
|
||||
TimeRange: backend.TimeRange{
|
||||
From: time.Unix(1609459200, 0),
|
||||
To: time.Unix(1609459260, 0),
|
||||
},
|
||||
MaxDataPoints: 1000,
|
||||
JSON: []byte(`{
|
||||
"target": "stats.counters.web.hits"
|
||||
}`),
|
||||
},
|
||||
{
|
||||
RefID: "B",
|
||||
TimeRange: backend.TimeRange{
|
||||
From: time.Unix(1609459200, 0),
|
||||
To: time.Unix(1609459260, 0),
|
||||
},
|
||||
MaxDataPoints: 1000,
|
||||
JSON: []byte(`{
|
||||
"target": "stats.counters.api.calls"
|
||||
}`),
|
||||
},
|
||||
},
|
||||
expectError: false,
|
||||
},
|
||||
{
|
||||
name: "query with empty target",
|
||||
serverStatus: 200,
|
||||
serverResponse: `[]`,
|
||||
queries: []backend.DataQuery{
|
||||
{
|
||||
RefID: "A",
|
||||
TimeRange: backend.TimeRange{
|
||||
From: time.Unix(1609459200, 0),
|
||||
To: time.Unix(1609459260, 0),
|
||||
},
|
||||
MaxDataPoints: 1000,
|
||||
JSON: []byte(`{
|
||||
"target": ""
|
||||
}`),
|
||||
},
|
||||
},
|
||||
expectError: true,
|
||||
errorContains: "no query target found",
|
||||
},
|
||||
{
|
||||
name: "mixed queries - some empty, some valid",
|
||||
serverStatus: 200,
|
||||
serverResponse: `[
|
||||
{
|
||||
"target": "stats.counters.web.hits",
|
||||
"datapoints": [[100, 1609459200], [150, 1609459260]]
|
||||
}
|
||||
]`,
|
||||
queries: []backend.DataQuery{
|
||||
{
|
||||
RefID: "A",
|
||||
TimeRange: backend.TimeRange{
|
||||
From: time.Unix(1609459200, 0),
|
||||
To: time.Unix(1609459260, 0),
|
||||
},
|
||||
MaxDataPoints: 1000,
|
||||
JSON: []byte(`{
|
||||
"target": ""
|
||||
}`),
|
||||
},
|
||||
{
|
||||
RefID: "B",
|
||||
TimeRange: backend.TimeRange{
|
||||
From: time.Unix(1609459200, 0),
|
||||
To: time.Unix(1609459260, 0),
|
||||
},
|
||||
MaxDataPoints: 1000,
|
||||
JSON: []byte(`{
|
||||
"target": "stats.counters.web.hits"
|
||||
}`),
|
||||
},
|
||||
},
|
||||
expectError: false,
|
||||
},
|
||||
{
|
||||
name: "server error response",
|
||||
serverStatus: 500,
|
||||
serverResponse: `{"error": "Internal server error"}`,
|
||||
queries: []backend.DataQuery{
|
||||
{
|
||||
RefID: "A",
|
||||
TimeRange: backend.TimeRange{
|
||||
From: time.Unix(1609459200, 0),
|
||||
To: time.Unix(1609459260, 0),
|
||||
},
|
||||
MaxDataPoints: 1000,
|
||||
JSON: []byte(`{
|
||||
"target": "stats.counters.web.hits"
|
||||
}`),
|
||||
},
|
||||
},
|
||||
expectError: true,
|
||||
errorContains: "request failed with error",
|
||||
},
|
||||
{
|
||||
name: "server error response with HTML content",
|
||||
serverStatus: 500,
|
||||
serverResponse: `<body>
|
||||
<h1>Internal Server Error</h1>
|
||||
<p>The server encountered an unexpected condition that prevented it from fulfilling the request.</p>
|
||||
<div>Error: Invalid metric path 'stats.invalid.metric'</div>
|
||||
Error: Target not found
|
||||
</body>`,
|
||||
queries: []backend.DataQuery{
|
||||
{
|
||||
RefID: "A",
|
||||
TimeRange: backend.TimeRange{
|
||||
From: time.Unix(1609459200, 0),
|
||||
To: time.Unix(1609459260, 0),
|
||||
},
|
||||
MaxDataPoints: 1000,
|
||||
JSON: []byte(`{
|
||||
"target": "stats.invalid.metric"
|
||||
}`),
|
||||
},
|
||||
},
|
||||
expectError: true,
|
||||
errorContains: "Error: Target not found", // Should parse HTML and extract the last meaningful line
|
||||
},
|
||||
{
|
||||
name: "malformed JSON response",
|
||||
serverStatus: 200,
|
||||
serverResponse: `[{invalid json}]`,
|
||||
queries: []backend.DataQuery{
|
||||
{
|
||||
RefID: "A",
|
||||
TimeRange: backend.TimeRange{
|
||||
From: time.Unix(1609459200, 0),
|
||||
To: time.Unix(1609459260, 0),
|
||||
},
|
||||
MaxDataPoints: 1000,
|
||||
JSON: []byte(`{
|
||||
"target": "stats.counters.web.hits"
|
||||
}`),
|
||||
},
|
||||
},
|
||||
expectError: true,
|
||||
},
|
||||
{
|
||||
name: "invalid query JSON",
|
||||
serverStatus: 200,
|
||||
serverResponse: `[]`,
|
||||
queries: []backend.DataQuery{
|
||||
{
|
||||
RefID: "A",
|
||||
TimeRange: backend.TimeRange{
|
||||
From: time.Unix(1609459200, 0),
|
||||
To: time.Unix(1609459260, 0),
|
||||
},
|
||||
MaxDataPoints: 1000,
|
||||
JSON: []byte(`{invalid json}`),
|
||||
},
|
||||
},
|
||||
expectError: true,
|
||||
errorContains: "failed to decode the Graphite query",
|
||||
},
|
||||
{
|
||||
name: "interval format transformation",
|
||||
serverStatus: 200,
|
||||
serverResponse: `[
|
||||
{
|
||||
"target": "hitcount(stats.counters.web.hits, '1min')",
|
||||
"datapoints": [[100, 1609459200], [150, 1609459260]]
|
||||
}
|
||||
]`,
|
||||
queries: []backend.DataQuery{
|
||||
{
|
||||
RefID: "A",
|
||||
TimeRange: backend.TimeRange{
|
||||
From: time.Unix(1609459200, 0),
|
||||
To: time.Unix(1609459260, 0),
|
||||
},
|
||||
MaxDataPoints: 1000,
|
||||
JSON: []byte(`{
|
||||
"target": "hitcount(stats.counters.web.hits, '1m')"
|
||||
}`),
|
||||
},
|
||||
},
|
||||
expectError: false,
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
testName := strings.ReplaceAll(tt.name, " ", "_")
|
||||
|
||||
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
err := r.ParseForm()
|
||||
require.NoError(t, err)
|
||||
|
||||
// Choose response based on target for multiple queries
|
||||
response := tt.serverResponse
|
||||
if tt.multipleTargets != nil {
|
||||
target := r.FormValue("target")
|
||||
if targetResponse, ok := tt.multipleTargets[target]; ok {
|
||||
response = targetResponse
|
||||
}
|
||||
}
|
||||
|
||||
if !strings.Contains(tt.name, "empty target") {
|
||||
assert.NotEmpty(t, r.FormValue("target"))
|
||||
}
|
||||
|
||||
w.WriteHeader(tt.serverStatus)
|
||||
_, err = w.Write([]byte(response))
|
||||
require.NoError(t, err)
|
||||
}))
|
||||
defer server.Close()
|
||||
|
||||
dsInfo := &datasourceInfo{
|
||||
Id: 1,
|
||||
URL: server.URL,
|
||||
HTTPClient: &http.Client{},
|
||||
}
|
||||
|
||||
service := &Service{
|
||||
logger: backend.Logger,
|
||||
}
|
||||
|
||||
req := &backend.QueryDataRequest{
|
||||
PluginContext: backend.PluginContext{
|
||||
DataSourceInstanceSettings: &backend.DataSourceInstanceSettings{
|
||||
ID: 1,
|
||||
URL: server.URL,
|
||||
},
|
||||
OrgID: 1,
|
||||
},
|
||||
Queries: tt.queries,
|
||||
}
|
||||
|
||||
result, err := service.RunQuery(context.Background(), req, dsInfo)
|
||||
|
||||
if tt.expectError {
|
||||
if err != nil {
|
||||
if tt.errorContains != "" {
|
||||
assert.Contains(t, err.Error(), tt.errorContains)
|
||||
}
|
||||
} else {
|
||||
require.NotNil(t, result)
|
||||
found := false
|
||||
for _, resp := range result.Responses {
|
||||
if resp.Error != nil {
|
||||
found = true
|
||||
if tt.errorContains != "" {
|
||||
assert.Contains(t, resp.Error.Error(), tt.errorContains)
|
||||
}
|
||||
break
|
||||
}
|
||||
}
|
||||
assert.True(t, found, "Expected error but none found")
|
||||
}
|
||||
} else {
|
||||
assert.NoError(t, err)
|
||||
require.NotNil(t, result)
|
||||
|
||||
for refID, resp := range result.Responses {
|
||||
experimental.CheckGoldenJSONResponse(t, "testdata", fmt.Sprintf("%s-RefID-%s.golden", testName, refID), &resp, false)
|
||||
}
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestParseGraphiteError(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
status int
|
||||
body string
|
||||
expected string
|
||||
}{
|
||||
{
|
||||
name: "simple text error",
|
||||
status: 400,
|
||||
body: "Bad request: invalid target",
|
||||
expected: "Bad request: invalid target",
|
||||
},
|
||||
{
|
||||
name: "JSON error",
|
||||
status: 400,
|
||||
body: `{"error": "Invalid target format"}`,
|
||||
expected: `{"error": "Invalid target format"}`,
|
||||
},
|
||||
{
|
||||
name: "HTML error",
|
||||
status: 500,
|
||||
body: `<body><h1>Internal Server Error</h1><p>Target not found</p></body>`,
|
||||
expected: "Internal Server Error\nTarget not found",
|
||||
},
|
||||
{
|
||||
name: "complex HTML error",
|
||||
status: 500,
|
||||
body: `<body>
|
||||
<h1>Internal Server Error</h1>
|
||||
<p>The server encountered an unexpected condition that prevented it from fulfilling the request.</p>
|
||||
<div>Error: Invalid metric path 'stats.invalid.metric'</div>
|
||||
Final error message here
|
||||
</body>`,
|
||||
expected: "Internal Server Error\nThe server encountered an unexpected condition that prevented it from fulfilling the request.\nError: Invalid metric path 'stats.invalid.metric'\nFinal error message here",
|
||||
},
|
||||
{
|
||||
name: "HTML error with unicode",
|
||||
status: 500,
|
||||
body: `<body><p>Error: Invalid path 'test' and "value"</p></body>`,
|
||||
expected: "Error: Invalid path 'test' and \"value\"",
|
||||
},
|
||||
{
|
||||
name: "HTML with whitespace and newlines",
|
||||
status: 500,
|
||||
body: `<body>
|
||||
|
||||
<h1>Error</h1>
|
||||
|
||||
<p>Something went wrong</p>
|
||||
|
||||
Critical failure occurred
|
||||
|
||||
</body>`,
|
||||
expected: "Error\nSomething went wrong\nCritical failure occurred",
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
result := parseGraphiteError(tt.status, tt.body)
|
||||
assert.Equal(t, tt.expected, result)
|
||||
})
|
||||
}
|
||||
}
|
||||
|
|
|
|||
72
pkg/tsdb/graphite/testdata/interval_format_transformation-RefID-A.golden.jsonc
vendored
Normal file
72
pkg/tsdb/graphite/testdata/interval_format_transformation-RefID-A.golden.jsonc
vendored
Normal file
|
|
@ -0,0 +1,72 @@
|
|||
// 🌟 This was machine generated. Do not edit. 🌟
|
||||
//
|
||||
// Frame[0] {
|
||||
// "type": "timeseries-multi",
|
||||
// "typeVersion": [
|
||||
// 0,
|
||||
// 0
|
||||
// ]
|
||||
// }
|
||||
// Name: A
|
||||
// Dimensions: 2 Fields by 2 Rows
|
||||
// +-------------------------------+------------------+
|
||||
// | Name: time | Name: value |
|
||||
// | Labels: | Labels: |
|
||||
// | Type: []time.Time | Type: []*float64 |
|
||||
// +-------------------------------+------------------+
|
||||
// | 2021-01-01 00:00:00 +0000 UTC | 100 |
|
||||
// | 2021-01-01 00:01:00 +0000 UTC | 150 |
|
||||
// +-------------------------------+------------------+
|
||||
//
|
||||
//
|
||||
// 🌟 This was machine generated. Do not edit. 🌟
|
||||
{
|
||||
"status": 200,
|
||||
"frames": [
|
||||
{
|
||||
"schema": {
|
||||
"name": "A",
|
||||
"meta": {
|
||||
"type": "timeseries-multi",
|
||||
"typeVersion": [
|
||||
0,
|
||||
0
|
||||
]
|
||||
},
|
||||
"fields": [
|
||||
{
|
||||
"name": "time",
|
||||
"type": "time",
|
||||
"typeInfo": {
|
||||
"frame": "time.Time"
|
||||
}
|
||||
},
|
||||
{
|
||||
"name": "value",
|
||||
"type": "number",
|
||||
"typeInfo": {
|
||||
"frame": "float64",
|
||||
"nullable": true
|
||||
},
|
||||
"labels": {},
|
||||
"config": {
|
||||
"displayNameFromDS": "hitcount(stats.counters.web.hits, '1min')"
|
||||
}
|
||||
}
|
||||
]
|
||||
},
|
||||
"data": {
|
||||
"values": [
|
||||
[
|
||||
1609459200000,
|
||||
1609459260000
|
||||
],
|
||||
[
|
||||
100,
|
||||
150
|
||||
]
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
72
pkg/tsdb/graphite/testdata/mixed_queries_-_some_empty,_some_valid-RefID-B.golden.jsonc
vendored
Normal file
72
pkg/tsdb/graphite/testdata/mixed_queries_-_some_empty,_some_valid-RefID-B.golden.jsonc
vendored
Normal file
|
|
@ -0,0 +1,72 @@
|
|||
// 🌟 This was machine generated. Do not edit. 🌟
|
||||
//
|
||||
// Frame[0] {
|
||||
// "type": "timeseries-multi",
|
||||
// "typeVersion": [
|
||||
// 0,
|
||||
// 0
|
||||
// ]
|
||||
// }
|
||||
// Name: B
|
||||
// Dimensions: 2 Fields by 2 Rows
|
||||
// +-------------------------------+------------------+
|
||||
// | Name: time | Name: value |
|
||||
// | Labels: | Labels: |
|
||||
// | Type: []time.Time | Type: []*float64 |
|
||||
// +-------------------------------+------------------+
|
||||
// | 2021-01-01 00:00:00 +0000 UTC | 100 |
|
||||
// | 2021-01-01 00:01:00 +0000 UTC | 150 |
|
||||
// +-------------------------------+------------------+
|
||||
//
|
||||
//
|
||||
// 🌟 This was machine generated. Do not edit. 🌟
|
||||
{
|
||||
"status": 200,
|
||||
"frames": [
|
||||
{
|
||||
"schema": {
|
||||
"name": "B",
|
||||
"meta": {
|
||||
"type": "timeseries-multi",
|
||||
"typeVersion": [
|
||||
0,
|
||||
0
|
||||
]
|
||||
},
|
||||
"fields": [
|
||||
{
|
||||
"name": "time",
|
||||
"type": "time",
|
||||
"typeInfo": {
|
||||
"frame": "time.Time"
|
||||
}
|
||||
},
|
||||
{
|
||||
"name": "value",
|
||||
"type": "number",
|
||||
"typeInfo": {
|
||||
"frame": "float64",
|
||||
"nullable": true
|
||||
},
|
||||
"labels": {},
|
||||
"config": {
|
||||
"displayNameFromDS": "stats.counters.web.hits"
|
||||
}
|
||||
}
|
||||
]
|
||||
},
|
||||
"data": {
|
||||
"values": [
|
||||
[
|
||||
1609459200000,
|
||||
1609459260000
|
||||
],
|
||||
[
|
||||
100,
|
||||
150
|
||||
]
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
|
|
@ -0,0 +1,72 @@
|
|||
// 🌟 This was machine generated. Do not edit. 🌟
|
||||
//
|
||||
// Frame[0] {
|
||||
// "type": "timeseries-multi",
|
||||
// "typeVersion": [
|
||||
// 0,
|
||||
// 0
|
||||
// ]
|
||||
// }
|
||||
// Name: A
|
||||
// Dimensions: 2 Fields by 2 Rows
|
||||
// +-------------------------------+------------------+
|
||||
// | Name: time | Name: value |
|
||||
// | Labels: | Labels: |
|
||||
// | Type: []time.Time | Type: []*float64 |
|
||||
// +-------------------------------+------------------+
|
||||
// | 2021-01-01 00:00:00 +0000 UTC | 100 |
|
||||
// | 2021-01-01 00:01:00 +0000 UTC | 150 |
|
||||
// +-------------------------------+------------------+
|
||||
//
|
||||
//
|
||||
// 🌟 This was machine generated. Do not edit. 🌟
|
||||
{
|
||||
"status": 200,
|
||||
"frames": [
|
||||
{
|
||||
"schema": {
|
||||
"name": "A",
|
||||
"meta": {
|
||||
"type": "timeseries-multi",
|
||||
"typeVersion": [
|
||||
0,
|
||||
0
|
||||
]
|
||||
},
|
||||
"fields": [
|
||||
{
|
||||
"name": "time",
|
||||
"type": "time",
|
||||
"typeInfo": {
|
||||
"frame": "time.Time"
|
||||
}
|
||||
},
|
||||
{
|
||||
"name": "value",
|
||||
"type": "number",
|
||||
"typeInfo": {
|
||||
"frame": "float64",
|
||||
"nullable": true
|
||||
},
|
||||
"labels": {},
|
||||
"config": {
|
||||
"displayNameFromDS": "stats.counters.web.hits"
|
||||
}
|
||||
}
|
||||
]
|
||||
},
|
||||
"data": {
|
||||
"values": [
|
||||
[
|
||||
1609459200000,
|
||||
1609459260000
|
||||
],
|
||||
[
|
||||
100,
|
||||
150
|
||||
]
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
|
|
@ -0,0 +1,72 @@
|
|||
// 🌟 This was machine generated. Do not edit. 🌟
|
||||
//
|
||||
// Frame[0] {
|
||||
// "type": "timeseries-multi",
|
||||
// "typeVersion": [
|
||||
// 0,
|
||||
// 0
|
||||
// ]
|
||||
// }
|
||||
// Name: B
|
||||
// Dimensions: 2 Fields by 2 Rows
|
||||
// +-------------------------------+------------------+
|
||||
// | Name: time | Name: value |
|
||||
// | Labels: | Labels: |
|
||||
// | Type: []time.Time | Type: []*float64 |
|
||||
// +-------------------------------+------------------+
|
||||
// | 2021-01-01 00:00:00 +0000 UTC | 50 |
|
||||
// | 2021-01-01 00:01:00 +0000 UTC | 75 |
|
||||
// +-------------------------------+------------------+
|
||||
//
|
||||
//
|
||||
// 🌟 This was machine generated. Do not edit. 🌟
|
||||
{
|
||||
"status": 200,
|
||||
"frames": [
|
||||
{
|
||||
"schema": {
|
||||
"name": "B",
|
||||
"meta": {
|
||||
"type": "timeseries-multi",
|
||||
"typeVersion": [
|
||||
0,
|
||||
0
|
||||
]
|
||||
},
|
||||
"fields": [
|
||||
{
|
||||
"name": "time",
|
||||
"type": "time",
|
||||
"typeInfo": {
|
||||
"frame": "time.Time"
|
||||
}
|
||||
},
|
||||
{
|
||||
"name": "value",
|
||||
"type": "number",
|
||||
"typeInfo": {
|
||||
"frame": "float64",
|
||||
"nullable": true
|
||||
},
|
||||
"labels": {},
|
||||
"config": {
|
||||
"displayNameFromDS": "stats.counters.api.calls"
|
||||
}
|
||||
}
|
||||
]
|
||||
},
|
||||
"data": {
|
||||
"values": [
|
||||
[
|
||||
1609459200000,
|
||||
1609459260000
|
||||
],
|
||||
[
|
||||
50,
|
||||
75
|
||||
]
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
75
pkg/tsdb/graphite/testdata/successful_single_query_with_data-RefID-A.golden.jsonc
vendored
Normal file
75
pkg/tsdb/graphite/testdata/successful_single_query_with_data-RefID-A.golden.jsonc
vendored
Normal file
|
|
@ -0,0 +1,75 @@
|
|||
// 🌟 This was machine generated. Do not edit. 🌟
|
||||
//
|
||||
// Frame[0] {
|
||||
// "type": "timeseries-multi",
|
||||
// "typeVersion": [
|
||||
// 0,
|
||||
// 0
|
||||
// ]
|
||||
// }
|
||||
// Name: A
|
||||
// Dimensions: 2 Fields by 3 Rows
|
||||
// +-------------------------------+------------------+
|
||||
// | Name: time | Name: value |
|
||||
// | Labels: | Labels: |
|
||||
// | Type: []time.Time | Type: []*float64 |
|
||||
// +-------------------------------+------------------+
|
||||
// | 2021-01-01 00:00:00 +0000 UTC | 100 |
|
||||
// | 2021-01-01 00:01:00 +0000 UTC | 150 |
|
||||
// | 2021-01-01 00:02:00 +0000 UTC | 120 |
|
||||
// +-------------------------------+------------------+
|
||||
//
|
||||
//
|
||||
// 🌟 This was machine generated. Do not edit. 🌟
|
||||
{
|
||||
"status": 200,
|
||||
"frames": [
|
||||
{
|
||||
"schema": {
|
||||
"name": "A",
|
||||
"meta": {
|
||||
"type": "timeseries-multi",
|
||||
"typeVersion": [
|
||||
0,
|
||||
0
|
||||
]
|
||||
},
|
||||
"fields": [
|
||||
{
|
||||
"name": "time",
|
||||
"type": "time",
|
||||
"typeInfo": {
|
||||
"frame": "time.Time"
|
||||
}
|
||||
},
|
||||
{
|
||||
"name": "value",
|
||||
"type": "number",
|
||||
"typeInfo": {
|
||||
"frame": "float64",
|
||||
"nullable": true
|
||||
},
|
||||
"labels": {},
|
||||
"config": {
|
||||
"displayNameFromDS": "stats.counters.web.hits"
|
||||
}
|
||||
}
|
||||
]
|
||||
},
|
||||
"data": {
|
||||
"values": [
|
||||
[
|
||||
1609459200000,
|
||||
1609459260000,
|
||||
1609459320000
|
||||
],
|
||||
[
|
||||
100,
|
||||
150,
|
||||
120
|
||||
]
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
75
pkg/tsdb/graphite/testdata/successful_single_query_with_null_values-RefID-A.golden.jsonc
vendored
Normal file
75
pkg/tsdb/graphite/testdata/successful_single_query_with_null_values-RefID-A.golden.jsonc
vendored
Normal file
|
|
@ -0,0 +1,75 @@
|
|||
// 🌟 This was machine generated. Do not edit. 🌟
|
||||
//
|
||||
// Frame[0] {
|
||||
// "type": "timeseries-multi",
|
||||
// "typeVersion": [
|
||||
// 0,
|
||||
// 0
|
||||
// ]
|
||||
// }
|
||||
// Name: A
|
||||
// Dimensions: 2 Fields by 3 Rows
|
||||
// +-------------------------------+------------------+
|
||||
// | Name: time | Name: value |
|
||||
// | Labels: | Labels: |
|
||||
// | Type: []time.Time | Type: []*float64 |
|
||||
// +-------------------------------+------------------+
|
||||
// | 2021-01-01 00:00:00 +0000 UTC | 100 |
|
||||
// | 2021-01-01 00:01:00 +0000 UTC | null |
|
||||
// | 2021-01-01 00:02:00 +0000 UTC | 120 |
|
||||
// +-------------------------------+------------------+
|
||||
//
|
||||
//
|
||||
// 🌟 This was machine generated. Do not edit. 🌟
|
||||
{
|
||||
"status": 200,
|
||||
"frames": [
|
||||
{
|
||||
"schema": {
|
||||
"name": "A",
|
||||
"meta": {
|
||||
"type": "timeseries-multi",
|
||||
"typeVersion": [
|
||||
0,
|
||||
0
|
||||
]
|
||||
},
|
||||
"fields": [
|
||||
{
|
||||
"name": "time",
|
||||
"type": "time",
|
||||
"typeInfo": {
|
||||
"frame": "time.Time"
|
||||
}
|
||||
},
|
||||
{
|
||||
"name": "value",
|
||||
"type": "number",
|
||||
"typeInfo": {
|
||||
"frame": "float64",
|
||||
"nullable": true
|
||||
},
|
||||
"labels": {},
|
||||
"config": {
|
||||
"displayNameFromDS": "stats.counters.web.hits"
|
||||
}
|
||||
}
|
||||
]
|
||||
},
|
||||
"data": {
|
||||
"values": [
|
||||
[
|
||||
1609459200000,
|
||||
1609459260000,
|
||||
1609459320000
|
||||
],
|
||||
[
|
||||
100,
|
||||
null,
|
||||
120
|
||||
]
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
77
pkg/tsdb/graphite/testdata/successful_single_query_with_tags-RefID-A.golden.jsonc
vendored
Normal file
77
pkg/tsdb/graphite/testdata/successful_single_query_with_tags-RefID-A.golden.jsonc
vendored
Normal file
|
|
@ -0,0 +1,77 @@
|
|||
// 🌟 This was machine generated. Do not edit. 🌟
|
||||
//
|
||||
// Frame[0] {
|
||||
// "type": "timeseries-multi",
|
||||
// "typeVersion": [
|
||||
// 0,
|
||||
// 0
|
||||
// ]
|
||||
// }
|
||||
// Name: A
|
||||
// Dimensions: 2 Fields by 2 Rows
|
||||
// +-------------------------------+--------------------------------------------------------------------+
|
||||
// | Name: time | Name: value |
|
||||
// | Labels: | Labels: environment=production, host=server1, port=8080, rate=99.5 |
|
||||
// | Type: []time.Time | Type: []*float64 |
|
||||
// +-------------------------------+--------------------------------------------------------------------+
|
||||
// | 2021-01-01 00:00:00 +0000 UTC | 100 |
|
||||
// | 2021-01-01 00:01:00 +0000 UTC | 150 |
|
||||
// +-------------------------------+--------------------------------------------------------------------+
|
||||
//
|
||||
//
|
||||
// 🌟 This was machine generated. Do not edit. 🌟
|
||||
{
|
||||
"status": 200,
|
||||
"frames": [
|
||||
{
|
||||
"schema": {
|
||||
"name": "A",
|
||||
"meta": {
|
||||
"type": "timeseries-multi",
|
||||
"typeVersion": [
|
||||
0,
|
||||
0
|
||||
]
|
||||
},
|
||||
"fields": [
|
||||
{
|
||||
"name": "time",
|
||||
"type": "time",
|
||||
"typeInfo": {
|
||||
"frame": "time.Time"
|
||||
}
|
||||
},
|
||||
{
|
||||
"name": "value",
|
||||
"type": "number",
|
||||
"typeInfo": {
|
||||
"frame": "float64",
|
||||
"nullable": true
|
||||
},
|
||||
"labels": {
|
||||
"environment": "production",
|
||||
"host": "server1",
|
||||
"port": "8080",
|
||||
"rate": "99.5"
|
||||
},
|
||||
"config": {
|
||||
"displayNameFromDS": "stats.counters.web.hits"
|
||||
}
|
||||
}
|
||||
]
|
||||
},
|
||||
"data": {
|
||||
"values": [
|
||||
[
|
||||
1609459200000,
|
||||
1609459260000
|
||||
],
|
||||
[
|
||||
100,
|
||||
150
|
||||
]
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue