mirror of https://github.com/grafana/grafana.git
2 Commits
| Author | SHA1 | Message | Date |
|---|---|---|---|
Ivan Ortega Alba
|
c0ce4ff1f2
|
Dashboards: Fix missing Ctrl+O keyboard shortcut for crosshair toggle (#111310)
* Dashboard Scenes: Fix missing Ctrl+O keyboard shortcut for crosshair toggle - Add missing mod+o keybind to dashboard scenes keyboard shortcuts - Implement crosshair state cycling (Default -> Crosshair -> Tooltip -> Default) - Add comprehensive unit tests for keyboard shortcuts functionality - Add e2e test to verify shortcut works and prevents browser file dialog - Fix ensures parity between legacy and scenes dashboard implementations Fixes issue where Ctrl+O/Cmd+O was opening browser file dialog instead of toggling shared crosshair modes in scenes-based dashboards. * Remove waitForTimeout from e2e test - Replace arbitrary timeouts with proper element waiting - Use waitFor with visible state instead of setTimeout - Improve test reliability and follow Playwright best practices * Optimize e2e test for crosshair keyboard shortcut - Remove unnecessary console logging and timeout settings - Simplify assertions to only check the currently selected radio button - Improve test performance by reducing DOM queries - Focus on essential functionality verification * Fix linting |
|
Ashley Harrison
|
b6580ccb10
|
E2E: migrate to playwright (#107241)
* separate playwright into its own folder * better separation * add login scenario, add tags * remove ui option * update CODEOWNERS * add a panels suite test * migrate queries test to playwright * rename + add dashlist test * add panelEdit_base * add geomap map controls test * add geomap-layer-types * add geomap-spatial-operations tests * add frontend-sandbox-panel tests * add smoke-tests-suite * add comment about adding datasource * add dashboard-browse-nested * add dashboard-browse * add dashboard-export-json * add dashboard-keybindings test * remove @wip tag * turn on screenshots and add comment for why this test fails * add dashboard-links-without-slug test * try adding permissions in the test as well * add dashboard-live-streaming * context in the test doesn't work - sad * create dashboard-public-templating * add dashboard-public-create and make live streaming more resilient * add share externally test * add dashboard-share-internally * add share-snapshot-create test * add dashboard-templating * add timepicker tests * add embedded-dashboard test * add general_dashboards test * add import-dashboard test * add load-options-from-url test * add new-constant-variable test * add custom-variable test * add new-datasource-variable test * add new-interval-variable test * add text-box-variable test * add new-query-variable test * add horizontal repeat test * add panel-vertical-repeat test * add empty-row-repeat test * add set-options-from-ui test * add snapshot-create test * add templating test * add textbox-variables test * add cloud-plugins-suite * add storybook verification tests * add playwright storybook verification workflow * add playwright browsers * update CODEOWNERS * test change to trigger storybook verification workflows * try container instead * get the version right... * go back to installing - less chance of forgetting to update * Basic Github Actions Squashed commit of the following: commit |