22 Commits

Author	SHA1	Message	Date
Paul Marbach	3f02f50cf9	StateTimeline: Complete E2E tests and add simple StateTimelineTooltip unit tests (#112901) ... * StateTimeline: E2E tests for basic rendering, no data, and tooltip interactions * Add tests for StateTimelineTooltip sub-component * Remove unused import from state-timeline.spec.ts * updates from PR review	2025-10-24 10:45:48 -04:00
Paul Marbach	bb9b890e8c	Table: Styling from field (#110991) ... * Table: Styling from field * fix mistake with gdev * e2e for kitchen sink * add counter-example in e2e for completeness * unit tests for utils * update to store style field per-column, replace util * optimize branches column-level variables	2025-09-15 10:34:12 -05:00
Paul Marbach	f258d8a417	Table: Restore previous footer behavior of reducers applying to filtered data (#111041) ... * Table: Restore previous footer behavior of reducers applying to filtered data * update e2e to match new behavior	2025-09-12 17:33:06 -04:00
Ihor Yeromin	2f2950eb29	Tests: Move Canvas tests to panel folder and add testing README (#110768) ... * chore(e2e-tests): move canvas tests to panels	2025-09-08 17:52:10 +02:00
Paul Marbach	7cbc55d615	Table: Update UX for uniform-reducer case in new footer and overflow (#110493) ... * Table: Update UX for single-reducer use case in new footer * all cases are working; unit tests pass * style and code cleanup in SummaryCell * remove e2e test for sum reducer label * reorganize code, todo tests * slight style cleanup * one more little reorganization * updates based on CI failures * update tests and docs * unused prop * update table footer image * alt text, lint issue * update gdev to create footer dashboard and re-point e2es there, add a few new cases * remove console.log	2025-09-05 15:46:07 -04:00
Alex Spencer	6c9faa7595	TableNG: Footer enhancements (#102948) ... * Table: Footer support for multiple reducers * fix migrator test output due to required default value * fix go migration test * more go test fixes * fix go tests for footer * Merge #110062 * update migration dashboard * Small docs fixes * Small docs fix * remove migration method in Go, update js unit test * add migration dashboard for footer and clean up some issues with countAll * Footer should always use og rows for calcs * update footer to be unaffected by filtering and sorting * more e2es * add more complex footer to kitchen sink, migrate panel all the way up * update codeowners for e2e * relocate footer migration panels and e2es to main 12.2 migration dashboard * go further with the migration; kill unused fields, rename reducer to reducers * get the go code up to date, move enablePagination to its own option as well * add a unit to one of the numeric columns with a footer in kitchen sink * fix reducers override in kitchen sink migration table --------- Co-authored-by: Paul Marbach <paul.marbach@grafana.com> Co-authored-by: Isabel Matwawana <isabel.matwawana@grafana.com> Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com> Co-authored-by: Leon Sorokin <leeoniya@gmail.com>	2025-09-03 18:03:33 -04:00
Paul Marbach	b22f15ad16	Table: Max row height for variable height rows (#109639) ... * Table: Max height for wrapped content * Docs: tableNG max cell height (#110069) Co-authored-by: Paul Marbach <paul.marbach@grafana.com> * change to Max row height instead of Max cell height * fix unit test * table utils codeowners * Update packages/grafana-ui/src/components/Table/TableNG/utils.ts Co-authored-by: Leon Sorokin <leeoniya@gmail.com> * update docs * fix docs * Revert "fix unit test" This reverts commit c46b0f1bec. * fix unit test * trade one important for another * Tweaked wording * hover overflow for max row height * get rid of commented out section * and we did it without important * centralize overflow for max height assessment * some alignment stuff was busted * didn't end up using the max heigh arg for shouldTextOverflow * make i18n path more consistent * put some tooltip things back since they ultimately didnt change * we can simplify the :not selector * delete comment * don't bother with :not --------- Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com> Co-authored-by: Leon Sorokin <leeoniya@gmail.com>	2025-08-29 15:10:17 -04:00
Paul Marbach	76b1e5e389	Table: Migrate to field-level wrapText toggle, use standard hideFrom.viz for hidden fields (#109297) ... * Added wrap text to table options and removed from multiple cell options * Removed wrap text from cell options shared file * Edited * Edited * Table: Migrate to field-level wrapText toggle * migrate hidden -> hideFrom.viz as well * more cleanup from rebase * restore options that got killed in the rebase * when wrap text is enabled for the whole table, exclude columns that do not make sense * fix TableNG unit tests * fix i18n * unit tests for the migrations * sort out e2e issue * fix migration unit test * fix backend migration test as well * add a dashboard for the v12.2 table migrations * update dev-dashboards.lisonnet * make gen-jsonnet * one of the panel versions didnt get updated --------- Co-authored-by: Isabel Matwawana <isabel.matwawana@grafana.com>	2025-08-27 16:37:02 -04:00
Josh Hunt	67b22177a8	Accessibility: Ensure dashboard edit panel inputs have accessible labels (again) (#110163) ... * Revert "Revert: "Accessibility: Ensure dashboard edit panel inputs have accessible labels" (#109984)" This reverts commit 7331a2e8c3. * revert test change that accidentally catches the issue * use useId in some places * make ID required * fix some ids * fix a couple more * add ids to variables Co-authored-by: Ashley Harrison <ashharrison90@gmail.com> * add ids to get viz options * add ids in getPanelFrameOptions * add getFieldOverrideElements * change name * Replace other uuids with hard coded ids * hoist useId out * use some new selectors for table e2es * commit betterer crimes * use useId where we can * Revert "use useId where we can" This reverts commit 34090ac75d. * fix some dashboard layouts tests * rm AutoCellOptionsEditor * idk try and fix tests * restore fixed its for url state --------- Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com> Co-authored-by: Ashley Harrison <ashharrison90@gmail.com> Co-authored-by: Paul Marbach <paul.marbach@grafana.com>	2025-08-27 13:10:47 +01:00
Paul Marbach	ec38e0bd58	Table: Enable tableNextGen by default (#109832) ... * Table: Enable tableNextGen by default * kill off tableNextGen feature flag * i18n * i18n * i18n * remove state beta from table panel * fix migration for 0 decimals migration * add explicit auto option bacjk * match impl from previous migrations code * try changing some selectors * remove timezone test from Cypress * fix PlaylistForm unit test * fix some selectors * clean up i18n, are these gridcells somehow? * return a couple of selectors caught in the dragnet to being cell instead of gridcell * fix i18n for en-US * clean up gdevs now that wrapHeaderText has no default * update role in e2e for when it is re-enabled	2025-08-26 17:25:16 -04:00
Paul Marbach	61c160b30f	Table: Fields and Column Widths arrays can get out-of-sync on length (#109997) ... * Table: Fields and Column Widths arrays can get out-of-sync on length * slight cleanup for e2e * remove a couple of page desctructures	2025-08-21 20:49:53 +00:00
Luminessa Starlight	7331a2e8c3	Revert: "Accessibility: Ensure dashboard edit panel inputs have accessible labels" (#109984) ... * Revert "Accessibility: Ensure dashboard edit panel inputs have accessible labels (#109546)" This reverts commit 4d067059c9. * kick CI	2025-08-21 15:23:23 -04:00
Paul Marbach	66eee1cb08	Table: Tooltip from Field (#109428) ... * Table: Tooltip by Field * add colorization support * more progress on customizing the tooltip based on cell customization * configurable as an option * tooltip triggered from a chip in the corner, pinning tooltip * i18n * use enum where appropriate * correctly orient the tooltip to the cell - but at what cost * clean up some console.logs * e2e test for the tooltip * fix global click stuff * remove console.log * refine the style of the caret * caret placement on same-side as alignment to avoid collision with inspect hover * some updates from self-review * increase hit target of tooltip caret * fix width and height auto-sizing especially for dynamic height * reorganize to pre-calc the per-field stuff * use linear gradient for triangle * update e2e to reflect current behavior, that clicking caret multiple times doesn't toggle pinning * clean up event handlers a bit * restore test for toggle click * alright, re-remove the toggle case * cursor pointer * remove optional root from Popover for now * remove this ridiculous autogenerated file * update some of the text * kill the cellRefMatrix * remove unused import * extract a util for the predicateByName part * skip the intermediary step for getCellColors	2025-08-18 10:11:43 -04:00
Luminessa Starlight	4d067059c9	Accessibility: Ensure dashboard edit panel inputs have accessible labels (#109546) ... * update instantiations of OptionsPaneItemDescriptor to pass IDs - obvious changes * update instantiations of OptionsPaneItemDescriptor to pass IDs - iffy changes * update editors to pass ID through or note a missing label * update playwright tests * fix unit tests * grafana ui components updated to pass ID through * update components to pass ID through * add missing input IDs * better default ID handling * remove TS note * revert accidental non-html id change * kick CI * fix old-arch e2e tests * change to plain useId calls --------- Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>	2025-08-14 14:01:25 -04:00
Paul Marbach	cc64b17483	Table: Move cell-specific styles out to their own methods (#108941) ... * TableNG: Markdown cell, plus custom row height * tab indentation in cue file * fix i18n * trying an auto height with the updated RDG * get auto cellHeight working * i18n updates * hoor disable_sanitize_html flag in MarkdownCell * update react-data-grid version to attempt to support page up and down * removing custom height * use the latest experimental RDG with paging up and down * TableNG: Wrap text for DataLinks and Pills; groundwork for max wrap length * disable editing max wrapped lines for now * disable wrap text line limit e2e * new i18n extract after commenting out input * wip * kill max wrapped lines for now * more cleanup * remove targeting classes added for max wrapped lines * fix Pill test * couple more style cleanups * Table: Move cell-specific styles out to their own methods * move styles into their own file * combine renderer and style declarations to make auto cells work better, complete cleanup of internal cell elements * fix e2es given these updates * add a couple tests * wip: tests * add tests * bump up capital letters in lorem ipsum * fix copy-pasta mistake * whoops, mis-merged the selector * use a local count instead of getCellLinks * use react-data-grid on react-18 branch * fix linting on test * gdev dashboard and smoketest for Markdown table * remove cellHeightCustom * restore bugfix from adversarial AI-generated JSON * reorganize in light of recent and upcoming changes * cleanup * override the whitespace for markdown * what are these auto imports about... * fix cell height selector from merge * also remove cellHeightCustom * i18n * avoid the important override in markdown cell styles * revert some betterer config autoformatting * slight code cleanup * s/cat/grot, add color link panel to kitchen sink, fix color link/image link style issues * update panelid for empty table panel test * link styles outside of cell style setup * flesh out kitchen sink examples, update ImageCell and applyToRow * clean up some inconsistent states * fix lint issue * gdev update * format JSON to satisfy linter * shortening the text in the long text field --------- Co-authored-by: Leon Sorokin <leeoniya@gmail.com>	2025-08-07 19:53:52 -04:00
Paul Marbach	a5ceac4474	TableNG: Markdown cell, plus auto row height (#107549) ... * TableNG: Markdown cell, plus custom row height * tab indentation in cue file * fix i18n * trying an auto height with the updated RDG * get auto cellHeight working * i18n updates * hoor disable_sanitize_html flag in MarkdownCell * update react-data-grid version to attempt to support page up and down * removing custom height * use the latest experimental RDG with paging up and down * TableNG: Wrap text for DataLinks and Pills; groundwork for max wrap length * disable editing max wrapped lines for now * disable wrap text line limit e2e * new i18n extract after commenting out input * wip * kill max wrapped lines for now * more cleanup * remove targeting classes added for max wrapped lines * fix Pill test * couple more style cleanups * fix e2es given these updates * add a couple tests * wip: tests * add tests * bump up capital letters in lorem ipsum * fix copy-pasta mistake * whoops, mis-merged the selector * use a local count instead of getCellLinks * use react-data-grid on react-18 branch * fix linting on test * gdev dashboard and smoketest for Markdown table * remove cellHeightCustom * reorganize in light of recent and upcoming changes * remove one more reference to cellHeightCustom * put getDefaultRowHeight back into a util * clean up test * swap cell height back to a radio * revert ImageCell change, we'll do it in the getStyles PR * don't memo defaultRowHeight * final couple of style cleanups * different approach to managing the auto height part of this * kill console.log * update i18n * reorganized once more * i18n * guard against rowHeight being auto for virtualization * may as well memoize the defaultRowHeight * get rid of the enableVirtualization initializer thing * fixes from CI * fix test * fix test * just omit third arg for that test * remove nonsensical test case * this file didn't get re-gen'd * fixes from review * row expander doesn't need height * remove console.log * fix e2e after we fixed pagination toggle bug	2025-08-01 19:56:12 -04:00
Paul Marbach	7e47968939	TableNG: Wrap text for DataLinks and Pills (#108645) ... * TableNG: Wrap text for DataLinks and Pills; groundwork for max wrap length * disable editing max wrapped lines for now * disable wrap text line limit e2e * new i18n extract after commenting out input * wip * kill max wrapped lines for now * more cleanup * remove targeting classes added for max wrapped lines * fix Pill test * couple more style cleanups * fix e2es given these updates * add a couple tests * wip: tests * add tests * bump up capital letters in lorem ipsum * fix copy-pasta mistake * use a local count instead of getCellLinks * fix linting on test	2025-08-01 12:27:53 -04:00
Paul Marbach	0ca2843fa3	E2E: Disable flaky Table e2e tests for DataLinks for now (#108980)	2025-07-31 10:56:06 -04:00
Ashley Harrison	664188b7e0	Chore: Remove `panels-suite` from cypress tests (#108709) ... remove panels-suite from cypress tests	2025-07-30 09:15:01 +01:00
Paul Marbach	26d26f67d4	TableNG: Integrate hover and selection, DataLinkCell cleanup (#108353) ... * Table: Style cleanups (minus DataLinkCell word wrap) * kill JSONCell in favor of a custom display method and style overrides at TableNG * remove unused type for JSONCellProps * add increased specificity to CSS selector * remove inherit and rely on undefined * fix tests * shrink and optimize DataLinkCell * maybe * format files * better * classname * add Pills and DataLink cells to kitchen sink * add comment about align + justify, simplify datalinks targeting * simplify? * poke * tweak * revert * fix one more z-index conflict * clean up alignment tests * a couple more tests * make TableNG e2e tests more resilient to changes to the gdev dashboard --------- Co-authored-by: Leon Sorokin <leeoniya@gmail.com>	2025-07-23 19:39:25 +00:00
Paul Marbach	7626508842	Table: Update e2e tests to support tableNextGen (#108184) ... * Table: Force tableNextGen to be true for Playwright and false for Cypress * RDG query for body text contains the headers too * add some simple tests for row height * dial in the row height test a little more * more updates * filters, pagination * try this on CI * more updates to the tests * more tests * wait for some sort stuff to flush * replace class selectors for rdg * target the click to the anchor in the header	2025-07-18 12:27:04 -04:00
Ashley Harrison	b6580ccb10	E2E: migrate to playwright (#107241) ... * separate playwright into its own folder * better separation * add login scenario, add tags * remove ui option * update CODEOWNERS * add a panels suite test * migrate queries test to playwright * rename + add dashlist test * add panelEdit_base * add geomap map controls test * add geomap-layer-types * add geomap-spatial-operations tests * add frontend-sandbox-panel tests * add smoke-tests-suite * add comment about adding datasource * add dashboard-browse-nested * add dashboard-browse * add dashboard-export-json * add dashboard-keybindings test * remove @wip tag * turn on screenshots and add comment for why this test fails * add dashboard-links-without-slug test * try adding permissions in the test as well * add dashboard-live-streaming * context in the test doesn't work - sad * create dashboard-public-templating * add dashboard-public-create and make live streaming more resilient * add share externally test * add dashboard-share-internally * add share-snapshot-create test * add dashboard-templating * add timepicker tests * add embedded-dashboard test * add general_dashboards test * add import-dashboard test * add load-options-from-url test * add new-constant-variable test * add custom-variable test * add new-datasource-variable test * add new-interval-variable test * add text-box-variable test * add new-query-variable test * add horizontal repeat test * add panel-vertical-repeat test * add empty-row-repeat test * add set-options-from-ui test * add snapshot-create test * add templating test * add textbox-variables test * add cloud-plugins-suite * add storybook verification tests * add playwright storybook verification workflow * add playwright browsers * update CODEOWNERS * test change to trigger storybook verification workflows * try container instead * get the version right... * go back to installing - less chance of forgetting to update * Basic Github Actions Squashed commit of the following: commit f84c650a71 Author: joshhunt <josh.hunt@grafana.com> Date: Tue Jul 1 13:23:46 2025 +0100 add arg for sharding, but not using it yet commit 7bcf0512c6 Author: joshhunt <josh.hunt@grafana.com> Date: Tue Jul 1 12:30:30 2025 +0100 less newline commit b643911882 Author: joshhunt <josh.hunt@grafana.com> Date: Tue Jul 1 12:24:31 2025 +0100 less logs commit 38f871e9c2 Author: joshhunt <josh.hunt@grafana.com> Date: Tue Jul 1 10:00:26 2025 +0100 fix yaml commit db9a773136 Author: joshhunt <josh.hunt@grafana.com> Date: Tue Jul 1 09:57:47 2025 +0100 clean up files commit c0525f41fa Author: joshhunt <josh.hunt@grafana.com> Date: Tue Jul 1 09:44:56 2025 +0100 gha workflow commit 895bea7c52 Author: joshhunt <josh.hunt@grafana.com> Date: Mon Jun 30 19:33:08 2025 +0100 working dagger commit cea1f84437 Author: joshhunt <josh.hunt@grafana.com> Date: Mon Jun 30 16:17:46 2025 +0100 wip * shard gha * some tidy up * add flags for exporting results, and a gha step to merge runs * fix shard gha * add dashboard-duplicate-panel test * add dashboard-outline test * add dashboards-add-panel * remove some commented out code * add dashboards-title-description test * add dashboards-remove-panel * don't install cypress * gha: check playwright results * add dashboards-edit-adhoc-variables test * fix check-jobs * add dagger cloud token * add dagger cloud token * add edit-datasource-variable test * update CODEOWNERS * add dashboards-edit-group-by-variables (skipped for now) * add dashboards-edit-panel-title-description test * add dashboards-edit-transparent-bg test * add dashboards-edit-query-variables test * run with 8 shards * add dashboards-edit-variables * tidy up gha * add dashboard-group-panels * fix action * try to cache the grafana build * fix missing action becuase no checkout, use builtin continue-on-error instead * fix missing id * cat out.txt * debug build cache * fix debug build cache * add dashboards-panel-layouts test * tidy up * no more debug * fix grafana dir * add dashboards-move-panel test * skip some failing tests * mark up plugins tests with @plugins tag, only run @plugins tests in drone * Hackathon/Playwright Conversion - Various Suite (#107516) * Playwright Migration: Various Suite tests * skipping bad tests * fix some tests that can fail * fix uid * separate user for the verify-i18n test * build test plugins for grafana server * properly blur input fields * login manually * get dashboardPage from goto * ignore a couple of type assertions * remove a couple of timeouts * remove timeouts on dashboard-share-internally * use toBeHidden * make dashboard-share-internally more stable * remove TEMP_DAGGER_TOKEN * clean up visaulization-suggestions * unskip gauge test * unskip trace-view-scrolling * attempt to make create variable utils stable * unskip loki tests * make go linter happy * unskip edit-group-by-variables test * unskip move panel tests * isolate dashboard-timepicker tests with separate user * create data source as part of smoke test * make sure we're awaiting in dashboard-edit-adhoc-variables * make dashboards-edit-variables test more robust * Hackathon Playwright: Dashboards Search (#107580) * Hackathon Playwright: Dashboards Search * Feedback changes * make trace-view-scrolling more stable * add json report and bench step * fix bench version * move fail step to after the playwright report so we can report test failures * fix output file name * fix typo * try wrap in expect.poll * stability * bit more tidy up * fix dashboard-new-layouts tests * move test-plugins to e2e-playwright * fix go code for drone e2e run * move loki plugin-e2e test * make v2 dashboards work again --------- Co-authored-by: joshhunt <josh.hunt@grafana.com> Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com> Co-authored-by: Collin Fingar <collin.fingar@grafana.com> Co-authored-by: Jeff Levin <jeff@levinology.com>	2025-07-11 10:31:33 +01:00