grafana

Commit Graph

Author	SHA1	Message	Date
lpugoy	c792af3ad0	grafana-mixin: Fix expression for GrafanaRequestsFailing alert (#63382 ) Fix expression for GrafanaRequestsFailing alert The intent of the alert is to get the ratio of 5xx to all status codes [^1]. With the original expression, the left hand side can have more than one row with the same labels except for the status code. This results in a promql error because it is doing a many-to-one matching. Doing a sum on the left hand side first should preserve the intent of the alert and resolve the issue. [^1]: https://github.com/grafana/grafana/pull/43116	2023-05-04 14:35:36 +02:00
Carlos Juan Gómez Peñalver	984e293d60	many-to-one requires explicit grouping (#58174 ) The current query results in a many-to-one relationship which requires explicit grouping see more details here https://github.com/portefaix/portefaix-hub/pull/306 https://prometheus.io/docs/prometheus/latest/querying/operators/#many-to-one-and-one-to-many-vector-matches	2023-02-21 11:00:48 +01:00
Pedro Araújo	18fdb89554	grafana-mixin: Fix `GrafanaRequestsFailing` alert (#43116 ) Due to PromQL's label matching, both sides of the division will have same series; that means that, whenever there's a 5xx error, both sides will have the same value and the division will be `1`. I believe the idea was to get the ratio of 5xx compared will all status code, and to do that, we need to aggregate the `status_code` dimension away.	2021-12-20 15:12:37 +01:00

Author

SHA1

Message

Date

lpugoy

c792af3ad0

grafana-mixin: Fix expression for GrafanaRequestsFailing alert (#63382 )

Fix expression for GrafanaRequestsFailing alert

The intent of the alert is to get the ratio of 5xx to all status codes
[^1]. With the original expression, the left hand side can have more than
one row with the same labels except for the status code. This results in
a promql error because it is doing a many-to-one matching. Doing a sum
on the left hand side first should preserve the intent of the alert and
resolve the issue.

[^1]: https://github.com/grafana/grafana/pull/43116

2023-05-04 14:35:36 +02:00

Carlos Juan Gómez Peñalver

984e293d60

many-to-one requires explicit grouping (#58174 )

The current query results in a many-to-one relationship which requires explicit grouping see more details here
https://github.com/portefaix/portefaix-hub/pull/306

https://prometheus.io/docs/prometheus/latest/querying/operators/#many-to-one-and-one-to-many-vector-matches

2023-02-21 11:00:48 +01:00

Pedro Araújo

18fdb89554

grafana-mixin: Fix `GrafanaRequestsFailing` alert (#43116 )

Due to PromQL's label matching, both sides of the division will have same series; that means that, whenever there's a 5xx error, both sides will have the same value and the division will be `1`. I believe the idea was to get the ratio of 5xx compared will all status code, and to do that, we need to aggregate the `status_code` dimension away.

2021-12-20 15:12:37 +01:00

3 Commits