676d393ec9
Chore: Fix issues reported by staticcheck; enable stylecheck linter ( #28866 )
...
* Chore: Fix issues reported by staticcheck
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
* Apply suggestions from code review
Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>
2020-11-05 15:37:11 +01:00
dff84f6a31
Chore: Remove dead code ( #28664 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-11-05 11:00:00 +01:00
b9d71f5cdd
Plugins: Fix descendent frontend plugin signature validation ( #28638 )
...
* move plugin root check to earlier in validation process
* remove comment
* only check root if necessary
2020-10-29 15:03:37 +01:00
069e2b0ced
Plugins: Fix plugin URL paths on Windows ( #28548 )
...
* Plugins: Fix plugin URL paths on Windows
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
* Plugins: Fix plugin URL paths on Windows
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-10-26 18:31:27 +01:00
b3a868169b
OAuth: Support Forward OAuth Identity for backend data source plugins ( #27055 )
...
Adds support for the Forward OAuth Identity feature in backend data source plugins.
Earlier this feature has only been supported for non-backend data source plugins.
Fixes #26023
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
2020-10-24 01:34:38 +02:00
1bee9f4168
Plugins: Track plugin signing errors and expose them to the frontend ( #28219 )
...
* first pass
* return list
* types and cleanup
* add to plugin page and add styles
* update comment
* update comment
* fix component path
* simplify error component
* simplify error struct
* fix tests
* don't export and fix string()
* update naming
* remove frontend
* introduce phantom loader
* track single error
* remove error from base
* remove unused struct
* remove unnecessary filter
* add errors endpoint
* Update set log to use id field
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
* skip adding BE plugins
* remove errs from plugin + ds list
* remove unnecessary fields
* add signature state to panels
* remove unused code
* apply PR feedback
* update comment
* merge dto with model
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-10-23 16:45:43 +02:00
4084b53f91
plugins: Don't exit on duplicate plugin ( #28390 )
...
* plugins: Don't exit on duplicate plugin
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
* Add missing files
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
* Fix test
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-10-21 12:39:41 +02:00
ec40e49dcb
Chore: Rewrite some tests to use testify ( #28420 )
...
* Chore: Improve tests to use testify
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-10-21 10:09:42 +02:00
68efedfa88
App Plugins: Add backend support ( #28272 )
...
* Add backend support for app plugins
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-10-21 09:10:54 +02:00
89d10c706a
Plugins: Compose filesystem paths with filepath.Join ( #28375 )
...
* plugins: Fix filesystem path composition
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
* plugins: Use filepath.Join to join filesystem paths
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-10-19 17:35:31 +02:00
531c579341
Plugins: Let descendant plugins inherit their root's signature ( #27970 )
...
* plugins: Let descendant plugins inherit their root's signature
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-10-05 13:28:18 +02:00
a078e40238
Settings: Rename constants/variables to follow Go naming standards ( #28002 )
...
* settings: Rename constants/variables to follow Go naming standards
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-10-02 15:45:45 +02:00
a5d9196a53
Chore/fix lint issues ( #27704 )
...
* Chore: Fix linting issues
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-09-22 16:22:19 +02:00
50c680f3d7
BackendPlugins: Point to request Headers in the wrapper ( #27599 )
...
In particular, so plugins can see the FromAlert header
2020-09-16 10:12:39 -04:00
c91bfd8299
Core: Add loki/logproto dependency ( #27124 )
...
* Add grafana/loki dependency and update its dependencies
* Update grpcplugin log_wrapper to implement the latest version of hclog.Logger
* Remove panic handling + test case no longer needed since the source of panics (bug) was fixed
2020-08-25 11:52:21 +02:00
16c185c3b9
Chore: Drop xerrors dependency ( #26718 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-07-31 09:45:20 +02:00
5e73a92327
DashboardImport: Fix variable interpolation when property contains multiple variable expressions ( #26574 )
2020-07-24 11:12:44 +03:00
4c56eb3991
Chore: Enable goprintffuncname and nakedret linters ( #26376 )
...
* Chore: Enable goprintffuncname linter
* Chore: Enable nakedret linter
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-07-23 08:14:39 +02:00
d4e4cb4c71
Chore: Enable Go linter gocritic ( #26224 )
...
* Chore: Enable gocritic linter
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-07-16 14:39:01 +02:00
b97d1f4170
Provisioning: Fix bug when provision app plugins using Enterprise edition ( #26340 )
...
In OSS provisioning service init after plugin registration, but in
Enterprise it's the opposite order and installed app plugin check
fails. This adjusts service registry init priority to make sure plugins
are registered before provisioning inits.
Which issue(s) this PR fixes:
Fixes #26336
2020-07-16 10:36:08 +02:00
5fe27ee959
Fix back-end tests on Windows ( #26355 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-07-15 20:09:03 +02:00
41d432b5ae
Chore: Enable whitespace linter ( #25903 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-07-06 20:17:28 +02:00
b5ca2381bc
provide license token directly via plugin environment ( #25987 )
...
* provide license token directly via plugin environment
2020-07-01 13:02:53 -04:00
bcaa42fbb3
Fix build-in plugins failing to load in windows ( #25982 )
2020-07-01 18:23:18 +03:00
4bb3f66569
Stackdriver: Rename Stackdriver to Google Cloud Monitoring ( #25807 )
...
* Update backend
* Update frontend
* Keep old plugin id
* Update docs
* Place doc images to a new directory
* Legacy support for stackdriver-auto alignment
* Consistent plugin name
* Apply suggestions from code review
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
Co-authored-by: Tobias Skarhed <1438972+tskarhed@users.noreply.github.com>
* Update docs
* Update public/app/plugins/datasource/cloud-monitoring/README.md
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
* Add reference to the data source formerly being named Stackdriver
* Update pkg/models/datasource.go
Co-authored-by: Carl Bergquist <carl@grafana.com>
* Fix gofmt
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
Co-authored-by: Tobias Skarhed <1438972+tskarhed@users.noreply.github.com>
Co-authored-by: Carl Bergquist <carl@grafana.com>
2020-06-30 18:47:13 +03:00
3651a8e976
Chore: Disable scopelint for tests ( #25923 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-06-30 11:05:47 +02:00
d1e6214a4a
Chore: Enable scopelint Go linter ( #25896 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-06-29 17:04:38 +02:00
cc95754e0d
Provisioning: Adds support for enabling app plugins ( #25649 )
...
Adds support for enabling app plugins using provisioning.
Ref #11409
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
2020-06-22 17:49:13 +02:00
c0f3b2929c
Backend plugins: Refactor to allow shared contract between core and external backend plugins ( #25472 )
...
Refactor to allow shared contract between core and external backend plugins
allowing core backend data sources in Grafana to be implemented in same
way as an external backend plugin.
Use v0.67.0 of sdk.
Add tests for verifying plugin is restarted when process is killed.
Enable strict linting for backendplugin packages
2020-06-11 16:14:05 +02:00
53175a41c9
Make tsdb dataframes response able to carry encoded/decoded frames ( #25454 )
...
Make tsdb dataframes response able to carry encoded and/or decoded frames
2020-06-09 13:13:06 +02:00
07582a8e85
Chore: Fix various spelling errors in back-end code ( #25241 )
...
* Chore: Fix various spelling errors in back-end code
Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>>
2020-06-01 17:11:25 +02:00
0c8ee5b2c9
Add deprecation note about the unofficial first version of backend plugins ( #24675 )
2020-05-14 15:37:44 +02:00
892f9f789c
Plugins: Fix manifest verification ( #24573 )
2020-05-12 15:48:24 +02:00
890e1d8f94
Backend plugins: Send query type to backend plugins ( #24120 )
...
Use v0.60.0 of sdk.
2020-05-05 10:32:34 +02:00
bcf5c937d5
Plugins: Require backend plugins to be signed when using plugin path ( #24244 )
2020-05-04 22:12:18 +02:00
3487e518ab
Signing: allow unsigned plugin in dev mode ( #24242 )
2020-05-04 11:57:11 -07:00
2fc2a7c3f5
Plugins: Only load transform plug-ins if expressions feature on ( #24110 )
...
* PluginManager: Only load transform plugins if expressions feature on
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
2020-05-04 17:39:20 +02:00
96ffcaa134
Plugins: Require signing of external back-end plugins ( #24075 )
...
* PluginManager: Require signing of external plugins
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
2020-05-04 10:57:55 +02:00
0a1650d265
Image rendering: Fix missing icon on plugins list ( #23958 )
...
Fixes #23189
2020-04-27 21:15:44 +02:00
52154b465b
dsproxy: adds support for url params for plugin routes ( #23503 )
...
* dsproxy: adds support for url params for plugin routes
* docs: fixes after review
* pluginproxy: rename Params to URLParams
* Update pkg/plugins/app_plugin.go
Co-Authored-By: Arve Knudsen <arve.knudsen@gmail.com>
* Apply suggestions from code review
Co-Authored-By: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
Co-Authored-By: Arve Knudsen <arve.knudsen@gmail.com>
* pluginproxy: rename struct
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
2020-04-24 10:32:13 +02:00
376765b3d7
Tracing: Remove feature flag ( #23834 )
2020-04-23 20:46:42 +02:00
80e1191ca0
Backend Plugins: (breaking change) Add PluginContext ( #23788 )
...
* breaking change for newer backend plugins
* use exported protobuf converters and sdk types to reduce duplicate code
* uses grafana-plugin-sdk-go@v0.54.0
2020-04-23 14:08:21 -04:00
871ad73414
Backend plugins: Renderer v2 plugin ( #23625 )
...
grafana-plugin-model is legacy and is replaced by new backend
plugins SDK and architecture. Renderer is not part of SDK and
we want to keep it that way for now since it's highly unlikely there
will be more than one kind of renderer plugin.
So this PR adds support for renderer plugin v2.
Also adds support sending a Device Scale Factor parameter to the
plugin v2 remote rendering service and by that replaces #22474 .
Adds support sending a Headers parameter to the plugin v2 and
remote rendering service which for now only include
Accect-Language header (the user locale in browser when using
Grafana), ref grafana/grafana-image-renderer#45 .
Fixes health check json details response.
Adds image renderer plugin configuration settings in defaults.ini
and sample.ini.
Co-Authored-By: Arve Knudsen <arve.knudsen@gmail.com>
2020-04-21 16:16:41 +02:00
ed51ce3ae1
Backend Plugins: Discard logged messages from logger named stdio ( #23601 )
...
Discard logged messages coming from backend plugin logger named
stdio since that service is not in use.
Fixes #23461
2020-04-16 13:08:07 +02:00
34266cd369
Backend Plugins: Plugin configuration using Grafana config ( #23451 )
...
Enables adding a section `plugin.<plugin id>` and key/value to
Grafana configuration file which will be converted and sent
as environment variables to the backend plugin.
Also sends some additional environment variables, Grafana
version (GF_VERSION), Grafana edition (GF_EDITION) and
enterprise license path (GF_ENTERPRISE_LICENSE_PATH).
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
Fixes #21515 ,
2020-04-14 18:04:27 +02:00
aaab636bf4
Plugins: verify manifest signature ( #23519 )
...
* try decode
* vendor crypto deps
* commited missing vendor deps
* Theme: Refactoring theme colors variables (#23513 )
* Theme: Typography updates
* Updated
* Updated snapshot
* Renamed colors to palette
* Introduce colors namespace
* Massive theme color move
* Removing color selection logic with more abstract concepts
* Updates
* Minor sidemenu change
* Fix example jaeger agent port in docs (#23514 )
* @grafana/ui: Replace various icons using Icon component (#23442 )
* Replace icons in dashboard and settings
* Replace icons in alerting
* Update batch of icons
* Implement icons accross various files
* Style updates
* Search: Fix recent and starred icons
* Update styling and details
* Replace new icon created by unicons
* Fix e2e test, styling
* Minor styling updates
Co-authored-by: Clarity-89 <homes89@ukr.net>
* trying with p512 key
* trying with p512 key
* lint
* update with real signatures
* fixes spacing in test files
* remove convey from test
* use errutil to wrap errors
* removes print statement
* splitt tests into two run statements
* unexport plugin manifest struct
Co-authored-by: bergquist <carl.bergquist@gmail.com>
Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
Co-authored-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com>
Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
Co-authored-by: Clarity-89 <homes89@ukr.net>
2020-04-14 06:02:39 -07:00
a56615749a
Plugins: fix debug formatting when scanning for files ( #23484 )
2020-04-10 00:45:07 -07:00
5153673884
BackendPlugins: update to sdk v0.42.0
...
misc cleanup
2020-04-09 15:47:30 -04:00
a08cbbcc81
Instrument backend plugin requests ( #23346 )
2020-04-09 14:47:46 +02:00
468f5d15ab
Plugins: add a signature status flag ( #23420 )
2020-04-09 00:00:16 -07:00
Arve Knudsen
Will Browne
Bill Oley
Joan López de la Franca Beltran
Kyle Brandt
Sofia Papagiannaki
Marcus Efraimsson
Dan Cech
Ryan McKinley
Daniel Lee
Andrej Ocenas
Carl Bergquist