grafana/pkg/api
Eric Leijonmarck 248af65f9c
Actionsets: Add ability for plugins to add actions for core actionsets (i.e. `folders:edit`) (#88776)
* initial commit

* Action sets stored
remove the dependancy for actionsets
got the actionsets registered
storing the permissions

* fix golanglinting

* remove unused struct field

* wip

* actionset registry for a plugin from the actionsetservice

* update to make declareactionset the primary way of plugin registration and modification

* declare actually extends actionsets

* tests fixed

* tests skipped

* skip tests

* skip tests

* skip tests

* skip tests

* change to warning instead

* remove step from pipeline to see if it fails due to plugin not registering

* reintroduce step but remove features dependancy

* add back the tests that were failing

* remove comments and another skip test

* fix a comment and remove unneeded changes

* fix and clean up, put the behaviour behind a feature toggle

* clean up

* fixing tests

* hard-code allowed action sets for plugins

* Apply suggestions from code review

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>

* small cleanup

---------

Co-authored-by: IevaVasiljeva <ieva.vasiljeva@grafana.com>
Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
2024-07-19 16:16:23 +01:00
..
apierrors
avatar
datasource
dtos Explore: Add setting for default time offset (#90401) 2024-07-17 11:47:49 -05:00
frontendlogging
pluginproxy Zanzana: Evaluate permissions alongside with RBAC engine (#90064) 2024-07-05 11:31:23 +02:00
response Chore: Move identity and errutil to apimachinery module (#89116) 2024-06-13 07:11:35 +03:00
routing
static
webassets
README.md Chore: Fix Swagger/OpenAPI instructions (#86541) 2024-04-19 09:16:38 +03:00
accesscontrol.go
admin.go Chore: Move identity and errutil to apimachinery module (#89116) 2024-06-13 07:11:35 +03:00
admin_encryption.go
admin_provisioning.go
admin_provisioning_test.go
admin_test.go
admin_users.go IAM: Fix logic for enabling a user (#90309) 2024-07-12 10:54:27 +02:00
admin_users_test.go User: use update function for password updates (#86419) 2024-04-17 15:24:36 +02:00
alerting.go
annotations.go Identity: Use typed version of namespace id (#87257) 2024-05-08 14:03:53 +02:00
annotations_test.go Zanzana: Evaluate permissions alongside with RBAC engine (#90064) 2024-07-05 11:31:23 +02:00
api.go Restore dashboards: Add RBAC (#90270) 2024-07-11 13:20:04 +03:00
api_test.go
apikey.go
basic_auth.go
basic_auth_test.go
common_test.go K8s: use contexthandler in standalone handler chain (#90102) 2024-07-08 12:22:10 -07:00
dashboard.go Optimize memory allocations in permissions cache (#89645) 2024-06-26 23:03:13 +03:00
dashboard_permission.go Chore: Move identity and errutil to apimachinery module (#89116) 2024-06-13 07:11:35 +03:00
dashboard_permission_test.go
dashboard_snapshot.go K8s: Improve identity mapping setup (#89450) 2024-06-20 17:53:07 +03:00
dashboard_snapshot_test.go Zanzana: Evaluate permissions alongside with RBAC engine (#90064) 2024-07-05 11:31:23 +02:00
dashboard_test.go DashboardStore: Use ReplDB and get dashboard quotas from the ReadReplica (#90235) 2024-07-12 10:47:49 -04:00
dataproxy.go
datasources.go Chore: Move identity and errutil to apimachinery module (#89116) 2024-06-13 07:11:35 +03:00
datasources_test.go Zanzana: Evaluate permissions alongside with RBAC engine (#90064) 2024-07-05 11:31:23 +02:00
ds_query.go Plugins: Remove datasourceQueryMultiStatus feature toggle (#90191) 2024-07-10 11:15:10 +02:00
ds_query_test.go Plugins: Remove datasourceQueryMultiStatus feature toggle (#90191) 2024-07-10 11:15:10 +02:00
fakes.go
folder.go Folders: Fix folder pagination for cloud instances with many folders (#90008) 2024-07-05 11:19:03 +01:00
folder_bench_test.go Actionsets: Add ability for plugins to add actions for core actionsets (i.e. `folders:edit`) (#88776) 2024-07-19 16:16:23 +01:00
folder_permission.go Chore: Move identity and errutil to apimachinery module (#89116) 2024-06-13 07:11:35 +03:00
folder_permission_test.go
folder_test.go Add auth spans and remove deduplication code for scopes (#89804) 2024-07-02 22:08:57 -08:00
frontend_logging.go
frontend_logging_test.go
frontend_metrics.go
frontendsettings.go Explore: Add setting for default time offset (#90401) 2024-07-17 11:47:49 -05:00
frontendsettings_test.go OIDC: Support Generic OAuth org to role mappings (#87394) 2024-05-23 09:55:45 +02:00
grafana_com_proxy.go
health.go
health_test.go
http_server.go Metrics: Fix internal metrics endpoint not accessible from browser if basic auth is enabled (#86904) 2024-07-11 14:55:48 +02:00
http_server_test.go
index.go Chore: Move identity and errutil to apimachinery module (#89116) 2024-06-13 07:11:35 +03:00
login.go Authn: Remove response writer from auth req (#90110) 2024-07-05 11:42:12 +02:00
login_oauth.go Authn: Remove response writer from auth req (#90110) 2024-07-05 11:42:12 +02:00
login_oauth_test.go
login_test.go AuthN: Use typed namespace id inside authn package (#86048) 2024-04-24 09:57:34 +02:00
org.go Chore: Move identity and errutil to apimachinery module (#89116) 2024-06-13 07:11:35 +03:00
org_invite.go Chore: Move identity and errutil to apimachinery module (#89116) 2024-06-13 07:11:35 +03:00
org_invite_test.go
org_test.go Add auth spans and remove deduplication code for scopes (#89804) 2024-07-02 22:08:57 -08:00
org_users.go
org_users_test.go Chore: Move identity and errutil to apimachinery module (#89116) 2024-06-13 07:11:35 +03:00
password.go User: use update function for password updates (#86419) 2024-04-17 15:24:36 +02:00
playlist.go Chore: Move identity and errutil to apimachinery module (#89116) 2024-06-13 07:11:35 +03:00
plugin_checks.go
plugin_checks_test.go
plugin_dashboards.go
plugin_dashboards_test.go
plugin_metrics.go
plugin_metrics_test.go
plugin_proxy.go
plugin_proxy_test.go Plugins: Preserve trailing slash in plugin proxy (#86859) 2024-06-05 13:36:14 +02:00
plugin_resource.go
plugin_resource_test.go Add auth spans and remove deduplication code for scopes (#89804) 2024-07-02 22:08:57 -08:00
plugins.go Plugins: Add logs to for plugin management actions (#90587) 2024-07-18 17:19:36 +02:00
plugins_test.go Plugins: Add logs to for plugin management actions (#90587) 2024-07-18 17:19:36 +02:00
preferences.go Navigation: Backend to save navigation customization into preferences (#89783) 2024-07-03 10:40:51 +01:00
preferences_test.go
quota.go
quota_test.go Add auth spans and remove deduplication code for scopes (#89804) 2024-07-02 22:08:57 -08:00
render.go Chore: Move identity and errutil to apimachinery module (#89116) 2024-06-13 07:11:35 +03:00
search.go Restore dashboards: Add RBAC (#90270) 2024-07-11 13:20:04 +03:00
short_url.go
short_url_test.go
signup.go Chore: Move identity and errutil to apimachinery module (#89116) 2024-06-13 07:11:35 +03:00
swagger.go
swagger_responses.go
swagger_tags.json
user.go Chore: Move identity and errutil to apimachinery module (#89116) 2024-06-13 07:11:35 +03:00
user_test.go Zanzana: Evaluate permissions alongside with RBAC engine (#90064) 2024-07-05 11:31:23 +02:00
user_token.go Chore: Move identity and errutil to apimachinery module (#89116) 2024-06-13 07:11:35 +03:00
user_token_test.go
utils.go User: use update function for password updates (#86419) 2024-04-17 15:24:36 +02:00

README.md

OpenAPI specifications

Since version 8.4, HTTP API details are specified using OpenAPI v2. Starting from version 9.1, there is also an OpenAPI v3 specification (generated by the v2 one using this script).

OpenAPI annotations

The OpenAPI v2 specification is generated automatically from the annotated Go code using go-swagger which scans the source code for annotation rules. Refer to this getting started guide for getting familiar with the toolkit.

Developers modifying the HTTP API endpoints need to make sure to add the necessary annotations so that their changes are reflected into the generated specifications.

Example of endpoint annotation

The following route defines a PATCH endpoint under the /serviceaccounts/{serviceAccountId} path with tag service_accounts (used for grouping together several routes) and operation ID updateServiceAccount (used for uniquely identifying routes and associate parameters and response with them).


// swagger:route PATCH /serviceaccounts/{serviceAccountId} service_accounts updateServiceAccount
//
// # Update service account
//
// Required permissions (See note in the [introduction](https://grafana.com/docs/grafana/latest/developers/http_api/serviceaccount/#service-account-api) for an explanation):
// action: `serviceaccounts:write` scope: `serviceaccounts:id:1` (single service account)
//
// Responses:
// 200: updateServiceAccountResponse
// 400: badRequestError
// 401: unauthorisedError
// 403: forbiddenError
// 404: notFoundError
// 500: internalServerError

The go-swagger can discover such annotations by scanning any code imported by pkg/server but by convention we place the endpoint annotations above the endpoint definition.

Example of endpoint parameters

The following struct defines the route parameters for the updateServiceAccount endpoint. The route expects:

  • a path parameter denoting the service account identifier and
  • a body parameter with the new values for the specific service account

// swagger:parameters updateServiceAccount
type UpdateServiceAccountParams struct {
	// in:path
	ServiceAccountId int64 `json:"serviceAccountId"`
	// in:body
	Body serviceaccounts.UpdateServiceAccountForm
}

Example of endpoint response

The following struct defines the response for the updateServiceAccount endpoint in case of a successful 200 response.


// swagger:response updateServiceAccountResponse
type UpdateServiceAccountResponse struct {
	// in:body
	Body struct {
		Message        string                                    `json:"message"`
		ID             int64                                     `json:"id"`
		Name           string                                    `json:"name"`
		ServiceAccount *serviceaccounts.ServiceAccountProfileDTO `json:"serviceaccount"`
	}
}

OpenAPI generation

Developers can re-create the OpenAPI v2 and v3 specifications using the following command:

make swagger-clean && make openapi3-gen

They can observe its output into the public/api-merged.json and public/openapi3.json files.

Finally, they can browser and try out both the OpenAPI v2 and v3 via the Swagger UI editor (served by the grafana server) by navigating to /swagger.

If there are any issues generating the specifications (e.g., diff containing unrelated changes to your PR or unusually large diff), please run the following two commands to ensure your Swagger version is up to date, then re-run the make commands.

  • go install github.com/bwplotka/bingo@latest
  • bingo get github.com/go-swagger/go-swagger/cmd/swagger@v0.30.2