grafana/pkg/api
Gabriel MABILLE 6b954165c5
RBAC: Cover plugin routes (#80578)
* RBAC: Cover plugin routes

* Action instead of ReqAction

* Fix test initializations

* Fix NewPluginProxy call

* Duplicate test to add RBAC checks

* Cover legacy access control as well

* Fix typo

* action -> reqAction

* Add example

Co-authored-by: Andres Martinez Gotor <andres.martinez@grafana.com>

---------

Co-authored-by: Andres Martinez Gotor <andres.martinez@grafana.com>
2024-01-17 16:32:23 +01:00
..
apierrors Alerting: Fix deleting rules in a folder with matching UID in another organization (#78258) 2023-12-04 11:34:38 +02:00
avatar
datasource mssql: prepare logs-handling for decouple-datasource changes (#79214) 2023-12-11 09:14:06 +01:00
dtos K8s: Add dashboard service (requires dev mode) (#78565) 2024-01-11 01:20:30 +02:00
frontendlogging
pluginproxy RBAC: Cover plugin routes (#80578) 2024-01-17 16:32:23 +01:00
response
routing
static
webassets Frontend: Reload the browser when backend configuration/assets change (#79057) 2024-01-04 08:00:07 +01:00
README.md Chore: Update OpenAPI generation README to include bingo instructions (#79104) 2024-01-02 12:48:10 +01:00
accesscontrol.go RBAC: change annotation scopes back (#79330) 2023-12-12 09:51:08 +02:00
admin.go Anonymous: Add device limits to stats (#79494) 2023-12-18 09:32:57 +01:00
admin_encryption.go
admin_provisioning.go
admin_provisioning_test.go
admin_test.go Auth: Add anonymous users view and stats (#78685) 2023-11-29 17:58:41 +01:00
admin_users.go User: Verify external user status for accessing certain user routes (#79909) 2023-12-29 14:23:05 +01:00
admin_users_test.go Chore: Configure SkipOrgRoleSync from OAuthInfo for OAuth connectors (#79443) 2023-12-15 10:58:08 +01:00
alerting.go Alerting: Separate overlapping legacy and UA alerting routes (#76517) 2024-01-04 18:01:57 -05:00
annotations.go FeatureFlags: Use interface rather than manager (#80000) 2024-01-09 10:38:06 -08:00
annotations_test.go Annotations: Remove dashboard permission checks for annotations (#78352) 2023-11-23 10:47:37 +00:00
api.go Alerting: Separate overlapping legacy and UA alerting routes (#76517) 2024-01-04 18:01:57 -05:00
apikey.go
basic_auth.go
basic_auth_test.go
common_test.go FeatureFlags: Use interface rather than manager (#80000) 2024-01-09 10:38:06 -08:00
dashboard.go K8s: Add dashboard service (requires dev mode) (#78565) 2024-01-11 01:20:30 +02:00
dashboard_permission.go Authz: Remove use of SignedInUser copy for permission evaluation (#78448) 2023-11-22 14:20:22 +01:00
dashboard_permission_test.go
dashboard_snapshot.go
dashboard_snapshot_test.go
dashboard_test.go Remove deprecated FolderID from api tests (#79466) 2023-12-20 15:12:05 +01:00
dataproxy.go
datasources.go FeatureFlags: Use interface rather than manager (#80000) 2024-01-09 10:38:06 -08:00
datasources_test.go Team LBAC: Limit access to data source (#78376) 2023-12-05 13:45:40 +02:00
fakes.go Plugins: Make renderer service load renderer plugin (#77854) 2023-12-14 17:33:29 +01:00
featuremgmt.go FeatureFlags: Use interface rather than manager (#80000) 2024-01-09 10:38:06 -08:00
featuremgmt_test.go FeatureFlags: Remove enabled from FeatureFlag model (#79960) 2024-01-10 21:34:18 -08:00
folder.go Chore: Remove extra loop over folders in GetFolders handler (#79933) 2024-01-16 12:35:10 +01:00
folder_bench_test.go FeatureFlags: Use interface rather than manager (#80000) 2024-01-09 10:38:06 -08:00
folder_permission.go Authz: Remove use of SignedInUser copy for permission evaluation (#78448) 2023-11-22 14:20:22 +01:00
folder_permission_test.go Remove deprecated FolderID from api tests (#79466) 2023-12-20 15:12:05 +01:00
folder_test.go FeatureFlags: Use interface rather than manager (#80000) 2024-01-09 10:38:06 -08:00
frontend_logging.go
frontend_logging_test.go
frontend_metrics.go
frontendsettings.go Auth: Hide forgot password if grafana auth is disabled (#79895) 2024-01-04 10:46:55 +01:00
frontendsettings_test.go FeatureFlags: Use interface rather than manager (#80000) 2024-01-09 10:38:06 -08:00
grafana_com_proxy.go
health.go
health_test.go
http_server.go FeatureFlags: Use interface rather than manager (#80000) 2024-01-09 10:38:06 -08:00
http_server_test.go
index.go index: Fetch auth module and provide it to front-end (#80345) 2024-01-11 11:37:52 +01:00
login.go Authn: Handle logout logic in auth broker (#79635) 2023-12-19 10:17:28 +01:00
login_oauth.go
login_oauth_test.go
login_test.go Frontend: Reload the browser when backend configuration/assets change (#79057) 2024-01-04 08:00:07 +01:00
metrics.go FeatureToggles: Add context and and an explicit global check (#78081) 2023-11-14 12:50:27 -08:00
metrics_test.go
org.go
org_invite.go
org_invite_test.go
org_test.go
org_users.go Chore: Configure SkipOrgRoleSync from OAuthInfo for OAuth connectors (#79443) 2023-12-15 10:58:08 +01:00
org_users_test.go Chore: Configure SkipOrgRoleSync from OAuthInfo for OAuth connectors (#79443) 2023-12-15 10:58:08 +01:00
password.go User: Verify external user status for accessing certain user routes (#79909) 2023-12-29 14:23:05 +01:00
playlist.go K8s: Add resource type helper to avoid so many hardcoded names (#79344) 2023-12-11 22:03:48 +02:00
plugin_checks.go Chore: Evaluate if an app is disabled for API requests (#79564) 2023-12-15 16:37:39 +01:00
plugin_checks_test.go Chore: Evaluate if an app is disabled for API requests (#79564) 2023-12-15 16:37:39 +01:00
plugin_dashboards.go
plugin_dashboards_test.go Chore: Evaluate if an app is disabled for API requests (#79564) 2023-12-15 16:37:39 +01:00
plugin_metrics.go
plugin_metrics_test.go
plugin_proxy.go RBAC: Cover plugin routes (#80578) 2024-01-17 16:32:23 +01:00
plugin_proxy_test.go
plugin_resource.go
plugin_resource_test.go Plugins: Add Grafana config to app plugin context (#79439) 2023-12-13 10:28:24 +01:00
plugins.go Plugins: Display plugin permissions required (#78355) 2023-12-20 16:29:13 +01:00
plugins_test.go Plugins: Rename `externalServiceAuthentication` to `iam` (#78686) 2023-12-04 13:14:21 +01:00
preferences.go
preferences_test.go
quota.go
quota_test.go
render.go Export: Remove no-store headers in pdf and image previews (#78844) 2023-12-18 09:21:57 -03:00
search.go Authz: Remove use of SignedInUser copy for permission evaluation (#78448) 2023-11-22 14:20:22 +01:00
short_url.go
short_url_test.go
signup.go
swagger.go Swagger: Show k8s APIs (#78091) 2023-11-15 06:42:35 -08:00
swagger_responses.go
swagger_tags.json
user.go User: Verify external user status for accessing certain user routes (#79909) 2023-12-29 14:23:05 +01:00
user_test.go Chore: Configure SkipOrgRoleSync from OAuthInfo for OAuth connectors (#79443) 2023-12-15 10:58:08 +01:00
user_token.go Auth: Add more context to logs around token rotation, revocation (#78600) 2023-11-23 16:48:54 +01:00
user_token_test.go
utils.go

README.md

OpenAPI specifications

Since version 8.4, HTTP API details are specified using OpenAPI v2. Starting from version 9.1, there is also an OpenAPI v3 specification (generated by the v2 one using this script).

OpenAPI annotations

The OpenAPI v2 specification is generated automatically from the annotated Go code using go-swagger which scans the source code for annotation rules. Refer to this getting started guide for getting familiar with the toolkit.

Developers modifying the HTTP API endpoints need to make sure to add the necessary annotations so that their changes are reflected into the generated specifications.

Example of endpoint annotation

The following route defines a PATCH endpoint under the /serviceaccounts/{serviceAccountId} path with tag service_accounts (used for grouping together several routes) and operation ID updateServiceAccount (used for uniquely identifying routes and associate parameters and response with them).


// swagger:route PATCH /serviceaccounts/{serviceAccountId} service_accounts updateServiceAccount
//
// # Update service account
//
// Required permissions (See note in the [introduction](https://grafana.com/docs/grafana/latest/developers/http_api/serviceaccount/#service-account-api) for an explanation):
// action: `serviceaccounts:write` scope: `serviceaccounts:id:1` (single service account)
//
// Responses:
// 200: updateServiceAccountResponse
// 400: badRequestError
// 401: unauthorisedError
// 403: forbiddenError
// 404: notFoundError
// 500: internalServerError

The go-swagger can discover such annotations by scanning any code imported by pkg/server but by convention we place the endpoint annotations above the endpoint definition.

Example of endpoint parameters

The following struct defines the route parameters for the updateServiceAccount endpoint. The route expects:

  • a path parameter denoting the service account identifier and
  • a body parameter with the new values for the specific service account

// swagger:parameters updateServiceAccount
type UpdateServiceAccountParams struct {
	// in:path
	ServiceAccountId int64 `json:"serviceAccountId"`
	// in:body
	Body serviceaccounts.UpdateServiceAccountForm
}

Example of endpoint response

The following struct defines the response for the updateServiceAccount endpoint in case of a successful 200 response.


// swagger:response updateServiceAccountResponse
type UpdateServiceAccountResponse struct {
	// in:body
	Body struct {
		Message        string                                    `json:"message"`
		ID             int64                                     `json:"id"`
		Name           string                                    `json:"name"`
		ServiceAccount *serviceaccounts.ServiceAccountProfileDTO `json:"serviceaccount"`
	}
}

OpenAPI generation

Developers can re-create the OpenAPI v2 and v3 specifications using the following command:

make swagger-clean && make openapi3-gen

They can observe its output into the public/api-merged.json and public/openapi3.json files.

Finally, they can browser and try out both the OpenAPI v2 and v3 via the Swagger UI editor (served by the grafana server) by navigating to /swagger.

If there are any issues generating the specifications (e.g., diff containing unrelated changes to your PR or unusually large diff), please run the following two commands to ensure your Swagger version is up to date, then re-run the make commands.

  • go install github.com/bwplotka/bingo@latest
  • bingo get swagger