freeze all freezable strings

This commit is contained in:
Ryan Buckley 2015-12-11 22:16:05 -08:00
parent 8182172baf
commit 2e2b14e557
1 changed files with 5 additions and 5 deletions

View File

@ -15,7 +15,7 @@ class Grape::Middleware::Logger < Grape::Middleware::Globals
start_time start_time
# sets env['grape.*'] # sets env['grape.*']
super super
logger.info '' logger.info ''.freeze
logger.info %Q(Started %s "%s" at %s) % [ logger.info %Q(Started %s "%s" at %s) % [
env[Grape::Env::GRAPE_REQUEST].request_method, env[Grape::Env::GRAPE_REQUEST].request_method,
env[Grape::Env::GRAPE_REQUEST].path, env[Grape::Env::GRAPE_REQUEST].path,
@ -57,7 +57,7 @@ class Grape::Middleware::Logger < Grape::Middleware::Globals
def after(status) def after(status)
logger.info "Completed #{status} in #{((Time.now - start_time) * 1000).round(2)}ms" logger.info "Completed #{status} in #{((Time.now - start_time) * 1000).round(2)}ms"
logger.info '' logger.info ''.freeze
end end
# #
@ -76,7 +76,7 @@ class Grape::Middleware::Logger < Grape::Middleware::Globals
def parameters def parameters
request_params = env[Grape::Env::GRAPE_REQUEST_PARAMS].to_hash request_params = env[Grape::Env::GRAPE_REQUEST_PARAMS].to_hash
request_params.merge!(env['action_dispatch.request.request_parameters'] || {}) # for Rails request_params.merge!(env['action_dispatch.request.request_parameters'.freeze] || {}) # for Rails
if @options[:filter] if @options[:filter]
@options[:filter].filter(request_params) @options[:filter].filter(request_params)
else else
@ -91,8 +91,8 @@ class Grape::Middleware::Logger < Grape::Middleware::Globals
def processed_by def processed_by
endpoint = env[Grape::Env::API_ENDPOINT] endpoint = env[Grape::Env::API_ENDPOINT]
parts = endpoint.options[:for].to_s parts = endpoint.options[:for].to_s
parts << endpoint.namespace if endpoint.namespace != '/' parts << endpoint.namespace if endpoint.namespace != '/'.freeze
parts << '#' << endpoint.options[:path].map { |path| path.to_s.sub('/', '') }.join('/') parts << '#'.freeze << endpoint.options[:path].map { |path| path.to_s.sub('/', '') }.join('/')
end end
def default_logger def default_logger