diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a67d95c9e..37627e716 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -259,7 +259,7 @@ Like any good open source project, we use Pull Requests (PRs) to track code chan maintainers before it can be merged. Those with `size/XS` are per the judgement of the maintainers. For more detail see the [Size Labels](#size-labels) section. 4. Reviewing/Discussion - - All reviews will be completed using Github review tool. + - All reviews will be completed using GitHub review tool. - A "Comment" review should be used when there are questions about the code that should be answered, but that don't involve code changes. This type of review does not count as approval. - A "Changes Requested" review indicates that changes to the code need to be made before they diff --git a/Makefile b/Makefile index b76431c7b..d897bc939 100644 --- a/Makefile +++ b/Makefile @@ -25,7 +25,7 @@ TESTFLAGS := LDFLAGS := -w -s GOFLAGS := -# Rebuild the buinary if any of these files change +# Rebuild the binary if any of these files change SRC := $(shell find . -type f -name '*.go' -print) go.mod go.sum # Required for globs to work correctly diff --git a/README.md b/README.md index 7d2958f5e..5ae421183 100644 --- a/README.md +++ b/README.md @@ -54,7 +54,7 @@ Get started with the [Quick Start guide](https://helm.sh/docs/intro/quickstart/) ## Roadmap -The [Helm roadmap uses Github milestones](https://github.com/helm/helm/milestones) to track the progress of the project. +The [Helm roadmap uses GitHub milestones](https://github.com/helm/helm/milestones) to track the progress of the project. ## Community, discussion, contribution, and support diff --git a/cmd/helm/dependency_update_test.go b/cmd/helm/dependency_update_test.go index 896018735..9f7b0f303 100644 --- a/cmd/helm/dependency_update_test.go +++ b/cmd/helm/dependency_update_test.go @@ -150,7 +150,7 @@ func TestDependencyUpdateCmd(t *testing.T) { } } -func TestDependencyUpdateCmd_DontDeleteOldChartsOnError(t *testing.T) { +func TestDependencyUpdateCmd_DoNotDeleteOldChartsOnError(t *testing.T) { defer resetEnv()() defer ensure.HelmHome(t)() diff --git a/cmd/helm/root.go b/cmd/helm/root.go index de24a6208..285c80021 100644 --- a/cmd/helm/root.go +++ b/cmd/helm/root.go @@ -98,7 +98,7 @@ func newRootCmd(actionConfig *action.Configuration, out io.Writer, args []string // Setup shell completion for the namespace flag err := cmd.RegisterFlagCompletionFunc("namespace", func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) { if client, err := actionConfig.KubernetesClientSet(); err == nil { - // Choose a long enough timeout that the user notices somethings is not working + // Choose a long enough timeout that the user notices something is not working // but short enough that the user is not made to wait very long to := int64(3) cobra.CompDebugln(fmt.Sprintf("About to call kube client for namespaces with timeout of: %d", to), settings.Debug) diff --git a/cmd/helm/root_unix.go b/cmd/helm/root_unix.go index b1b0f3896..3df801e4c 100644 --- a/cmd/helm/root_unix.go +++ b/cmd/helm/root_unix.go @@ -27,7 +27,7 @@ import ( func checkPerms() { // This function MUST NOT FAIL, as it is just a check for a common permissions problem. // If for some reason the function hits a stopping condition, it may panic. But only if - // we can be sure that it is panicing because Helm cannot proceed. + // we can be sure that it is panicking because Helm cannot proceed. kc := settings.KubeConfig if kc == "" { diff --git a/cmd/helm/search_hub_test.go b/cmd/helm/search_hub_test.go index 9fc21cab8..ae51b6a3e 100644 --- a/cmd/helm/search_hub_test.go +++ b/cmd/helm/search_hub_test.go @@ -56,5 +56,5 @@ func TestSearchHubOutputCompletion(t *testing.T) { } func TestSearchHubFileCompletion(t *testing.T) { - checkFileCompletion(t, "search hub", true) // File completion may be useful when inputing a keyword + checkFileCompletion(t, "search hub", true) // File completion may be useful when inputting a keyword } diff --git a/cmd/helm/search_repo_test.go b/cmd/helm/search_repo_test.go index 39c9c53f5..58ba3a715 100644 --- a/cmd/helm/search_repo_test.go +++ b/cmd/helm/search_repo_test.go @@ -89,5 +89,5 @@ func TestSearchRepoOutputCompletion(t *testing.T) { } func TestSearchRepoFileCompletion(t *testing.T) { - checkFileCompletion(t, "search repo", true) // File completion may be useful when inputing a keyword + checkFileCompletion(t, "search repo", true) // File completion may be useful when inputting a keyword } diff --git a/cmd/helm/template.go b/cmd/helm/template.go index d760fb87b..1110771f0 100644 --- a/cmd/helm/template.go +++ b/cmd/helm/template.go @@ -188,7 +188,7 @@ func isTestHook(h *release.Hook) bool { } // The following functions (writeToFile, createOrOpenFile, and ensureDirectoryForFile) -// are coppied from the actions package. This is part of a change to correct a +// are copied from the actions package. This is part of a change to correct a // bug introduced by #8156. As part of the todo to refactor renderResources // this duplicate code should be removed. It is added here so that the API // surface area is as minimally impacted as possible in fixing the issue. diff --git a/cmd/helm/testdata/testcharts/chart-with-template-lib-dep/charts/common/templates/_ingress.yaml b/cmd/helm/testdata/testcharts/chart-with-template-lib-dep/charts/common/templates/_ingress.yaml index 522ab2425..78411e15b 100755 --- a/cmd/helm/testdata/testcharts/chart-with-template-lib-dep/charts/common/templates/_ingress.yaml +++ b/cmd/helm/testdata/testcharts/chart-with-template-lib-dep/charts/common/templates/_ingress.yaml @@ -4,7 +4,7 @@ kind: Ingress {{ template "common.metadata" . }} {{- if .Values.ingress.annotations }} annotations: - {{ include "common.annote" .Values.ingress.annotations | indent 4 }} + {{ include "common.annotate" .Values.ingress.annotations | indent 4 }} {{- end }} spec: rules: diff --git a/cmd/helm/testdata/testcharts/chart-with-template-lib-dep/charts/common/templates/_metadata_annotations.tpl b/cmd/helm/testdata/testcharts/chart-with-template-lib-dep/charts/common/templates/_metadata_annotations.tpl index 0c3b61c7c..dffe1eca9 100755 --- a/cmd/helm/testdata/testcharts/chart-with-template-lib-dep/charts/common/templates/_metadata_annotations.tpl +++ b/cmd/helm/testdata/testcharts/chart-with-template-lib-dep/charts/common/templates/_metadata_annotations.tpl @@ -11,7 +11,7 @@ Any valid hook may be passed in. Separate multiple hooks with a ",". "helm.sh/hook": {{printf "%s" . | quote}} {{- end -}} -{{- define "common.annote" -}} +{{- define "common.annotate" -}} {{- range $k, $v := . }} {{ $k | quote }}: {{ $v | quote }} {{- end -}} diff --git a/cmd/helm/testdata/testcharts/lib-chart/templates/_ingress.yaml b/cmd/helm/testdata/testcharts/lib-chart/templates/_ingress.yaml index 522ab2425..78411e15b 100644 --- a/cmd/helm/testdata/testcharts/lib-chart/templates/_ingress.yaml +++ b/cmd/helm/testdata/testcharts/lib-chart/templates/_ingress.yaml @@ -4,7 +4,7 @@ kind: Ingress {{ template "common.metadata" . }} {{- if .Values.ingress.annotations }} annotations: - {{ include "common.annote" .Values.ingress.annotations | indent 4 }} + {{ include "common.annotate" .Values.ingress.annotations | indent 4 }} {{- end }} spec: rules: diff --git a/cmd/helm/testdata/testcharts/lib-chart/templates/_metadata_annotations.tpl b/cmd/helm/testdata/testcharts/lib-chart/templates/_metadata_annotations.tpl index 0c3b61c7c..dffe1eca9 100644 --- a/cmd/helm/testdata/testcharts/lib-chart/templates/_metadata_annotations.tpl +++ b/cmd/helm/testdata/testcharts/lib-chart/templates/_metadata_annotations.tpl @@ -11,7 +11,7 @@ Any valid hook may be passed in. Separate multiple hooks with a ",". "helm.sh/hook": {{printf "%s" . | quote}} {{- end -}} -{{- define "common.annote" -}} +{{- define "common.annotate" -}} {{- range $k, $v := . }} {{ $k | quote }}: {{ $v | quote }} {{- end -}} diff --git a/internal/resolver/resolver_test.go b/internal/resolver/resolver_test.go index f59188508..204a72622 100644 --- a/internal/resolver/resolver_test.go +++ b/internal/resolver/resolver_test.go @@ -96,7 +96,7 @@ func TestResolve(t *testing.T) { { name: "repo from invalid local path", req: []*chart.Dependency{ - {Name: "notexist", Repository: "file://testdata/notexist", Version: "0.1.0"}, + {Name: "nonexistent", Repository: "file://testdata/nonexistent", Version: "0.1.0"}, }, err: true, }, @@ -255,7 +255,7 @@ func TestGetLocalPath(t *testing.T) { }, { name: "invalid local path", - repo: "file://testdata/notexist", + repo: "file://testdata/nonexistent", chartpath: "testdata/chartpath", err: true, }, diff --git a/internal/test/test.go b/internal/test/test.go index b0f624521..646037606 100644 --- a/internal/test/test.go +++ b/internal/test/test.go @@ -58,7 +58,7 @@ func AssertGoldenString(t TestingT, actual, filename string) { } } -// AssertGoldenFile assers that the content of the actual file matches the contents of the expected file +// AssertGoldenFile asserts that the content of the actual file matches the contents of the expected file func AssertGoldenFile(t TestingT, actualFileName string, expectedFilename string) { t.Helper() diff --git a/internal/tlsutil/tlsutil_test.go b/internal/tlsutil/tlsutil_test.go index 24551fdec..e660c030c 100644 --- a/internal/tlsutil/tlsutil_test.go +++ b/internal/tlsutil/tlsutil_test.go @@ -46,7 +46,7 @@ func TestClientConfig(t *testing.T) { t.Fatalf("expecting 1 client certificates, got %d", got) } if cfg.InsecureSkipVerify { - t.Fatalf("insecure skip verify mistmatch, expecting false") + t.Fatalf("insecure skip verify mismatch, expecting false") } if cfg.RootCAs == nil { t.Fatalf("mismatch tls RootCAs, expecting non-nil") @@ -75,7 +75,7 @@ func TestNewClientTLS(t *testing.T) { t.Fatalf("expecting 1 client certificates, got %d", got) } if cfg.InsecureSkipVerify { - t.Fatalf("insecure skip verify mistmatch, expecting false") + t.Fatalf("insecure skip verify mismatch, expecting false") } if cfg.RootCAs == nil { t.Fatalf("mismatch tls RootCAs, expecting non-nil") @@ -90,7 +90,7 @@ func TestNewClientTLS(t *testing.T) { t.Fatalf("expecting 0 client certificates, got %d", got) } if cfg.InsecureSkipVerify { - t.Fatalf("insecure skip verify mistmatch, expecting false") + t.Fatalf("insecure skip verify mismatch, expecting false") } if cfg.RootCAs == nil { t.Fatalf("mismatch tls RootCAs, expecting non-nil") @@ -105,7 +105,7 @@ func TestNewClientTLS(t *testing.T) { t.Fatalf("expecting 1 client certificates, got %d", got) } if cfg.InsecureSkipVerify { - t.Fatalf("insecure skip verify mistmatch, expecting false") + t.Fatalf("insecure skip verify mismatch, expecting false") } if cfg.RootCAs != nil { t.Fatalf("mismatch tls RootCAs, expecting nil") diff --git a/pkg/action/dependency.go b/pkg/action/dependency.go index 4c80d0159..578a46aec 100644 --- a/pkg/action/dependency.go +++ b/pkg/action/dependency.go @@ -62,14 +62,14 @@ func (d *Dependency) List(chartpath string, out io.Writer) error { return nil } -// dependecyStatus returns a string describing the status of a dependency viz a viz the parent chart. +// dependencyStatus returns a string describing the status of a dependency viz a viz the parent chart. func (d *Dependency) dependencyStatus(chartpath string, dep *chart.Dependency, parent *chart.Chart) string { filename := fmt.Sprintf("%s-%s.tgz", dep.Name, "*") // If a chart is unpacked, this will check the unpacked chart's `charts/` directory for tarballs. // Technically, this is COMPLETELY unnecessary, and should be removed in Helm 4. It is here // to preserved backward compatibility. In Helm 2/3, there is a "difference" between - // the tgz version (which outputs "ok" if it unpacks) and the loaded version (which outouts + // the tgz version (which outputs "ok" if it unpacks) and the loaded version (which outputs // "unpacked"). Early in Helm 2's history, this would have made a difference. But it no // longer does. However, since this code shipped with Helm 3, the output must remain stable // until Helm 4. diff --git a/pkg/action/upgrade.go b/pkg/action/upgrade.go index b0f294cae..3b3dd3f1c 100644 --- a/pkg/action/upgrade.go +++ b/pkg/action/upgrade.go @@ -94,7 +94,7 @@ type Upgrade struct { // PostRender is an optional post-renderer // // If this is non-nil, then after templates are rendered, they will be sent to the - // post renderer before sending to the Kuberntes API server. + // post renderer before sending to the Kubernetes API server. PostRenderer postrender.PostRenderer // DisableOpenAPIValidation controls whether OpenAPI validation is enforced. DisableOpenAPIValidation bool diff --git a/pkg/chartutil/dependencies_test.go b/pkg/chartutil/dependencies_test.go index dff51a7a5..bcb1d40e5 100644 --- a/pkg/chartutil/dependencies_test.go +++ b/pkg/chartutil/dependencies_test.go @@ -190,13 +190,13 @@ func TestProcessDependencyImportValues(t *testing.T) { e["overridden-chartA.SCAbool"] = "true" e["overridden-chartA.SCAfloat"] = "41.3" e["overridden-chartA.SCAint"] = "808" - e["overridden-chartA.SCAstring"] = "jaberwocky" + e["overridden-chartA.SCAstring"] = "jabberwocky" e["overridden-chartA.SPextra4"] = "true" e["overridden-chartA-B.SCAbool"] = "true" e["overridden-chartA-B.SCAfloat"] = "41.3" e["overridden-chartA-B.SCAint"] = "808" - e["overridden-chartA-B.SCAstring"] = "jaberwocky" + e["overridden-chartA-B.SCAstring"] = "jabberwocky" e["overridden-chartA-B.SCBbool"] = "false" e["overridden-chartA-B.SCBfloat"] = "1.99" e["overridden-chartA-B.SCBint"] = "77" diff --git a/pkg/chartutil/save_test.go b/pkg/chartutil/save_test.go index 23c3f9467..b4951535a 100644 --- a/pkg/chartutil/save_test.go +++ b/pkg/chartutil/save_test.go @@ -102,7 +102,7 @@ func TestSave(t *testing.T) { t.Fatal(err) } if c2.Lock == nil { - t.Fatal("Expected v2 chart archive to containe a Chart.lock file") + t.Fatal("Expected v2 chart archive to contain a Chart.lock file") } if c2.Lock.Digest != c.Lock.Digest { t.Fatal("Chart.lock data did not match") diff --git a/pkg/chartutil/testdata/subpop/values.yaml b/pkg/chartutil/testdata/subpop/values.yaml index 4e5022b4e..d611d6a89 100644 --- a/pkg/chartutil/testdata/subpop/values.yaml +++ b/pkg/chartutil/testdata/subpop/values.yaml @@ -18,7 +18,7 @@ overridden-chartA: SCAbool: true SCAfloat: 41.3 SCAint: 808 - SCAstring: "jaberwocky" + SCAstring: "jabberwocky" SPextra4: true imported-chartA-B: @@ -28,7 +28,7 @@ overridden-chartA-B: SCAbool: true SCAfloat: 41.3 SCAint: 808 - SCAstring: "jaberwocky" + SCAstring: "jabberwocky" SCBbool: false SCBfloat: 1.99 SCBint: 77 diff --git a/pkg/chartutil/validate_name.go b/pkg/chartutil/validate_name.go index 913a477cf..a2dcd432c 100644 --- a/pkg/chartutil/validate_name.go +++ b/pkg/chartutil/validate_name.go @@ -61,7 +61,7 @@ const ( // ValidateReleaseName performs checks for an entry for a Helm release name // // For Helm to allow a name, it must be below a certain character count (53) and also match -// a reguar expression. +// a regular expression. // // According to the Kubernetes help text, the regular expression it uses is: // diff --git a/pkg/downloader/manager.go b/pkg/downloader/manager.go index d2d3e9f31..e89ac7c02 100644 --- a/pkg/downloader/manager.go +++ b/pkg/downloader/manager.go @@ -176,7 +176,7 @@ func (m *Manager) Update() error { // TODO(mattfarina): Repositories should be explicitly added by end users // rather than automattic. In Helm v4 require users to add repositories. They // should have to add them in order to make sure they are aware of the - // respoitories and opt-in to any locations, for security. + // repositories and opt-in to any locations, for security. repoNames, err = m.ensureMissingRepos(repoNames, req) if err != nil { return err diff --git a/pkg/engine/engine_test.go b/pkg/engine/engine_test.go index 87e84c48b..d2da7a77a 100644 --- a/pkg/engine/engine_test.go +++ b/pkg/engine/engine_test.go @@ -160,7 +160,7 @@ func TestRenderRefsOrdering(t *testing.T) { for name, data := range expect { if out[name] != data { - t.Fatalf("Expected %q, got %q (iteraction %d)", data, out[name], i+1) + t.Fatalf("Expected %q, got %q (iteration %d)", data, out[name], i+1) } } } diff --git a/pkg/engine/lookup_func.go b/pkg/engine/lookup_func.go index 20be9189e..cd3883c0f 100644 --- a/pkg/engine/lookup_func.go +++ b/pkg/engine/lookup_func.go @@ -80,7 +80,7 @@ func NewLookupFunction(config *rest.Config) lookupFunc { // getDynamicClientOnUnstructured returns a dynamic client on an Unstructured type. This client can be further namespaced. func getDynamicClientOnKind(apiversion string, kind string, config *rest.Config) (dynamic.NamespaceableResourceInterface, bool, error) { gvk := schema.FromAPIVersionAndKind(apiversion, kind) - apiRes, err := getAPIReourceForGVK(gvk, config) + apiRes, err := getAPIResourceForGVK(gvk, config) if err != nil { log.Printf("[ERROR] unable to get apiresource from unstructured: %s , error %s", gvk.String(), err) return nil, false, errors.Wrapf(err, "unable to get apiresource from unstructured: %s", gvk.String()) @@ -99,7 +99,7 @@ func getDynamicClientOnKind(apiversion string, kind string, config *rest.Config) return res, apiRes.Namespaced, nil } -func getAPIReourceForGVK(gvk schema.GroupVersionKind, config *rest.Config) (metav1.APIResource, error) { +func getAPIResourceForGVK(gvk schema.GroupVersionKind, config *rest.Config) (metav1.APIResource, error) { res := metav1.APIResource{} discoveryClient, err := discovery.NewDiscoveryClientForConfig(config) if err != nil { diff --git a/pkg/getter/httpgetter_test.go b/pkg/getter/httpgetter_test.go index 3aab22abe..ad97898cb 100644 --- a/pkg/getter/httpgetter_test.go +++ b/pkg/getter/httpgetter_test.go @@ -233,7 +233,7 @@ func TestDownloadInsecureSkipTLSVerify(t *testing.T) { u, _ := url.ParseRequestURI(ts.URL) - // Ensure the default behaviour did not change + // Ensure the default behavior did not change g, err := NewHTTPGetter( WithURL(u.String()), ) diff --git a/pkg/lint/rules/template.go b/pkg/lint/rules/template.go index 10121c108..23f6accd1 100644 --- a/pkg/lint/rules/template.go +++ b/pkg/lint/rules/template.go @@ -152,7 +152,7 @@ func Templates(linter *support.Linter, values map[string]interface{}, namespace // validateTopIndentLevel checks that the content does not start with an indent level > 0. // // This error can occur when a template accidentally inserts space. It can cause -// unpredictable errors dependening on whether the text is normalized before being passed +// unpredictable errors depending on whether the text is normalized before being passed // into the YAML parser. So we trap it here. // // See https://github.com/helm/helm/issues/8467 diff --git a/pkg/lint/rules/template_test.go b/pkg/lint/rules/template_test.go index eb076a1bf..0ed64ad81 100644 --- a/pkg/lint/rules/template_test.go +++ b/pkg/lint/rules/template_test.go @@ -208,7 +208,7 @@ data: myval2: {{default "val" .Values.mymap.key2 }} ` -// TestSTrictTemplatePrasingMapError is a regression test. +// TestStrictTemplateParsingMapError is a regression test. // // The template engine should not produce an error when a map in values.yaml does // not contain all possible keys. diff --git a/pkg/plugin/plugin_test.go b/pkg/plugin/plugin_test.go index 2c4478953..2bbdff21d 100644 --- a/pkg/plugin/plugin_test.go +++ b/pkg/plugin/plugin_test.go @@ -289,7 +289,7 @@ func TestFindPlugins(t *testing.T) { expected: 0, }, { - name: "plugdirs doens't have plugin", + name: "plugdirs doesn't have plugin", plugdirs: ".", expected: 0, }, diff --git a/pkg/postrender/exec.go b/pkg/postrender/exec.go index 0860e7c35..1de70b024 100644 --- a/pkg/postrender/exec.go +++ b/pkg/postrender/exec.go @@ -72,7 +72,7 @@ func (p *execRender) Run(renderedManifests *bytes.Buffer) (*bytes.Buffer, error) func getFullPath(binaryPath string) (string, error) { // NOTE(thomastaylor312): I am leaving this code commented out here. During // the implementation of post-render, it was brought up that if we are - // relying on plguins, we should actually use the plugin system so it can + // relying on plugins, we should actually use the plugin system so it can // properly handle multiple OSs. This will be a feature add in the future, // so I left this code for reference. It can be deleted or reused once the // feature is implemented @@ -85,7 +85,7 @@ func getFullPath(binaryPath string) (string, error) { // if v, ok := os.LookupEnv("HELM_PLUGINS"); ok { // pluginDir = v // } - // // The plugins variable can actually contain multple paths, so loop through those + // // The plugins variable can actually contain multiple paths, so loop through those // for _, p := range filepath.SplitList(pluginDir) { // _, err := os.Stat(filepath.Join(p, binaryPath)) // if err != nil && !os.IsNotExist(err) { diff --git a/pkg/release/hook.go b/pkg/release/hook.go index 662320f06..cb9955582 100644 --- a/pkg/release/hook.go +++ b/pkg/release/hook.go @@ -102,5 +102,5 @@ const ( HookPhaseFailed HookPhase = "Failed" ) -// Strng converts a hook phase to a printable string +// String converts a hook phase to a printable string func (x HookPhase) String() string { return string(x) } diff --git a/pkg/repo/index.go b/pkg/repo/index.go index 5adaf5530..e86b17349 100644 --- a/pkg/repo/index.go +++ b/pkg/repo/index.go @@ -267,7 +267,7 @@ type ChartVersion struct { // YAML parser enabled, this field must be present. TillerVersionDeprecated string `json:"tillerVersion,omitempty"` - // URLDeprecated is deprectaed in Helm 3, superseded by URLs. It is ignored. However, + // URLDeprecated is deprecated in Helm 3, superseded by URLs. It is ignored. However, // with a strict YAML parser enabled, this must be present on the struct. URLDeprecated string `json:"url,omitempty"` } diff --git a/pkg/storage/driver/sql.go b/pkg/storage/driver/sql.go index f68f50f54..2e68b5f36 100644 --- a/pkg/storage/driver/sql.go +++ b/pkg/storage/driver/sql.go @@ -288,7 +288,7 @@ func (s *SQL) Query(labels map[string]string) ([]*rspb.Release, error) { sb = sb.Where(sq.Eq{key: labels[key]}) } else { s.Log("unknown label %s", key) - return nil, fmt.Errorf("unknow label %s", key) + return nil, fmt.Errorf("unknown label %s", key) } } diff --git a/pkg/storage/storage.go b/pkg/storage/storage.go index cfc0d0deb..d836a412a 100644 --- a/pkg/storage/storage.go +++ b/pkg/storage/storage.go @@ -156,7 +156,7 @@ func (s *Storage) History(name string) ([]*rspb.Release, error) { return s.Driver.Query(map[string]string{"name": name, "owner": "helm"}) } -// removeLeastRecent removes items from history until the lengh number of releases +// removeLeastRecent removes items from history until the length number of releases // does not exceed max. // // We allow max to be set explicitly so that calling functions can "make space" diff --git a/pkg/storage/storage_test.go b/pkg/storage/storage_test.go index ee14962ed..ac79ca2fd 100644 --- a/pkg/storage/storage_test.go +++ b/pkg/storage/storage_test.go @@ -361,7 +361,7 @@ func TestStorageRemoveLeastRecent(t *testing.T) { } } -func TestStorageDontDeleteDeployed(t *testing.T) { +func TestStorageDoNotDeleteDeployed(t *testing.T) { storage := Init(driver.NewMemory()) storage.Log = t.Logf storage.MaxHistory = 3 diff --git a/testdata/releases.yaml b/testdata/releases.yaml index fef79f424..e960e815d 100644 --- a/testdata/releases.yaml +++ b/testdata/releases.yaml @@ -17,7 +17,7 @@ status: deployed chart: metadata: - name: prothos-chart + name: porthos-chart version: 0.2.0 appversion: 0.2.2 - name: aramis