root
/
helm
mirror of https://github.com/helm/helm.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #31060 from yumeiyin/main 

refactor: replace Split in loops with more efficient SplitSeq
This commit is contained in:
George Jenkins 2025-07-18 07:50:10 -07:00 committed by GitHub
parent 619035d789 8c22fbfe4a
commit 8face0e596
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/chart/v2/util/dependencies.go
View File

@ -38,7 +38,7 @@ func processDependencyConditions(reqs []*chart.Dependency, cvals Values, cpath s
return return
} }
for _, r := range reqs { for _, r := range reqs {
for _, c := range strings.Split(strings.TrimSpace(r.Condition), ",") { for c := range strings.SplitSeq(strings.TrimSpace(r.Condition), ",") {
if len(c) > 0 { if len(c) > 0 {
// retrieve value // retrieve value
vv, err := cvals.PathValue(cpath + c) vv, err := cvals.PathValue(cpath + c)

2
pkg/cmd/load_plugins.go
View File

@ -350,7 +350,7 @@ func pluginDynamicComp(plug *plugin.Plugin, cmd *cobra.Command, args []string, t
} }
var completions []string var completions []string
for _, comp := range strings.Split(buf.String(), "\n") { for comp := range strings.SplitSeq(buf.String(), "\n") {
// Remove any empty lines // Remove any empty lines
if len(comp) > 0 { if len(comp) > 0 {
completions = append(completions, comp) completions = append(completions, comp)

4
pkg/release/util/manifest_sorter.go
View File

@ -185,7 +185,7 @@ func (file *manifestFile) sort(result *result) error {
} }
isUnknownHook := false isUnknownHook := false
for _, hookType := range strings.Split(hookTypes, ",") { for hookType := range strings.SplitSeq(hookTypes, ",") {
hookType = strings.ToLower(strings.TrimSpace(hookType)) hookType = strings.ToLower(strings.TrimSpace(hookType))
e, ok := events[hookType] e, ok := events[hookType]
if !ok { if !ok {
@ -236,7 +236,7 @@ func calculateHookWeight(entry SimpleHead) int {
// operateAnnotationValues finds the given annotation and runs the operate function with the value of that annotation // operateAnnotationValues finds the given annotation and runs the operate function with the value of that annotation
func operateAnnotationValues(entry SimpleHead, annotation string, operate func(p string)) { func operateAnnotationValues(entry SimpleHead, annotation string, operate func(p string)) {
if dps, ok := entry.Metadata.Annotations[annotation]; ok { if dps, ok := entry.Metadata.Annotations[annotation]; ok {
for _, dp := range strings.Split(dps, ",") { for dp := range strings.SplitSeq(dps, ",") {
dp = strings.ToLower(strings.TrimSpace(dp)) dp = strings.ToLower(strings.TrimSpace(dp))
operate(dp) operate(dp)
} }