root
/
helm
mirror of https://github.com/helm/helm.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #30928 from TerryHowe/fix-plugin-install-no-internet
build-test / build (push) Waiting to run Details
CodeQL / Analyze (go) (push) Waiting to run Details
golangci-lint / golangci-lint (push) Waiting to run Details
release / release (push) Waiting to run Details
release / canary-release (push) Waiting to run Details
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run Details 

fix: plugin installer test with no Internet
This commit is contained in:
Scott Rigby 2025-05-28 10:27:56 -04:00 committed by GitHub
parent 01adbab466 cc39d2428f
commit d4e58c54ba
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/plugin/installer/vcs_installer_test.go
View File

@ -19,6 +19,7 @@ import (
"fmt"
"os"
"path/filepath"
"strings"
"testing"
"github.com/Masterminds/vcs"
@ -119,6 +120,8 @@ func TestVCSInstallerNonExistentVersion(t *testing.T) {
if err := Install(i); err == nil {
t.Fatalf("expected error for version does not exists, got none")
} else if strings.Contains(err.Error(), "Could not resolve host: github.com") {
t.Skip("Unable to run test without Internet access")
} else if err.Error() != fmt.Sprintf("requested version %q does not exist for plugin %q", version, source) {
t.Fatalf("expected error for version does not exists, got (%v)", err)
}
@ -146,7 +149,11 @@ func TestVCSInstallerUpdate(t *testing.T) {
// Install plugin before update
if err := Install(i); err != nil {
t.Fatal(err)
if strings.Contains(err.Error(), "Could not resolve host: github.com") {
t.Skip("Unable to run test without Internet access")
} else {
t.Fatal(err)
}
}
// Test FindSource method for positive result