Multiple changes were made to pass linting. Some Go built-in names
are being used for variables (e.g., min). This happens in the Go
source itself including the Go standard library and is not always
a bad practice.
To handle allowing some built-in names to be used the linter config
is updated to allow (via opt-in) some names to pass. This allows us
to still check for re-use of Go built-in names and opt-in to any
new uses.
There were also several cases where a value was checked for nil
before checking its length when this is already handled by len()
or the types default value. These were cleaned up.
The license validation was updated because it was checking everything
in the .git directory including all remote content that was local.
The previous vendor directory was from a time prior to Go modules
when Helm handled dependencies differently. It was no longer needed.
Signed-off-by: Matt Farina <matt.farina@suse.com>
Updates the script to use the new method of getting
the latest version that avoids the github API and
the associated rate limits. See the matching PR
at https://github.com/helm/helm/pull/12396 for
the server side change.
Signed-off-by: Ian Zink <zforce@gmail.com>
By specify the binary-name in the copy-operation the
script will fail if the directory does not exist instead
of silently installing the binary with the name of
the directory (e.g. /usr/local/bin)
Closes#10298
Signed-off-by: Dominik Stadler <dominik.stadler@gmx.at>
When `get`/`get-helm-3` is run with a HELM_INSTALL_DIR containing spaces, the installation fails.
Closes#9346
Signed-off-by: Michael Musenbrock <michael.musenbrock@gmail.com>
What this PR does / why we need it:
fix for issue #9253. The link taken from the projects GitHub page has been used for consistency across the documentation.
Signed-off-by: Jack Whitter-Jones <jackwhitterjones@gmail.com>
Now no matter what desired version provides, always give info "Helm ${TAG} is available.
Changing from version ${version}". It's obviously wrong.
This patch check whether desired version is actually available or not
by compare desired vesion with all available version in
https://github.com/helm/helm/releases
Signed-off-by: Ma Xinjian <maxj.fnst@cn.fujitsu.com>
* Add GPG signature verification to install script
The script fetches the KEYS file from GitHub, as well
as the .asc files on the release and verifies the
release artifacts are signed by a valid key.
Added new boolean config options in the install script
which allow for fine-grained control over verification
and output:
- DEBUG: sets -x in the bash script (default: false)
- VERIFY_CHECKSUM: verifies checksum (default: true)
- VERIFY_SIGNATURE: verifies signature (default: true)
Also reduced check for curl/wget to only one time.
Resolves#7943.
Resolves#7838.
Signed-off-by: Josh Dolitsky <393494+jdolitsky@users.noreply.github.com>
* disable signature verification by default
Signed-off-by: Josh Dolitsky <393494+jdolitsky@users.noreply.github.com>
* remove repeated line
Signed-off-by: Josh Dolitsky <393494+jdolitsky@users.noreply.github.com>
* fix typo
Signed-off-by: Josh Dolitsky <393494+jdolitsky@users.noreply.github.com>
* do not auto-import GPG keys
Signed-off-by: Josh Dolitsky <393494+jdolitsky@users.noreply.github.com>
* silence errors about missing commands
Signed-off-by: Josh Dolitsky <393494+jdolitsky@users.noreply.github.com>
* use a temporary gpg keyring
Signed-off-by: Josh Dolitsky <393494+jdolitsky@users.noreply.github.com>
* Fix wget commands for VERIFY_SIGNATURES=true
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
This file was previously used for shell completions but is
no longer in use as there is a new completions system in place
and there has been for some time.
The contents of this file were out of date and reflect Helm v2.
Closes#8186
Signed-off-by: Matt Farina <matt@mattfarina.com>
When installing Helm, the following warning gets printed on the console:
Downloading https://get.helm.sh/helm-v2.16.6-linux-amd64.tar.gz
Preparing to install helm and tiller into /usr/local/bin
helm installed into /usr/local/bin/helm
tiller installed into /usr/local/bin/tiller
main: line 178: which: command not found
Run 'helm init' to configure helm.
The 'which' command is optional, and not always installed on all
environments (like a Fedora container). Instead, use 'command -v' to
detect if the executable is in the $PATH.
Signed-off-by: Niels de Vos <ndevos@redhat.com>
A recent change to the get scripts causes them to pickup
pre-releases in addition to stable releases. This update causes
only stable releases to be fetched by the get scripts.
Fixed#7941
Signed-off-by: Matt Farina <matt@mattfarina.com>
* Make get script eaiser for helm versions to live side by side (helm3 etc)
Signed-off-by: Scott Rigby <scott@r6by.com>
* Change PROJECT_NAME to BINARY_NAME for purpose clarity
Signed-off-by: Scott Rigby <scott@r6by.com>
The mapfile command is not available on a standard MacOS install.
To faciliate doing `make test` which runs validate-license.sh,
let's use an array instead of mapfile.
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
This is a temporary fix. This prevents the get script from installing Helm 3 as soon as it's released, potentially causing disruption to users that were expecting a Helm 2 release.
A `get-helm-3` script is also supplied, which is identical to the previous `get` script. That way, Helm 3 users also have an equivalent way to install Helm 3.
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Eimhin Laverty
Matt Farina
Evans Mungai
Asmit De
Joe Julian
Marcel Humburg
Ian Zink
shoce
Antony Chazapis
Andrew Block
Justin Wood
Wonyeong Choi
yxxhero
Ioan Indreias
Dominik Stadler
Dan Russell
Cameron Motevasselani
Martin Hickey
Matt Farina
Ajay Victor
Joe Lanford
Michael Musenbrock
houfangdong
Matthew Fisher
Jack Whitter-Jones
Ma Xinjian
Scott Rigby
Josh Dolitsky
vitt-bagal
Niels de Vos
Bridget Kromhout
Paul Czarkowski
Marc Khouzam