root
/
ice
mirror of https://github.com/alibaba/ice.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Fix: modified task alias not be consumed (#6296) 

* fix: task alias not be consumed

* chore: changeset

* fix: taskConfigs side effects
This commit is contained in:
luhc228 2023-06-07 19:22:55 +08:00 committed by GitHub
parent effe79860c
commit abdd49de8d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/tiny-plants-learn.md Normal file
View File

@ -0,0 +1,5 @@
---
'@ice/app': patch
---
fix: modified task alias not be used

8
packages/ice/src/createService.ts
View File

@ -37,6 +37,7 @@ import { logger, createLogger } from './utils/logger.js';
import ServerRunner from './service/ServerRunner.js';
import RouteManifest from './utils/routeManifest.js';
import dynamicImport from './utils/dynamicImport.js';
import mergeTaskConfig from './utils/mergeTaskConfig.js';
import addPolyfills from './utils/runtimePolyfill.js';
const require = createRequire(import.meta.url);
@ -232,10 +233,13 @@ async function createService({ rootDir, command, commandArgs }: CreateServiceOpt
const csr = !userConfig.ssr && !userConfig.ssg;
const disableRouter = userConfig?.optimization?.router && routesInfo.routesCount <= 1;
let taskAlias = {};
if (disableRouter) {
logger.info('`optimization.router` is enabled and only have one route, ice build will remove react-router and history which is unnecessary.');
taskAlias['@ice/runtime/router'] = path.join(require.resolve('@ice/runtime'), '../single-router.js');
taskConfigs = mergeTaskConfig(taskConfigs, {
alias: {
'@ice/runtime/router': '@ice/runtime/single-router',
},
});
}
addPolyfills(generatorAPI, userConfig.featurePolyfill, rootDir, command === 'start');