root
/
jenkins
mirror of https://github.com/jenkinsci/jenkins.git
1
0
Fork 0
Code Issues Actions 7 Packages Projects Releases Wiki Activity

[JENKINS-73744] Tweaks to Node.js contributing instructions + renovate fix (#9757) 

Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
Co-authored-by: Basil Crow <me@basilcrow.com>
This commit is contained in:
Thorsten Scherler 2024-09-21 09:36:59 +02:00 committed by GitHub
parent f5ccd65e4e
commit 10154f645c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/renovate.json vendored
View File

@ -128,7 +128,7 @@
{ {
"customType": "regex", "customType": "regex",
"fileMatch": [ "fileMatch": [
"war/pom.xml" "pom.xml"
], ],
"matchStrings": [ "matchStrings": [
"<node.version>(?<currentValue>.*?)</node.version>" "<node.version>(?<currentValue>.*?)</node.version>"

3
.gitignore vendored
View File

@ -79,3 +79,6 @@ node_modules/
# Generated JavaScript Bundles # Generated JavaScript Bundles
jsbundles jsbundles
# In case someone accidentally runs npm install instead of yarn install
package-lock.json

9
CONTRIBUTING.md
View File

@ -52,6 +52,9 @@ MAVEN_OPTS='--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/ja
### Running the Yarn frontend build ### Running the Yarn frontend build
> [!TIP]
> If you already have Node.js installed, you do not need to change your path. Start using `yarn` by enabling [Corepack](https://yarnpkg.com/corepack) with `corepack enable`, if it isn't already; this will add the `yarn` binary to your PATH.
To run the Yarn frontend build, after [building the WAR file](#building-the-war-file), add the downloaded versions of Node and Yarn to your path: To run the Yarn frontend build, after [building the WAR file](#building-the-war-file), add the downloaded versions of Node and Yarn to your path:
```sh ```sh
@ -74,7 +77,7 @@ On one terminal, start a development server that will not process frontend asset
MAVEN_OPTS='--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED' mvn -pl war jetty:run -Dskip.yarn MAVEN_OPTS='--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED' mvn -pl war jetty:run -Dskip.yarn
``` ```
Open another terminal and start a [webpack](https://webpack.js.org/) dev server, after [adding Node and Yarn to your path](#running-the-yarn-frontend-build): Open another terminal and start a [webpack](https://webpack.js.org/) dev server, after [optionally adding Node and Yarn to your path](#running-the-yarn-frontend-build):
```sh ```sh
yarn start yarn start
@ -108,13 +111,13 @@ To automatically fix backend issues, run:
mvn spotless:apply mvn spotless:apply
``` ```
To view frontend issues, after [adding Node and Yarn to your path](#running-the-yarn-frontend-build), run: To view frontend issues, after [optionally adding Node and Yarn to your path](#running-the-yarn-frontend-build), run:
```sh ```sh
yarn lint yarn lint
``` ```
To fix frontend issues, after [adding Node and Yarn to your path](#running-the-yarn-frontend-build), run: To fix frontend issues, after [optionally adding Node and Yarn to your path](#running-the-yarn-frontend-build), run:
```sh ```sh
yarn lint:fix yarn lint:fix