root
/
jenkins
mirror of https://github.com/jenkinsci/jenkins.git
1
0
Fork 0
Code Issues Actions 12 Packages Projects Releases Wiki Activity

extract delete to method 

needed to be able to apply the annotation
This commit is contained in:
Markus Winter 2025-09-18 20:25:07 +02:00
parent c03fcac9d8
commit ab342c04e2
1 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
core/src/main/java/hudson/model/FileParameterValue.java
View File

@ -306,7 +306,6 @@ public class FileParameterValue extends ParameterValue {
@Extension
public static class CancelledQueueListener extends QueueListener {
@SuppressFBWarnings(value = "PATH_TRAVERSAL_IN", justification = "False positive, the path is a temporary file")
@Override
public void onLeft(Queue.LeftItem li) {
if (li.isCancelled()) {
@ -315,20 +314,23 @@ public class FileParameterValue extends ParameterValue {
a.getAllParameters().stream()
.filter(p -> p instanceof FileParameterValue)
.map(p -> (FileParameterValue) p)
.forEach(p -> {
if (p.tmpFileName != null) {
File tmp = new File(p.tmpFileName);
try {
Files.deleteIfExists(tmp.toPath());
} catch (IOException e) {
LOGGER.log(Level.WARNING, "Unable to delete temporary file {0} for parameter {1} of task {2}",
new Object[]{tmp.getAbsolutePath(), p.getName(), li.task.getName()});
}
}
});
.forEach(this::deleteTmpFile);
});
}
}
@SuppressFBWarnings(value = "PATH_TRAVERSAL_IN", justification = "False positive, the path is a temporary file")
private void deleteTmpFile(FileParameterValue p) {
if (p.tmpFileName != null) {
File tmp = new File(p.tmpFileName);
try {
Files.deleteIfExists(tmp.toPath());
} catch (IOException e) {
LOGGER.log(Level.WARNING, "Unable to delete temporary file {0} for parameter {1}",
new Object[]{tmp.getAbsolutePath(), p.getName()});
}
}
}
}
/**